diff options
| author | truckman <truckman@FreeBSD.org> | 2016-05-25 00:25:38 +0000 |
|---|---|---|
| committer | truckman <truckman@FreeBSD.org> | 2016-05-25 00:25:38 +0000 |
| commit | 0eaef17c3b4f468a3eb170aa0b7b6563d24cb177 (patch) | |
| tree | 402c1c641aee9a420d8b766db18ec7a11ce8e2f7 | |
| parent | 83a68a204841e8eb8fc6cdfe32fd5249b8be8358 (diff) | |
| download | FreeBSD-src-0eaef17c3b4f468a3eb170aa0b7b6563d24cb177.zip FreeBSD-src-0eaef17c3b4f468a3eb170aa0b7b6563d24cb177.tar.gz | |
Delay calling yp_malloc_dnsent() until after some additional sanity
checks to avoid leaking memory on error returns.
Reported by: Coverity
CID: 1007416
MFC after: 1 week
| -rw-r--r-- | usr.sbin/ypserv/yp_dnslookup.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/usr.sbin/ypserv/yp_dnslookup.c b/usr.sbin/ypserv/yp_dnslookup.c index 1d83b64..6534967 100644 --- a/usr.sbin/ypserv/yp_dnslookup.c +++ b/usr.sbin/ypserv/yp_dnslookup.c @@ -489,9 +489,6 @@ yp_async_lookup_addr(struct svc_req *rqstp, char *addr, int af) yp_find_dnsqent(svcudp_get_xid(rqstp->rq_xprt),BY_RPC_XID) != NULL) return(YP_TRUE); - if ((q = yp_malloc_dnsent()) == NULL) - return(YP_YPERR); - switch (af) { case AF_INET: if (inet_aton(addr, (struct in_addr *)uaddr) != 1) @@ -516,6 +513,9 @@ yp_async_lookup_addr(struct svc_req *rqstp, char *addr, int af) return(YP_YPERR); } + if ((q = yp_malloc_dnsent()) == NULL) + return(YP_YPERR); + if (debug) yp_error("DNS address is: %s", buf); |
