summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjlemon <jlemon@FreeBSD.org>2001-10-25 05:56:30 +0000
committerjlemon <jlemon@FreeBSD.org>2001-10-25 05:56:30 +0000
commit0ecfb417cf04f7a4497d6b4b0499fa4decf0ecaa (patch)
tree2d41083325df8369c8def0e154cab63065719657
parent7371c931933157b0120dd26eb9d78bcff2299d72 (diff)
downloadFreeBSD-src-0ecfb417cf04f7a4497d6b4b0499fa4decf0ecaa.zip
FreeBSD-src-0ecfb417cf04f7a4497d6b4b0499fa4decf0ecaa.tar.gz
Relocate the KASSERT for a null recvif to a location where it will
actually do some good. Pointed out by: ru
-rw-r--r--sys/netinet/ip_icmp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/netinet/ip_icmp.c b/sys/netinet/ip_icmp.c
index f2071af..331fe81 100644
--- a/sys/netinet/ip_icmp.c
+++ b/sys/netinet/ip_icmp.c
@@ -607,6 +607,7 @@ icmp_reflect(m)
LIST_FOREACH(ia, INADDR_HASH(t.s_addr), ia_hash)
if (t.s_addr == IA_SIN(ia)->sin_addr.s_addr)
goto match;
+ KASSERT(m->m_pkthdr.rcvif != NULL, ("icmp_reflect: NULL rcvif"));
if (m->m_pkthdr.rcvif->if_flags & IFF_BROADCAST) {
TAILQ_FOREACH(ifa, &m->m_pkthdr.rcvif->if_addrhead, ifa_link) {
if (ifa->ifa_addr->sa_family != AF_INET)
@@ -617,7 +618,6 @@ icmp_reflect(m)
goto match;
}
}
- KASSERT(m->m_pkthdr.rcvif != NULL, ("icmp_reflect: NULL rcvif"));
icmpdst.sin_addr = t;
ia = (struct in_ifaddr *)ifaof_ifpforaddr(
(struct sockaddr *)&icmpdst, m->m_pkthdr.rcvif);
OpenPOWER on IntegriCloud