From 0ecfb417cf04f7a4497d6b4b0499fa4decf0ecaa Mon Sep 17 00:00:00 2001 From: jlemon Date: Thu, 25 Oct 2001 05:56:30 +0000 Subject: Relocate the KASSERT for a null recvif to a location where it will actually do some good. Pointed out by: ru --- sys/netinet/ip_icmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netinet/ip_icmp.c b/sys/netinet/ip_icmp.c index f2071af..331fe81 100644 --- a/sys/netinet/ip_icmp.c +++ b/sys/netinet/ip_icmp.c @@ -607,6 +607,7 @@ icmp_reflect(m) LIST_FOREACH(ia, INADDR_HASH(t.s_addr), ia_hash) if (t.s_addr == IA_SIN(ia)->sin_addr.s_addr) goto match; + KASSERT(m->m_pkthdr.rcvif != NULL, ("icmp_reflect: NULL rcvif")); if (m->m_pkthdr.rcvif->if_flags & IFF_BROADCAST) { TAILQ_FOREACH(ifa, &m->m_pkthdr.rcvif->if_addrhead, ifa_link) { if (ifa->ifa_addr->sa_family != AF_INET) @@ -617,7 +618,6 @@ icmp_reflect(m) goto match; } } - KASSERT(m->m_pkthdr.rcvif != NULL, ("icmp_reflect: NULL rcvif")); icmpdst.sin_addr = t; ia = (struct in_ifaddr *)ifaof_ifpforaddr( (struct sockaddr *)&icmpdst, m->m_pkthdr.rcvif); -- cgit v1.1