1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
|
#!/bin/sh
# ports/Mk/Scripts/check-stagedir.sh - called from ports/Mk/bsd.stage.mk
# $FreeBSD$
#
# MAINTAINER: portmgr@FreeBSD.org
#
# This script serves 2 purposes:
# 1. Generate a plist
# 2. Test a plist for issues:
# a. Files in STAGEDIR that are missing from plist
# b. Files in plist missing from STAGEDIR
# c. Files in plist which are owned by dependencies/MTREEs
set -e
export LC_ALL=C
#### EXPAND TMPPLIST TO ABSOLUTE PATHS, SPLITTING FILES AND DIRS TO
# Use file descriptors 1 and 3 so that the while loop can write
# files to the pipe and dirs to a separate file.
parse_plist() {
echo "===> Parsing plist"
cwd=${PREFIX}
cwd_save=
commented_cwd=
while read line; do
# Handle deactivated OPTIONS. Treat "@comment file" as being in
# the plist so it does not show up as an orphan. PLIST_SUB uses
# a @comment to deactive files. XXX: It would be better to
# make all ports use @ignore instead of @comment.
comment=
if [ ${makeplist} -eq 0 -a -z "${line%%@comment *}" ]; then
line="${line##*@comment }"
# Remove @comment so it can be parsed as a file,
# but later prepend it again to create a list of
# all files commented and uncommented.
comment="@comment "
# Only consider comment @cwd for commented lines
if [ -n "${commented_cwd}" ]; then
[ -z "${cwd_save}" ] && cwd_save=${cwd}
cwd=${commented_cwd}
fi
else
# On first uncommented line, forget about commented
# @cwd
if [ -n "${cwd_save}" ]; then
cwd=${cwd_save}
cwd_save=
commented_cwd=
fi
fi
case $line in
@dirrm*|'@unexec rmdir'*|'@unexec /bin/rmdir'*)
line="$(printf %s "$line" \
| sed -Ee 's/\|\|.*//;s|[[:space:]]+[0-9]*[[:space:]]*>[&]?[[:space:]]*[^[:space:]]+||g' \
-e "/^@unexec[[:space:]]+(\/bin\/)?rmdir( -p)?/s|([^%])%D([^%])|\1${cwd}\2|g" \
-e '/^@unexec[[:space:]]+(\/bin\/)?rmdir( -p)?/s|"(.*)"[[:space:]]*|\1|g' \
-e 's/@unexec[[:space:]]+(\/bin\/)?rmdir( -p)?[[:space:]]+//' \
-e 's/@dirrm(try)?[[:space:]]+//' \
-e 's/[[:space:]]+$//')"
case "$line" in
/*) echo >&3 "${comment}${line%/}" ;;
*) echo >&3 "${comment}${cwd}/${line%/}" ;;
esac
;;
# Handle [file] Keywords
@info\ *|@shell\ *)
set -- $line
shift
echo "${comment}${cwd}/$@"
;;
@sample\ *)
set -- $line
shift
# Ignore the actual file if it is in stagedir
echo "@comment ${cwd}/${@%.sample}"
echo "${comment}${cwd}/$@"
;;
# Handle [dirrmty] Keywords
@fc\ *|@fcfontsdir\ *|@fontsdir\ *)
set -- $line
shift
echo >&3 "${comment}${cwd}/$@"
;;
# order matters here - we must check @cwd first because
# otherwise the @cwd* would also match it first, shadowing the
# @cwd) line.
@cwd|@cd)
# Don't actually reset cwd for commented @cwd
if [ -n "${comment}" ]; then
commented_cwd=${PREFIX}
else
cwd=${PREFIX}
fi
;;
@cwd*|@cd*)
set -- $line
newcwd=$2
# Don't set cwd=/ as it causes // in plist and
# won't match later.
[ "${newcwd}" = "/" ] && newcwd=
# Don't actually reset cwd for commented @cwd
if [ -n "${comment}" ]; then
commented_cwd=${newcwd}
else
cwd=${newcwd}
fi
unset newcwd
;;
@*) ;;
/*) echo "${comment}${line}" ;;
*) echo "${comment}${cwd}/${line}" ;;
esac
done < ${TMPPLIST} 3>${WRKDIR}/.plist-dirs-unsorted \
>${WRKDIR}/.plist-files-unsorted
unset TMPPLIST
# Create the -no-comments files and trim out @comment from the plists.
# This is used for various tests later.
sed -e '/^@comment/d' ${WRKDIR}/.plist-dirs-unsorted \
>${WRKDIR}/.plist-dirs-unsorted-no-comments
sed -i '' -e 's/^@comment //' ${WRKDIR}/.plist-dirs-unsorted
sed -e '/^@comment/d' ${WRKDIR}/.plist-files-unsorted | sort \
>${WRKDIR}/.plist-files-no-comments
sed -e 's/^@comment //' ${WRKDIR}/.plist-files-unsorted | sort \
>${WRKDIR}/.plist-files
}
# lists an mtree file's contents, prefixed to dir.
listmtree() { # mtreefile prefix
{
echo '#mtree'
sed 's/nochange$//;' $1
} | tar -tf- | sed "s,^,$2/,;s,^$2/\.$,$2,;s,^$,/,"
}
### PRODUCE MTREE FILE
parse_mtree() {
{
listmtree /etc/mtree/BSD.root.dist ""
listmtree /etc/mtree/BSD.usr.dist /usr
listmtree /etc/mtree/BSD.var.dist /var
# Use MTREE_FILE if specified and it doesn't already
# match LOCALBASE
if [ -n "${MTREE_FILE}" ]; then
if [ "${PREFIX}" != "${LOCALBASE}" -o "${MTREE_FILE}" \
!= "${PORTSDIR}/Templates/BSD.local.dist" ]; then
listmtree "${MTREE_FILE}" "${PREFIX}"
fi
fi
listmtree "${PORTSDIR}/Templates/BSD.local.dist" "${LOCALBASE}"
if [ -n "${GNOME_MTREE_FILE}" ] && \
[ -f "${GNOME_MTREE_FILE}" ]; then
listmtree "${GNOME_MTREE_FILE}" "${PREFIX}"
fi
unset MTREE_FILE GNOME_MTREE_FILE
# Add LOCALBASE
a=${LOCALBASE}
while :; do
echo ${a}
a=${a%/*}
[ -z "${a}" ] && break
done
# Add in PREFIX if this port wants it
if [ ${NO_PREFIX_RMDIR} -eq 0 ]; then
a=${PREFIX}
while :; do
echo ${a}
a=${a%/*}
[ -z "${a}" ] && break
done
fi
} >${WRKDIR}/.mtree
}
pkg_get_recursive_deps() {
echo "$@"
PKG_CHECKED="${PKG_CHECKED} $@"
for depends in $(${PKG_QUERY} '%do' $@ | sort -u); do
[ -z "${depends}" ] && return
case " ${PKG_CHECKED} " in
*\ ${depends}\ *) continue ;;
esac
pkg_get_recursive_deps "${depends}"
done
}
### GATHER DIRS OWNED BY RUN-DEPENDS. WHY ARE WE SCREAMING?
lookup_dependency_dirs() {
: >${WRKDIR}/.run-depends-dirs
if [ -n "${PACKAGE_DEPENDS}" ]; then
echo "${PACKAGE_DEPENDS}" | while read pkg; do \
PKG_CHECKED= pkg_get_recursive_deps "${pkg}"; \
done | sort -u | xargs ${PKG_QUERY} "%D" | \
sed -e 's,/$,,' | sort -u \
>>${WRKDIR}/.run-depends-dirs
fi
}
# Sort a directory list by the order of the dfs-sorted file (from find -ds)
sort_dfs() {
while read dir; do
grep "^[0-9]* ${dir}$" ${WRKDIR}/.staged-dirs-dfs-sorted
done | sort -n | cut -d ' ' -f2-
}
# Prepare sed(1) regex for PLIST_SUB_SED/PORTEXAMPLES/OPTIONS/...
setup_plist_seds() {
### HANDLE PORTDOCS/PORTEXAMPLES
sed_portdocsexamples="/%%DOCSDIR%%/s!^!%%PORTDOCS%%!g; /%%EXAMPLESDIR%%/s!^!%%PORTEXAMPLES%%!g;"
if [ ${makeplist} -eq 0 ]; then
# echo "=====> Using OPTIONS: ${PORT_OPTIONS}" | /usr/bin/fmt -w 79 | \
# sed -e '2,$s/^/ /'
# Handle magical PORT* features
for option in DOCS EXAMPLES; do
want_option=0
case " ${PORT_OPTIONS} " in
*\ ${option}\ *) want_option=1 ;;
esac
[ ${want_option} -eq 0 ] && \
sed_portdocsexamples="${sed_portdocsexamples} /^%%PORT${option}%%/d;"
done
unset PORT_OPTIONS
fi
sed_plist_sub=$(echo "${PLIST_SUB_SED}" | /bin/sh ${SCRIPTSDIR}/plist_sub_sed_sort.sh)
unset PLIST_SUB_SED
# Used for generate_plist
sed_files_gen="s!${PREFIX}/!!g; ${sed_plist_sub} \
${sed_portdocsexamples} /^share\/licenses/d;"
sed_dirs_gen="s!${PREFIX}/!!g; ${sed_plist_sub} s,^,@dirrmtry ,; \
${sed_portdocsexamples} \
s!@dirrmtry \(/.*\)!@unexec rmdir \"\1\" >/dev/null 2>\&1 || :!; \
/^@dirrmtry share\/licenses/d;"
# These prevent ignoring DOCS/EXAMPLES dirs with sed_portdocsexamples
sed_files="s!${PREFIX}/!!g; ${sed_plist_sub} /^share\/licenses/d;"
sed_dirs="s!${PREFIX}/!!g; ${sed_plist_sub} s,^,@dirrmtry ,; \
s!@dirrmtry \(/.*\)!@unexec rmdir \"\1\" >/dev/null 2>\&1 || :!; \
/^@dirrmtry share\/licenses/d;"
}
# Generate plist from staged files
generate_plist() {
: >${WRKDIR}/.staged-plist
### HANDLE FILES
find ${STAGEDIR} -type f -o -type l | sort | \
sed -e "s,${STAGEDIR},," >${WRKDIR}/.staged-files
comm -13 ${WRKDIR}/.plist-files ${WRKDIR}/.staged-files | \
sed -e "${sed_files_gen}" \
>>${WRKDIR}/.staged-plist || :
### HANDLE DIRS
cat ${WRKDIR}/.plist-dirs-unsorted ${WRKDIR}/.mtree \
${WRKDIR}/.run-depends-dirs | sort -u >${WRKDIR}/.traced-dirs
find -sd ${STAGEDIR} -type d | sed -e "s,^${STAGEDIR},,;/^$/d" \
>${WRKDIR}/.staged-dirs-dfs
sort ${WRKDIR}/.staged-dirs-dfs >${WRKDIR}/.staged-dirs-sorted
awk '{print FNR, $0}' ${WRKDIR}/.staged-dirs-dfs \
>${WRKDIR}/.staged-dirs-dfs-sorted
# Find all staged dirs and then sort them by depth-first (find -ds)
comm -13 ${WRKDIR}/.traced-dirs ${WRKDIR}/.staged-dirs-sorted \
| sort_dfs | sed "${sed_dirs_gen}" \
>>${WRKDIR}/.staged-plist || :
}
# Check for files in STAGEDIR missing from plist
check_orphans_from_plist() {
local ret=0
echo "===> Checking for items in STAGEDIR missing from pkg-plist"
# Handle whitelisting
while read path; do
case "${path}" in
*.bak) ;;
*.orig) ;;
*/.DS_Store) ;;
*/.cvsignore) ;;
*/.git/*|'@dirrmtry '*/.git) ;;
*/.gitattributes|*/.gitignore|*/.gitmodules) ;;
*/.svn/*|'@dirrmtry '*/.svn) ;;
*/.svnignore) ;;
*/CVS/*|'@dirrmtry '*/CVS) ;;
*/info/dir|info/dir) ;;
lib/X11/fonts/*/fonts.dir) ;;
lib/X11/fonts/*/fonts.scale) ;;
share/applications/mimeinfo.cache) ;;
share/mime/XMLnamespaces) ;;
share/mime/aliases) ;;
share/mime/generic-icons) ;;
share/mime/globs) ;;
share/mime/globs2) ;;
share/mime/icons) ;;
share/mime/magic) ;;
share/mime/mime.cache) ;;
share/mime/subclasses) ;;
share/mime/treemagic) ;;
share/mime/types) ;;
share/mime/version) ;;
*)
# An orphan was found, return non-zero status
ret=1
echo "Error: Orphaned: ${path}" >&2
;;
esac
done < ${WRKDIR}/.staged-plist
return ${ret}
}
# Check for directories being removed that are handled by MTREE files.
check_invalid_directories_mtree() {
local ret=0
# Anything listed in plist and in restricted-dirs is a failure. I.e.,
# it's owned by a run-time dependency or one of the MTREEs.
echo "===> Checking for directories owned by MTREEs"
cat ${WRKDIR}/.mtree | sort -u >${WRKDIR}/.restricted-dirs
: >${WRKDIR}/.invalid-plist-mtree
comm -12 ${WRKDIR}/.plist-dirs-sorted-no-comments \
${WRKDIR}/.restricted-dirs \
| sort_dfs | sed "${sed_dirs}" \
>>${WRKDIR}/.invalid-plist-mtree || :
if [ -s "${WRKDIR}/.invalid-plist-mtree" ]; then
while read line; do
# Skip removal of PREFIX and PREFIX/info from
# bsd.port.mk for now. The removal of info may
# be a bug; it's part of BSD.local.dist.
# See ports/74691
if [ "${PREFIX}" != "${LOCALBASE}" ]; then
case "${line}" in
"@dirrmtry info") continue ;;
"@unexec rmdir \"${PREFIX}\" >/dev/null 2>&1 || :") continue ;;
esac
fi
ret=1
echo "Error: Owned by MTREE: ${line}" >&2
done < ${WRKDIR}/.invalid-plist-mtree
fi
return ${ret}
}
# Check for directories in plist that dependencies already handle.
# XXX: This goes away when pkg learns auto dir tracking
check_invalid_directories_from_dependencies() {
local ret=0
echo "===> Checking for directories handled by dependencies"
cat ${WRKDIR}/.run-depends-dirs | sort -u >${WRKDIR}/.restricted-dirs
: >${WRKDIR}/.invalid-plist-dependencies
comm -12 ${WRKDIR}/.plist-dirs-sorted-no-comments \
${WRKDIR}/.restricted-dirs \
| sort_dfs | sed "${sed_dirs}" \
>>${WRKDIR}/.invalid-plist-dependencies || :
if [ -s "${WRKDIR}/.invalid-plist-dependencies" ]; then
# ret=1
while read line; do
echo "Warning: Possibly owned by dependency: ${line}" \
>&2
done < ${WRKDIR}/.invalid-plist-dependencies
fi
return ${ret}
}
# Check for items in plist not in STAGEDIR (pkg lstat(2) errors)
check_missing_plist_items() {
local ret=0
echo "===> Checking for items in pkg-plist which are not in STAGEDIR"
: >${WRKDIR}/.invalid-plist-missing
comm -23 ${WRKDIR}/.plist-files-no-comments ${WRKDIR}/.staged-files | \
sed -e "${sed_files}" \
>>${WRKDIR}/.invalid-plist-missing || :
# Look for directories, then sort them by DFS. Must create the dirs
# so find -ds can be used to sort them.
rm -rf ${WRKDIR}/.missing-dirs > /dev/null 2>&1 || :
mkdir ${WRKDIR}/.missing-dirs
comm -23 ${WRKDIR}/.plist-dirs-sorted-no-comments \
${WRKDIR}/.staged-dirs-sorted > ${WRKDIR}/.missing-plist-dirs
# Creates the dirs in WRKDIR/.missing-dirs and ensure spaces are
# quoted.
sed -e "s,^,${WRKDIR}/.missing-dirs," \
-e 's,^\(.*\)$,"\1",' \
${WRKDIR}/.missing-plist-dirs | xargs mkdir -p
find -ds ${WRKDIR}/.missing-dirs | \
sed -e "s,^${WRKDIR}/.missing-dirs,," | \
while read dir; do \
grep -x "${dir}" ${WRKDIR}/.missing-plist-dirs || :; done | \
sed "${sed_dirs}" \
>>${WRKDIR}/.invalid-plist-missing || :
rm -rf ${WRKDIR}/.missing-dirs
if [ -s "${WRKDIR}/.invalid-plist-missing" ]; then
ret=1
while read line; do
echo "Error: Missing: ${line}" >&2
done < ${WRKDIR}/.invalid-plist-missing
fi
return ${ret}
}
# obtain operating mode from command line
ret=0
makeplist=0
case "$1" in
checkplist) ;;
makeplist) makeplist=1 ;;
*) echo >&2 "Usage: $0 {checkplist|makeplist}" ; exit 1 ;;
esac
# validate environment
envfault=
for i in STAGEDIR PREFIX LOCALBASE WRKDIR WRKSRC MTREE_FILE GNOME_MTREE_FILE \
TMPPLIST PLIST_SUB_SED SCRIPTSDIR PACKAGE_DEPENDS PKG_QUERY \
PORT_OPTIONS NO_PREFIX_RMDIR
do
if ! ( eval ": \${${i}?}" ) 2>/dev/null ; then
envfault="${envfault}${envfault:+" "}${i}"
fi
done
if [ -n "$envfault" ] ; then
echo "Environment variables $envfault undefined. Aborting." \
| fmt >&2
exit 1
fi
set -u
if [ $makeplist = 0 ] ; then
parse_plist
else
# generate plist - pretend the plist had been empty
: >${WRKDIR}/.plist-dirs-unsorted
: >${WRKDIR}/.plist-files
echo '/you/have/to/check/what/makeplist/gives/you'
fi
parse_mtree
lookup_dependency_dirs
unset PACKAGE_DEPENDS PKG_QUERY
setup_plist_seds
generate_plist
# If just making plist, show results and exit successfully.
if [ ${makeplist} -eq 1 ]; then
cat ${WRKDIR}/.staged-plist
exit 0
fi
check_orphans_from_plist || ret=1
# Prepare plist-dirs for directory checks
sort -u ${WRKDIR}/.plist-dirs-unsorted-no-comments \
>${WRKDIR}/.plist-dirs-sorted-no-comments
check_invalid_directories_mtree || ret=1
check_invalid_directories_from_dependencies || ret=1
check_missing_plist_items || ret=1
if [ ${ret} -ne 0 ]; then
echo "===> Error: Plist issues found." >&2
if [ "${PREFIX}" != "${LOCALBASE}" ]; then
echo "===> Warning: Test was done with PREFIX != LOCALBASE"
echo "===> Warning: The port may not be properly installing into PREFIX"
fi
fi
exit ${ret}
|