From abe430cc38ddaf30c911b14d5c69d9278d63f528 Mon Sep 17 00:00:00 2001
From: jim-p <jimp@pfsense.org>
Date: Wed, 31 Oct 2012 14:01:04 -0400
Subject: Encode the if parameter before using it in html

---
 usr/local/www/guiconfig.inc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'usr')

diff --git a/usr/local/www/guiconfig.inc b/usr/local/www/guiconfig.inc
index 310b0d3..c8962c8 100755
--- a/usr/local/www/guiconfig.inc
+++ b/usr/local/www/guiconfig.inc
@@ -311,8 +311,8 @@ function print_info_box_np($msg, $name="apply",$value="", $showapply=false) {
 	if(stristr($msg, gettext("apply")) != false || stristr($msg, gettext("save")) != false || stristr($msg, gettext("create")) != false || $showapply) {
 		$savebutton = "<td class='infoboxsave'>";
 		$savebutton .= "<input name=\"{$name}\" type=\"submit\" class=\"formbtn\" id=\"${name}\" value=\"{$value}\">";
-		if($_POST['if']) 
-			$savebutton .= "<input type='hidden' name='if' value='{$_POST['if']}'>";
+		if($_POST['if'])
+			$savebutton .= "<input type='hidden' name='if' value='" . htmlspecialchars($_POST['if']) . "'>";
 		$savebutton.="</td>";
 	}
 	$nifty_redbox = "#990000";
@@ -375,7 +375,7 @@ function print_info_box_np_undo($msg, $name="apply",$value="Apply changes", $und
 		$savebutton .= " <input name=\"{$name}\" type=\"submit\" class=\"formbtn\" id=\"${name}\" value=\"{$value}\">";
 		$savebutton.="</nobr></td>";
 		if($_POST['if']) 
-			$savebutton .= "<input type='hidden' name='if' value='{$_POST['if']}'>";
+			$savebutton .= "<input type='hidden' name='if' value='" . htmlspecialchars($_POST['if']) . "'>";
 	}
 	$nifty_redbox = "#990000";
 	$nifty_blackbox = "#000000";
-- 
cgit v1.1