From b4e9a4da0f438888abfd7f050964776d5bdf463e Mon Sep 17 00:00:00 2001
From: N0YB <Al_Stu@Frontier.com>
Date: Mon, 16 Jun 2014 00:14:10 -0700
Subject: XHTML Compliance - System Menu

Advanced - Admin Access Tab
Advanced - Firewall / NAT Tab
Cert Manager - Certificate Revocation Tab
User Manager - Users Tab
User Manager - Groups Tab
---
 usr/local/www/system_advanced_admin.php    |  2 +-
 usr/local/www/system_advanced_firewall.php |  2 +-
 usr/local/www/system_crlmanager.php        |  4 ++--
 usr/local/www/system_groupmanager.php      | 14 ++++++++++++--
 usr/local/www/system_usermanager.php       | 14 ++++++++++++--
 5 files changed, 28 insertions(+), 8 deletions(-)

(limited to 'usr')

diff --git a/usr/local/www/system_advanced_admin.php b/usr/local/www/system_advanced_admin.php
index b9874c5..5390ee9 100644
--- a/usr/local/www/system_advanced_admin.php
+++ b/usr/local/www/system_advanced_admin.php
@@ -360,7 +360,7 @@ function prot_change() {
 												if ($pconfig['ssl-certref'] == $cert['refid'])
 													$selected = "selected=\"selected\"";
 										?>
-										<option value="<?=$cert['refid'];?>"<?=$selected;?>><?=$cert['descr'];?></option>
+										<option value="<?=$cert['refid'];?>" <?=$selected;?>><?=$cert['descr'];?></option>
 										<?php endforeach; ?>
 									</select>
 								</td>
diff --git a/usr/local/www/system_advanced_firewall.php b/usr/local/www/system_advanced_firewall.php
index e3a523d..60d1f04 100644
--- a/usr/local/www/system_advanced_firewall.php
+++ b/usr/local/www/system_advanced_firewall.php
@@ -324,7 +324,7 @@ function update_description(itemnum) {
 										<option value="conservative"<?php if($config['system']['optimization']=="conservative") echo " selected=\"selected\""; ?>><?=gettext("conservative");?></option>
 									</select>
 									<br />
-									<textarea readonly="readonly" cols="60" rows="2" id="info" name="info"style="padding:5px; border:1px dashed #990000; background-color: #ffffff; color: #000000; font-size: 8pt;"></textarea>
+									<textarea readonly="readonly" cols="60" rows="2" id="info" name="info" style="padding:5px; border:1px dashed #990000; background-color: #ffffff; color: #000000; font-size: 8pt;"></textarea>
 									<script type="text/javascript">
 									//<![CDATA[
 										update_description(document.forms[0].optimization.selectedIndex);
diff --git a/usr/local/www/system_crlmanager.php b/usr/local/www/system_crlmanager.php
index b66b1ac..099a6e1 100644
--- a/usr/local/www/system_crlmanager.php
+++ b/usr/local/www/system_crlmanager.php
@@ -311,7 +311,7 @@ function method_change() {
 									if ($pconfig['method'] == $method)
 										$selected = "selected=\"selected\"";
 								?>
-									<option value="<?=$method;?>"<?=$selected;?>><?=$desc;?></option>
+									<option value="<?=$method;?>" <?=$selected;?>><?=$desc;?></option>
 								<?php endforeach; ?>
 								</select>
 							</td>
@@ -333,7 +333,7 @@ function method_change() {
 									if ($pconfig['caref'] == $ca['refid'])
 										$selected = "selected=\"selected\"";
 								?>
-									<option value="<?=$ca['refid'];?>"<?=$selected;?>><?=$ca['descr'];?></option>
+									<option value="<?=$ca['refid'];?>" <?=$selected;?>><?=$ca['descr'];?></option>
 								<?php endforeach; ?>
 								</select>
 							</td>
diff --git a/usr/local/www/system_groupmanager.php b/usr/local/www/system_groupmanager.php
index c62a8c8..b2e65f7 100644
--- a/usr/local/www/system_groupmanager.php
+++ b/usr/local/www/system_groupmanager.php
@@ -299,14 +299,19 @@ function presubmit() {
 											<br />
 												<select size="10" style="width: 75%" name="notmembers[]" class="formselect" id="notmembers" onchange="clear_selected('members')" multiple="multiple">
 												<?php
+													$rowIndex = 0;
 													foreach ($config['system']['user'] as $user):
 														if (is_array($pconfig['members']) && in_array($user['uid'],$pconfig['members']))
 															continue;
+														$rowIndex++;
 												?>
 												<option value="<?=$user['uid'];?>" <?=$selected;?>>
 													<?=htmlspecialchars($user['name']);?>
 												</option>
-												<?php endforeach; ?>
+												<?php endforeach;
+												if ($rowIndex == 0)
+													echo "<option></option>";
+												?>
 											</select>
 											<br />
 										</td>
@@ -325,14 +330,19 @@ function presubmit() {
 											<br />
 											<select size="10" style="width: 75%" name="members[]" class="formselect" id="members" onchange="clear_selected('notmembers')" multiple="multiple">
 												<?php
+													$rowIndex = 0;
 													foreach ($config['system']['user'] as $user):
 														if (!(is_array($pconfig['members']) && in_array($user['uid'],$pconfig['members'])))
 															continue;
+														$rowIndex++;
 												?>
 												<option value="<?=$user['uid'];?>">
 													<?=htmlspecialchars($user['name']);?>
 												</option>
-												<?php endforeach; ?>
+												<?php endforeach;
+												if ($rowIndex == 0)
+													echo "<option></option>";
+												?>
 											</select>
 											<br />
 										</td>
diff --git a/usr/local/www/system_usermanager.php b/usr/local/www/system_usermanager.php
index cf7db11..a844922 100644
--- a/usr/local/www/system_usermanager.php
+++ b/usr/local/www/system_usermanager.php
@@ -523,16 +523,21 @@ function sshkeyClicked(obj) {
 											<br />
 											<select size="10" style="width: 75%" name="notgroups[]" class="formselect" id="notgroups" onchange="clear_selected('groups')" multiple="multiple">
 												<?php
+													$rowIndex = 0;
 													foreach ($config['system']['group'] as $group):
 														if ($group['gid'] == 1998) /* all users group */
 															continue;
 														if (is_array($pconfig['groups']) && in_array($group['name'],$pconfig['groups']))
 															continue;
+														$rowIndex++;
 												?>
 												<option value="<?=$group['name'];?>" <?=$selected;?>>
 													<?=htmlspecialchars($group['name']);?>
 												</option>
-												<?php endforeach; ?>
+												<?php endforeach;
+												if ($rowIndex == 0)
+													echo "<option></option>";
+												?>
 											</select>
 											<br />
 										</td>
@@ -551,18 +556,23 @@ function sshkeyClicked(obj) {
 											<br />
 											<select size="10" style="width: 75%" name="groups[]" class="formselect" id="groups" onchange="clear_selected('nogroups')" multiple="multiple">
 												<?php
+												$rowIndex = 0;
 												if (is_array($pconfig['groups'])) {
 													foreach ($config['system']['group'] as $group):
 														if ($group['gid'] == 1998) /* all users group */
 															continue;
 														if (!in_array($group['name'],$pconfig['groups']))
 															continue;
+														$rowIndex++;
 												?>
 												<option value="<?=$group['name'];?>">
 													<?=htmlspecialchars($group['name']);?>
 												</option>
 												<?php endforeach;
-												} ?>
+												}
+												if ($rowIndex == 0)
+													echo "<option></option>";
+												?>
 											</select>
 											<br />
 										</td>
-- 
cgit v1.1


From 2464e353414a60a867cba82837e34d4e37e0b075 Mon Sep 17 00:00:00 2001
From: N0YB <Al_Stu@Frontier.com>
Date: Mon, 16 Jun 2014 15:14:16 -0700
Subject: XHTML Compliance - System Menu

Enforce select option
---
 usr/local/www/system_advanced_admin.php    |  7 ++++++-
 usr/local/www/system_advanced_firewall.php |  7 ++++++-
 usr/local/www/system_crlmanager.php        | 30 ++++++++++++++++++++++++------
 usr/local/www/system_usermanager.php       | 14 ++++++++++++--
 4 files changed, 48 insertions(+), 10 deletions(-)

(limited to 'usr')

diff --git a/usr/local/www/system_advanced_admin.php b/usr/local/www/system_advanced_admin.php
index 5390ee9..39c0423 100644
--- a/usr/local/www/system_advanced_admin.php
+++ b/usr/local/www/system_advanced_admin.php
@@ -355,13 +355,18 @@ function prot_change() {
 								<td width="78%" class="vtable">
 									<select name="ssl-certref" id="ssl-certref" class="formselect">
 										<?php
+											$rowIndex = 0;
 											foreach($a_cert as $cert):
 												$selected = "";
 												if ($pconfig['ssl-certref'] == $cert['refid'])
 													$selected = "selected=\"selected\"";
+												$rowIndex++;
 										?>
 										<option value="<?=$cert['refid'];?>" <?=$selected;?>><?=$cert['descr'];?></option>
-										<?php endforeach; ?>
+										<?php endforeach;
+										if ($rowIndex == 0)
+											echo "<option></option>";
+										?>
 									</select>
 								</td>
 							</tr>
diff --git a/usr/local/www/system_advanced_firewall.php b/usr/local/www/system_advanced_firewall.php
index 60d1f04..48e0de4 100644
--- a/usr/local/www/system_advanced_firewall.php
+++ b/usr/local/www/system_advanced_firewall.php
@@ -537,10 +537,15 @@ function update_description(itemnum) {
 									<select name="tftpinterface[]" multiple="multiple" class="formselect" size="3">
 <?php
 										$ifdescs = get_configured_interface_with_descr();
+										$rowIndex = 0;
 										foreach ($ifdescs as $ifent => $ifdesc):
+											$rowIndex++;
 ?>
 											<option value="<?=$ifent;?>" <?php if (in_array($ifent, $pconfig['tftpinterface'])) echo "selected=\"selected\""; ?>><?=gettext($ifdesc);?></option>
-<?php									endforeach; ?>
+<?php									endforeach;
+										if ($rowIndex == 0)
+											echo "<option></option>";
+ ?>
 									</select>
 									<strong><?=gettext("Choose the interfaces where you want TFTP proxy helper to be enabled.");?></strong>
 								</td>
diff --git a/usr/local/www/system_crlmanager.php b/usr/local/www/system_crlmanager.php
index 099a6e1..08a9c31 100644
--- a/usr/local/www/system_crlmanager.php
+++ b/usr/local/www/system_crlmanager.php
@@ -304,15 +304,20 @@ function method_change() {
 							<td width="78%" class="vtable">
 								<select name='method' id='method' class="formselect" onchange='method_change()'>
 								<?php
+									$rowIndex = 0;
 									foreach($crl_methods as $method => $desc):
 									if (($_GET['importonly'] == "yes") && ($method != "existing"))
 										continue;
 									$selected = "";
 									if ($pconfig['method'] == $method)
 										$selected = "selected=\"selected\"";
+									$rowIndex++;
 								?>
 									<option value="<?=$method;?>" <?=$selected;?>><?=$desc;?></option>
-								<?php endforeach; ?>
+								<?php endforeach;
+								if ($rowIndex == 0)
+									echo "<option></option>";
+								?>
 								</select>
 							</td>
 						</tr>
@@ -328,13 +333,18 @@ function method_change() {
 							<td width="78%" class="vtable">
 								<select name='caref' id='caref' class="formselect">
 								<?php
+									$rowIndex = 0;
 									foreach($a_ca as $ca):
 									$selected = "";
 									if ($pconfig['caref'] == $ca['refid'])
 										$selected = "selected=\"selected\"";
+									$rowIndex++;
 								?>
 									<option value="<?=$ca['refid'];?>" <?=$selected;?>><?=$ca['descr'];?></option>
-								<?php endforeach; ?>
+								<?php endforeach;
+								if ($rowIndex == 0)
+									echo "<option></option>";
+								?>
 								</select>
 							</td>
 						</tr>
@@ -493,15 +503,23 @@ function method_change() {
 					<tr>
 						<td class="listlr" colspan="3" align="center">
 							<b><?php echo gettext("Choose a Certificate to Revoke"); ?></b>: <select name='certref' id='certref' class="formselect">
-				<?php	foreach($ca_certs as $cert): ?>
+				<?php	$rowIndex = 0;
+						foreach($ca_certs as $cert): 
+							$rowIndex++; ?>
 							<option value="<?=$cert['refid'];?>"><?=htmlspecialchars($cert['descr'])?></option>
-				<?php	endforeach; ?>
+				<?php	endforeach;
+						if ($rowIndex == 0)
+							echo "<option></option>"; ?>
 							</select>
 							<b><?php echo gettext("Reason");?></b>:
 							<select name='crlreason' id='crlreason' class="formselect">
-				<?php	foreach($openssl_crl_status as $code => $reason): ?>
+				<?php	$rowIndex = 0;
+						foreach($openssl_crl_status as $code => $reason): 
+							$rowIndex++; ?>
 							<option value="<?= $code ?>"><?= htmlspecialchars($reason) ?></option>
-				<?php	endforeach; ?>
+				<?php	endforeach;
+						if ($rowIndex == 0)
+							echo "<option></option>"; ?>
 							</select>
 							<input name="act" type="hidden" value="addcert" />
 							<input name="crlref" type="hidden" value="<?=$crl['refid'];?>" />
diff --git a/usr/local/www/system_usermanager.php b/usr/local/www/system_usermanager.php
index a844922..563a73b 100644
--- a/usr/local/www/system_usermanager.php
+++ b/usr/local/www/system_usermanager.php
@@ -728,12 +728,17 @@ function sshkeyClicked(obj) {
                                                         	<td width="78%" class="vtable">
                                                                 	<select name='caref' id='caref' class="formselect" onchange='internalca_change()'>
                                                                 <?php
+																		$rowIndex = 0;
                                                                         foreach( $config['ca'] as $ca):
                                                                         if (!$ca['prv'])
                                                                                 continue;
+																			$rowIndex++;
                                                                 ?>
                                                                         <option value="<?=$ca['refid'];?>"><?=$ca['descr'];?></option>
-                                                                <?php endforeach; ?>
+                                                                <?php endforeach;
+																if ($rowIndex == 0)
+																	echo "<option></option>";
+																?>
                                                                 	</select>
                                                         	</td>
                                                 	</tr>
@@ -743,10 +748,15 @@ function sshkeyClicked(obj) {
                                                                 	<select name='keylen' class="formselect">
                                                                 <?php
 									$cert_keylens = array( "2048", "512", "1024", "4096");
+																		$rowIndex = 0;
                                                                         foreach( $cert_keylens as $len):
+																			$rowIndex++;
                                                                 ?>
                                                                         <option value="<?=$len;?>"><?=$len;?></option>
-                                                                <?php endforeach; ?>
+                                                                <?php endforeach;
+																if ($rowIndex == 0)
+																	echo "<option></option>";
+																?>
                                                                 	</select>
                                                                 	bits
                                                         	</td>
-- 
cgit v1.1


From 60a5f9de37aac2f2f54bb04590b7941c68c30e3b Mon Sep 17 00:00:00 2001
From: N0YB <Al_Stu@Frontier.com>
Date: Sat, 21 Jun 2014 14:16:05 -0700
Subject: Use count($array) where applicable, instead of a $rowIndex increment.

---
 usr/local/www/system_advanced_admin.php |  8 +++-----
 usr/local/www/system_usermanager.php    | 11 +++++------
 2 files changed, 8 insertions(+), 11 deletions(-)

(limited to 'usr')

diff --git a/usr/local/www/system_advanced_admin.php b/usr/local/www/system_advanced_admin.php
index 39c0423..919ad4b 100644
--- a/usr/local/www/system_advanced_admin.php
+++ b/usr/local/www/system_advanced_admin.php
@@ -355,16 +355,14 @@ function prot_change() {
 								<td width="78%" class="vtable">
 									<select name="ssl-certref" id="ssl-certref" class="formselect">
 										<?php
-											$rowIndex = 0;
 											foreach($a_cert as $cert):
-												$selected = "";
 												if ($pconfig['ssl-certref'] == $cert['refid'])
 													$selected = "selected=\"selected\"";
-												$rowIndex++;
 										?>
 										<option value="<?=$cert['refid'];?>" <?=$selected;?>><?=$cert['descr'];?></option>
-										<?php endforeach;
-										if ($rowIndex == 0)
+										<?php
+										endforeach;
+										if (!count($a_cert))
 											echo "<option></option>";
 										?>
 									</select>
diff --git a/usr/local/www/system_usermanager.php b/usr/local/www/system_usermanager.php
index 563a73b..6beed3f 100644
--- a/usr/local/www/system_usermanager.php
+++ b/usr/local/www/system_usermanager.php
@@ -748,15 +748,14 @@ function sshkeyClicked(obj) {
                                                                 	<select name='keylen' class="formselect">
                                                                 <?php
 									$cert_keylens = array( "2048", "512", "1024", "4096");
-																		$rowIndex = 0;
                                                                         foreach( $cert_keylens as $len):
-																			$rowIndex++;
                                                                 ?>
                                                                         <option value="<?=$len;?>"><?=$len;?></option>
-                                                                <?php endforeach;
-																if ($rowIndex == 0)
-																	echo "<option></option>";
-																?>
+                                                                <?php
+                                                                endforeach;
+                                                                if (!count($cert_keylens))
+                                                                	echo "<option></option>";
+                                                                ?>
                                                                 	</select>
                                                                 	bits
                                                         	</td>
-- 
cgit v1.1


From 1657cfd2d421087ccd5a229fdfe38175d315a6c0 Mon Sep 17 00:00:00 2001
From: N0YB <Al_Stu@Frontier.com>
Date: Sat, 21 Jun 2014 14:23:35 -0700
Subject: oops, that wasn't supposed to be removed.

---
 usr/local/www/system_advanced_admin.php | 1 +
 1 file changed, 1 insertion(+)

(limited to 'usr')

diff --git a/usr/local/www/system_advanced_admin.php b/usr/local/www/system_advanced_admin.php
index 919ad4b..89a815c 100644
--- a/usr/local/www/system_advanced_admin.php
+++ b/usr/local/www/system_advanced_admin.php
@@ -356,6 +356,7 @@ function prot_change() {
 									<select name="ssl-certref" id="ssl-certref" class="formselect">
 										<?php
 											foreach($a_cert as $cert):
+												$selected = "";
 												if ($pconfig['ssl-certref'] == $cert['refid'])
 													$selected = "selected=\"selected\"";
 										?>
-- 
cgit v1.1