From 3bdc7f5908ad19af2fc31b873cd07eadeb801bd5 Mon Sep 17 00:00:00 2001
From: Renato Botelho <garga@FreeBSD.org>
Date: Thu, 20 Nov 2014 10:25:28 -0200
Subject: Remove debugging code that can lead us to XSS injection, also pass
 variables through htmlspecialchars() to sanitize

---
 usr/local/www/installer/installer.php | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

(limited to 'usr/local/www')

diff --git a/usr/local/www/installer/installer.php b/usr/local/www/installer/installer.php
index e2ae09c..05f10b9 100644
--- a/usr/local/www/installer/installer.php
+++ b/usr/local/www/installer/installer.php
@@ -497,7 +497,7 @@ function verify_before_install() {
 	}
 	if(!$bootmanager) 
 		$bootmanager = $_REQUEST['bootmanager'];
-	echo "\n<!--" . print_r($_REQUEST, true) . " -->\n";
+	// echo "\n<!--" . print_r($_REQUEST, true) . " -->\n";
 	$disk = pcsysinstall_get_disk_info(htmlspecialchars($_REQUEST['disk']));
 	$disksize = format_bytes($disk['size'] * 1048576);
 	// Loop through posted items and create an array
@@ -535,7 +535,7 @@ function verify_before_install() {
 		$tmparray['encpass'] = $_REQUEST['encpass' . $x];
 		$disks[] = $tmparray;
 	}
-	echo "\n<!-- " . print_r($disks, true) . " --> \n";
+	// echo "\n<!-- " . print_r($disks, true) . " --> \n";
 	$bootmanagerupper = strtoupper($bootmanager);
 	echo <<<EOFAMBAC
 	<form method="post" action="installer.php">
@@ -595,11 +595,11 @@ EOFAMBACBAF;
 													foreach($disks as $disk) {
 														$desc = pcsysinstall_get_disk_info($disk['disk']);
 														echo "<tr>";
-														echo "<td>&nbsp;&nbsp;&nbsp;{$disk['mountpoint']}</td>";
-														echo "<td>{$disk['fstype']}</td>";
-														echo "<td>{$disk['disk']} {$desc['desc']}</td>";
-														echo "<td>{$disk['size']}</td>";
-														echo "<td>{$disk['encpass']}</td>";
+														echo "<td>&nbsp;&nbsp;&nbsp;" . htmlspecialchars($disk['mountpoint']) . "</td>";
+														echo "<td>" . htmlspecialchars($disk['fstype']) . "</td>";
+														echo "<td>" . htmlspecialchars($disk['disk']) . " " . htmlspecialchars($desc['desc']) . "</td>";
+														echo "<td>" . htmlspecialchars($disk['size']) . "</td>";
+														echo "<td>" . htmlspecialchars($disk['encpass']) . "</td>";
 														echo "</tr>";
 													}
 
@@ -970,7 +970,7 @@ EOF;
 		$first_disk_size = $size - $swap_size;
 
 		// Debugging
-		echo "\n\n<!-- $first_disk - " . print_r($disk_info, true) . " - $size  - $first_disk_size -->\n\n";
+		// echo "\n\n<!-- $first_disk - " . print_r($disk_info, true) . " - $size  - $first_disk_size -->\n\n";
 
 		// Check to see if a on disk layout exists
 		if(file_exists("/tmp/webInstaller_disk_layout.txt")) {
-- 
cgit v1.1