From 51e43abc8da6fc9e2b8802365767052415771ffb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ermal=20Lu=E7i?= <eri@pfsense.org>
Date: Mon, 18 Jan 2010 11:57:18 +0000
Subject: Ticket #274. Propperly handle custom options.

---
 usr/local/www/services_dhcp.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'usr/local/www/services_dhcp.php')

diff --git a/usr/local/www/services_dhcp.php b/usr/local/www/services_dhcp.php
index 523d04e..b480217 100755
--- a/usr/local/www/services_dhcp.php
+++ b/usr/local/www/services_dhcp.php
@@ -306,11 +306,11 @@ if ($_POST) {
 		$config['dhcpd'][$if]['rootpath'] = $_POST['rootpath'];
 
 		// Handle the custom options rowhelper
-		$numbervalue = array();
 		if(isset($config['dhcpd'][$if]['numberoptions']['item']))
 			unset($config['dhcpd'][$if]['numberoptions']['item']);
-		for($x=0; $x<isset($_POST["number{$x}"]); $x++) {
-			if(is_int(intval($_POST["number{$x}"]))) {
+		for($x=0; $x<99; $x++) {
+			if(isset($_POST["number{$x}"]) && ctype_digit($_POST["number{$x}"])) {
+				$numbervalue = array();
 				$numbervalue['number'] = htmlspecialchars($_POST["number{$x}"]);
 				$numbervalue['value'] = htmlspecialchars($_POST["value{$x}"]);
 				$config['dhcpd'][$if]['numberoptions']['item'][] = $numbervalue;
-- 
cgit v1.1