From 018514fd191d6a594d0dbf4d1093db68b530f9c8 Mon Sep 17 00:00:00 2001
From: NOYB <Al_Stu@Frontier.com>
Date: Mon, 14 Mar 2016 02:04:47 -0700
Subject: HTML Compliance - Firewall / Schedules / Edit - Readonly Attribute

Error: Bad value readonly for attribute type on element input.

Readonly is not a valid type attribute value.
If the intention here is to prevent the fields from being edited. Use the readonly attribute.
Since editing was not actually being prevented by this I did not add the readonly attribute so as to not change existing behavior.
---
 src/usr/local/www/firewall_schedule_edit.php | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

(limited to 'src/usr')

diff --git a/src/usr/local/www/firewall_schedule_edit.php b/src/usr/local/www/firewall_schedule_edit.php
index 3d9df5a..14f9d0c 100644
--- a/src/usr/local/www/firewall_schedule_edit.php
+++ b/src/usr/local/www/firewall_schedule_edit.php
@@ -627,28 +627,28 @@ if ($getSchedule) {
 			$group->add(new Form_Input(
 				'tempFriendlyTime',
 				null,
-				'readonly',
+				'text',
 				$tempFriendlyTime
 			))->setWidth(2)->setHelp($counter == $maxrows ? 'Day(s)':'');
 
 			$group->add(new Form_Input(
 				'starttime' . $counter,
 				null,
-				'readonly',
+				'text',
 				$starttime
 			))->setWidth(2)->setHelp($counter == $maxrows ? 'Start time':'');
 
 			$group->add(new Form_Input(
 				'stoptime' . $counter,
 				null,
-				'readonly',
+				'text',
 				$stoptime
 			))->setWidth(2)->setHelp($counter == $maxrows ? 'Stop time':'');
 
 			$group->add(new Form_Input(
 				'timedescr' . $counter,
 				null,
-				'readonly',
+				'text',
 				$timedescr
 			))->setWidth(2)->setHelp($counter == $maxrows ? 'Description':'');
 
@@ -1140,19 +1140,19 @@ function insertElements(tempFriendlyTime, starttimehour, starttimemin, stoptimeh
 	'<div class="form-group schedulegrp' + counter + '">' +
 		'<label for="tempFriendlyTime" class="col-sm-2 control-label"></label>' +
 		'<div class="col-sm-2">' +
-			'<input class="form-control" name="tempFriendlyTime" id="tempFriendlyTime" type="readonly" value="' + tempFriendlyTime + '"/>' +
+			'<input class="form-control" name="tempFriendlyTime" id="tempFriendlyTime" type="text" value="' + tempFriendlyTime + '"/>' +
 			'<span class="help-block">Day(s)</span>' +
 		'</div>' +
 		'<div class="col-sm-2">' +
-			'<input class="form-control" name="starttime@" id="starttime@" type="readonly" value="' + starttimehour + ':' + starttimemin + '"/>' +
+			'<input class="form-control" name="starttime@" id="starttime@" type="text" value="' + starttimehour + ':' + starttimemin + '"/>' +
 			'<span class="help-block">Start time</span>' +
 		'</div>' +
 		'<div class="col-sm-2">' +
-			'<input class="form-control" name="stoptime@" id="stoptime@" type="readonly" value="' + stoptimehour + ':' + stoptimemin + '"/>' +
+			'<input class="form-control" name="stoptime@" id="stoptime@" type="text" value="' + stoptimehour + ':' + stoptimemin + '"/>' +
 			'<span class="help-block">Stop time</span>' +
 		'</div>' +
 		'<div class="col-sm-2">' +
-			'<input class="form-control" name="timedescr@" id="timedescr@" type="readonly" value="' + tempdescr + '"/>' +
+			'<input class="form-control" name="timedescr@" id="timedescr@" type="text" value="' + tempdescr + '"/>' +
 			'<span class="help-block">Description</span>' +
 		'</div>' +
 		'<div class="col-sm-2">' +
-- 
cgit v1.1