From aceaf18c1ad93c808b77e0bbf324949d5d2eede0 Mon Sep 17 00:00:00 2001 From: Phil Davis Date: Mon, 27 Jun 2016 14:30:14 +0930 Subject: Always use require_once The usage of require() and require_once() throughout the system is inconsistent, and "bugs" come up now and then when the order of "requires" is a bit different and some require() happens after the include file is already included/required. It seems to me that there is no harm at all in always using require_once(). --- src/usr/local/www/firewall_nat_out_edit.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/usr/local/www/firewall_nat_out_edit.php') diff --git a/src/usr/local/www/firewall_nat_out_edit.php b/src/usr/local/www/firewall_nat_out_edit.php index c0c448a..2cdef28 100644 --- a/src/usr/local/www/firewall_nat_out_edit.php +++ b/src/usr/local/www/firewall_nat_out_edit.php @@ -63,10 +63,10 @@ ##|*MATCH=firewall_nat_out_edit.php* ##|-PRIV -require("guiconfig.inc"); +require_once("guiconfig.inc"); require_once("ipsec.inc"); require_once("filter.inc"); -require("shaper.inc"); +require_once("shaper.inc"); if (!is_array($config['nat']['outbound'])) { $config['nat']['outbound'] = array(); -- cgit v1.1