From 6855f25d8f83338559a174bb56cb85075c1d7bc6 Mon Sep 17 00:00:00 2001 From: doktornotor Date: Sat, 21 Nov 2015 21:46:27 +0100 Subject: restart_service() - do not attempt to stop service that is not running Attempting to stop service that's not running just produces useless log noise. BTW - dunno what was the idea behind restart_service_if_running() but it appears to be completely unused both in pfSense and in packages, suspect mainly because it doesn't make any sense as implemented. --- src/etc/inc/service-utils.inc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/etc/inc/service-utils.inc') diff --git a/src/etc/inc/service-utils.inc b/src/etc/inc/service-utils.inc index b40aa39..2e6e49c 100644 --- a/src/etc/inc/service-utils.inc +++ b/src/etc/inc/service-utils.inc @@ -155,7 +155,9 @@ function restart_service($name) { return; } - stop_service($name); + if (is_service_running($name)) { + stop_service($name); + } start_service($name); if (is_array($config['installedpackages']) && is_array($config['installedpackages']['service'])) { -- cgit v1.1