From 4ec6b54d189dbd84265cf1f7dc18050ae941df7c Mon Sep 17 00:00:00 2001 From: Ermal Date: Sat, 3 May 2014 16:27:28 +0000 Subject: Merge the forgotten Ticket #3062 patch for CP pipeno leaking issue which leads to the 'Maximum login reached' on CP --- etc/inc/captiveportal.inc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'etc') diff --git a/etc/inc/captiveportal.inc b/etc/inc/captiveportal.inc index ea2f116..c3dfe10 100644 --- a/etc/inc/captiveportal.inc +++ b/etc/inc/captiveportal.inc @@ -1968,8 +1968,13 @@ function portal_allow($clientip,$clientmac,$username,$password = null, $attribut captiveportal_logportalauth($username,$clientmac,$clientip,$type,"RADIUS ACCOUNTING FAILED"); } } - } else + } else { + /* NOTE: #3062-11 If the pipeno has been allocated free it to not DoS the CP and maintain proper operation as in radius() case */ + if (!is_null($pipeno)) + captiveportal_free_dn_ruleno($pipeno); + unlock($cpdblck); + } if ($writecfg == true) write_config(); -- cgit v1.1