From c1ac389132480d6913723bc25f0edc54f43a56c9 Mon Sep 17 00:00:00 2001 From: Phil Davis Date: Thu, 17 Dec 2015 08:27:38 +0545 Subject: services_pppoe_edit handle both GET and POST This wacky logic would only have got to the $_POST checks if $_GET['id'] was already set. I haven't looked to analyse it - but how would anything using $_POST have worked? --- src/usr/local/www/services_pppoe_edit.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/usr/local/www/services_pppoe_edit.php b/src/usr/local/www/services_pppoe_edit.php index f358749..6da30c6 100644 --- a/src/usr/local/www/services_pppoe_edit.php +++ b/src/usr/local/www/services_pppoe_edit.php @@ -88,8 +88,8 @@ $a_pppoes = &$config['pppoes']['pppoe']; if (is_numericint($_GET['id'])) { $id = $_GET['id']; - -if (isset($_POST['id']) && is_numericint($_POST['id'])) +} +if (isset($_POST['id']) && is_numericint($_POST['id'])) { $id = $_POST['id']; } -- cgit v1.1