From a97a77a2a52184476e78e6f697b8d44706eb5692 Mon Sep 17 00:00:00 2001 From: Phil Davis Date: Fri, 6 Mar 2015 10:12:08 +0545 Subject: Be nicer when checking if alias is numeric Because an ordinary port can be numeric here. Forum https://forum.pfsense.org/index.php?topic=89906.0 --- etc/inc/util.inc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/etc/inc/util.inc b/etc/inc/util.inc index 2f0b318..6dc24de 100644 --- a/etc/inc/util.inc +++ b/etc/inc/util.inc @@ -1533,11 +1533,11 @@ function alias_get_type($name) { function alias_expand($name) { global $aliastable; - // alias names cannot be strictly numeric. redmine #4289 - if (is_numericint($name)) - return null; - if (isset($aliastable[$name])) { + // alias names cannot be strictly numeric. redmine #4289 + if (is_numericint($name)) { + return null; + } return "\${$name}"; } else if (is_ipaddr($name) || is_subnet($name) || is_port($name) || is_portrange($name)) { return "{$name}"; -- cgit v1.1