From 7dff06c41dba6620c9b50f2fb14f1837780ac3f0 Mon Sep 17 00:00:00 2001 From: Chris Buechler Date: Sat, 4 Apr 2015 00:06:02 -0500 Subject: There is no longer any need to restrict protocols for IPv4+IPv6 rules, the appropriate ruleset is generated and problem scenarios that would otherwise break here are prevented by other input validation. --- usr/local/www/firewall_rules_edit.php | 5 ----- 1 file changed, 5 deletions(-) diff --git a/usr/local/www/firewall_rules_edit.php b/usr/local/www/firewall_rules_edit.php index 1e438c1..5deeabf 100644 --- a/usr/local/www/firewall_rules_edit.php +++ b/usr/local/www/firewall_rules_edit.php @@ -298,11 +298,6 @@ if ($_POST) { $input_errors[] = gettext("You can not assign an IPv6 Gateway to an IPv4 Filter rule"); } } - - if (($_POST['proto'] != "tcp") && ($_POST['proto'] != "udp") && ($_POST['proto'] != "tcp/udp") && ($_POST['proto'] != "icmp")) { - if($_POST['ipprotocol'] == "inet46") - $input_errors[] = gettext("You can not assign a protocol other than ICMP, TCP, UDP or TCP/UDP to a rule that applies to IPv4 and IPv6"); - } if (($_POST['proto'] == "icmp") && ($_POST['icmptype'] <> "")){ if($_POST['ipprotocol'] == "inet46") $input_errors[] = gettext("You can not assign a ICMP type to a rule that applies to IPv4 and IPv6"); -- cgit v1.1