From 65319e4cacee64399619725c9fd0655ba9815a55 Mon Sep 17 00:00:00 2001 From: Chris Buechler Date: Fri, 9 Sep 2011 04:39:30 -0400 Subject: fix firewall_nat_out to not auto-generate outbound NAT rules with one too many IPs --- usr/local/www/firewall_nat_out.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/usr/local/www/firewall_nat_out.php b/usr/local/www/firewall_nat_out.php index 9c0c331..a98bbbf 100755 --- a/usr/local/www/firewall_nat_out.php +++ b/usr/local/www/firewall_nat_out.php @@ -138,7 +138,8 @@ if (isset($_POST['save']) && $_POST['save'] == "Save") { /* PPTP subnet */ if (($config['pptpd']['mode'] == "server") && is_private_ip($config['pptpd']['remoteip'])) { - $pptp_subnets = ip_range_to_subnet_array($config['pptpd']['remoteip'], long2ip32(ip2long($config['pptpd']['remoteip'])+$config['pptpd']['n_pptp_units'])); + $pptptopip = $config['pptpd']['n_pptp_units'] - 1; + $pptp_subnets = ip_range_to_subnet_array($config['pptpd']['remoteip'], long2ip32(ip2long($config['pptpd']['remoteip'])+$pptptopip)); foreach ($pptp_subnets as $pptpsn) { $natent = array(); $natent['source']['network'] = $pptpsn; -- cgit v1.1