From 474c7b044053a0d0d00143faa23685ed243b93d0 Mon Sep 17 00:00:00 2001 From: jim-p Date: Tue, 30 Jul 2013 12:46:54 -0400 Subject: Show the name of the unresolvable alias name as well as the rule description to avoid ambiguity. --- etc/inc/filter.inc | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/etc/inc/filter.inc b/etc/inc/filter.inc index 274d0bb..6394e6a 100644 --- a/etc/inc/filter.inc +++ b/etc/inc/filter.inc @@ -2167,12 +2167,14 @@ function filter_generate_user_rule($rule) { /* check for unresolvable aliases */ if($rule['source']['address'] && !alias_expand($rule['source']['address'])) { - file_notice("Filter_Reload", "# unresolvable source aliases {$rule['descr']}"); - return "# unresolvable source aliases {$rule['descr']}"; + $error_text = "Unresolvable source alias '{$rule['source']['address']}' for rule '{$rule['descr']}'"; + file_notice("Filter_Reload", $error_text); + return "# {$error_text}"; } if($rule['destination']['address'] && !alias_expand($rule['destination']['address'])) { - file_notice("Filter_Reload", "# unresolvable dest aliases {$rule['descr']}"); - return "# unresolvable dest aliases {$rule['descr']}"; + $error_text = "Unresolvable destination alias '{$rule['destination']['address']}' for rule '{$rule['descr']}'"; + file_notice("Filter_Reload", $error_text); + return "# {$error_text}"; } update_filter_reload_status("Setting up pass/block rules"); $type = $rule['type']; -- cgit v1.1