From ee81ff387b7b7b0784df79f6a2d579ed964d15d9 Mon Sep 17 00:00:00 2001 From: NOYB Date: Wed, 30 Mar 2016 00:07:03 -0700 Subject: Firewall / NAT - Remove Personalizations Remove "you" personalizations. --- src/usr/local/www/firewall_nat.php | 4 ++-- src/usr/local/www/firewall_nat_1to1.php | 12 ++++++------ src/usr/local/www/firewall_nat_1to1_edit.php | 4 ++-- src/usr/local/www/firewall_nat_edit.php | 14 +++++++------- src/usr/local/www/firewall_nat_npt.php | 4 ++-- src/usr/local/www/firewall_nat_npt_edit.php | 4 ++-- src/usr/local/www/firewall_nat_out.php | 8 ++++---- src/usr/local/www/firewall_nat_out_edit.php | 14 +++++++------- 8 files changed, 32 insertions(+), 32 deletions(-) diff --git a/src/usr/local/www/firewall_nat.php b/src/usr/local/www/firewall_nat.php index 8b15ffb..836bc65 100644 --- a/src/usr/local/www/firewall_nat.php +++ b/src/usr/local/www/firewall_nat.php @@ -212,7 +212,7 @@ if ($savemsg) { if (is_subsystem_dirty('natconf')) { print_apply_box(gettext('The NAT configuration has been changed.') . '
' . - gettext('You must apply the changes in order for them to take effect.')); + gettext('The changes must be applied for them to take effect.')); } $tab_array = array(); @@ -506,7 +506,7 @@ events.push(function() { // provide a warning message if the user tries to change page before saving $(window).bind('beforeunload', function(){ if (!saving && dirty) { - return (""); + return (""); } else { return undefined; } diff --git a/src/usr/local/www/firewall_nat_1to1.php b/src/usr/local/www/firewall_nat_1to1.php index 2750da6..e8b45e6 100644 --- a/src/usr/local/www/firewall_nat_1to1.php +++ b/src/usr/local/www/firewall_nat_1to1.php @@ -161,7 +161,7 @@ if ($savemsg) { if (is_subsystem_dirty('natconf')) { print_apply_box(gettext('The NAT configuration has been changed.') . '
' . - gettext('You must apply the changes in order for them to take effect.')); + gettext('The changes must be applied for them to take effect.')); } $tab_array = array(); @@ -285,11 +285,11 @@ display_top_tabs($tab_array);
-' . - gettext("Virtual IP.") . '' . '
' . - gettext('If you add a 1:1 NAT entry for any of the interface IPs on this system, ' . +' . + gettext("Virtual IP") . '' . 'may also be needed.' . '
' . + gettext('If a 1:1 NAT entry is added for any of the interface IPs on this system, ' . 'it will make this system inaccessible on that IP address. i.e. if ' . - 'you use your WAN IP address, any services on this system (IPsec, OpenVPN server, etc.) ' . + 'the WAN IP address is used, any services on this system (IPsec, OpenVPN server, etc.) ' . 'using the WAN IP address will no longer function.'), 'info', false); ?>
@@ -322,7 +322,7 @@ events.push(function() { // provide a warning message if the user tries to change page before saving $(window).bind('beforeunload', function(){ if (!saving && dirty) { - return (""); + return (""); } else { return undefined; } diff --git a/src/usr/local/www/firewall_nat_1to1_edit.php b/src/usr/local/www/firewall_nat_1to1_edit.php index 585d318..c76ef23 100644 --- a/src/usr/local/www/firewall_nat_1to1_edit.php +++ b/src/usr/local/www/firewall_nat_1to1_edit.php @@ -202,7 +202,7 @@ if ($_POST) { /* For dst, if user enters an alias and selects "network" then disallow. */ if ($_POST['dsttype'] == "network" && is_alias($_POST['dst'])) { - $input_errors[] = gettext("You must specify single host or alias for alias entries."); + $input_errors[] = gettext("Alias entries must specify a single host or alias."); } /* For src, user can enter only ip's or networks */ @@ -510,7 +510,7 @@ $section->addInput(new Form_Input( 'Description', 'text', $pconfig['descr'] -))->setHelp('You may enter a description here for your reference (not parsed).'); +))->setHelp('A description may be entered here for administrative reference (not parsed).'); $section->addInput(new Form_Select( 'natreflection', diff --git a/src/usr/local/www/firewall_nat_edit.php b/src/usr/local/www/firewall_nat_edit.php index 383d026..1d247da 100644 --- a/src/usr/local/www/firewall_nat_edit.php +++ b/src/usr/local/www/firewall_nat_edit.php @@ -309,7 +309,7 @@ if ($_POST) { /* if user enters an alias and selects "network" then disallow. */ if (($_POST['srctype'] == "network" && is_alias($_POST['src'])) || ($_POST['dsttype'] == "network" && is_alias($_POST['dst']))) { - $input_errors[] = gettext("You must specify single host or alias for alias entries."); + $input_errors[] = gettext("Alias entries must specifie a single host or alias."); } if (!is_specialnet($_POST['srctype'])) { @@ -673,7 +673,7 @@ $section->addInput(new Form_Checkbox( 'No RDR (NOT)', 'Disable redirection for traffic matching this rule', $pconfig['nordr'] -))->setHelp('This option is rarely needed, don\'t use this unless you know what you\'re doing.'); +))->setHelp('This option is rarely needed. Don\'t use this without thorough knowledge of the implications.'); $iflist = get_configured_interface_with_descr(false, true); @@ -796,8 +796,8 @@ $group->add(new Form_Input( ))->setPattern('[a-zA-Z0-9_]+')->setHelp('Custom'); $group->setHelp('Specify the source port or port range for this rule. This is usually random and almost never ' . - 'equal to the destination port range (and should usually be \'any\'). You can leave the \'to\' field ' . - 'empty if you only want to filter a single port.'); + 'equal to the destination port range (and should usually be \'any\'). The \'to\' field ' . + 'may be left empty if only filtering a single port.'); $section->add($group); @@ -857,7 +857,7 @@ $group->add(new Form_Input( ))->setPattern('[a-zA-Z0-9_]+')->setHelp('Custom'); $group->setHelp('Specify the port or port range for the destination of the packet for this mapping. ' . - 'You can leave the \'to\' field empty if you only want to map a single port '); + 'The \'to\' field may be left empty if only mapping a single port. '); $section->add($group); @@ -865,7 +865,7 @@ $section->addInput(new Form_IpAddress( 'localip', 'Redirect target IP', $pconfig['localip'] -))->setPattern('[.a-zA-Z0-9_:]+')->setHelp('Enter the internal IP address of the server on which you want to map the ports.' . '
' . +))->setPattern('[.a-zA-Z0-9_:]+')->setHelp('Enter the internal IP address of the server on which to map the ports.' . '
' . 'e.g.: 192.168.1.12'); $group = new Form_Group('Redirect target port'); @@ -896,7 +896,7 @@ $section->addInput(new Form_Input( 'Description', 'text', $pconfig['descr'] -))->setHelp('You may enter a description here for your reference (not parsed).'); +))->setHelp('A description may be entered here for administrative reference (not parsed).'); $section->addInput(new Form_Checkbox( diff --git a/src/usr/local/www/firewall_nat_npt.php b/src/usr/local/www/firewall_nat_npt.php index 2317dbd..0a1e0f8 100644 --- a/src/usr/local/www/firewall_nat_npt.php +++ b/src/usr/local/www/firewall_nat_npt.php @@ -161,7 +161,7 @@ if ($savemsg) { if (is_subsystem_dirty('natconf')) { print_apply_box(gettext('The NAT configuration has been changed.') . '
' . - gettext('You must apply the changes in order for them to take effect.')); + gettext('The changes must be applied for them to take effect.')); } $tab_array = array(); @@ -300,7 +300,7 @@ events.push(function() { // provide a warning message if the user tries to change page before saving $(window).bind('beforeunload', function(){ if (!saving && dirty) { - return (""); + return (""); } else { return undefined; } diff --git a/src/usr/local/www/firewall_nat_npt_edit.php b/src/usr/local/www/firewall_nat_npt_edit.php index cd061be..907b55a 100644 --- a/src/usr/local/www/firewall_nat_npt_edit.php +++ b/src/usr/local/www/firewall_nat_npt_edit.php @@ -233,7 +233,7 @@ $section->addInput(new Form_Select( $pconfig['interface'], build_if_list() ))->setHelp('Choose which interface this rule applies to.' . '
' . - 'Hint: in most cases, you\'ll want to use "WAN" here.'); + 'Hint: Typically the "WAN" is used here.'); $section->addInput(new Form_Checkbox( 'srcnot', @@ -267,7 +267,7 @@ $section->addInput(new Form_Input( 'Description', 'text', $pconfig['descr'] -))->setHelp('You may enter a description here for your reference (not parsed).'); +))->setHelp('A description may be entered here for administrative reference (not parsed).'); if (isset($id) && $a_npt[$id]) { $section->addInput(new Form_Input( diff --git a/src/usr/local/www/firewall_nat_out.php b/src/usr/local/www/firewall_nat_out.php index 07f9807..ceb868e 100644 --- a/src/usr/local/www/firewall_nat_out.php +++ b/src/usr/local/www/firewall_nat_out.php @@ -245,7 +245,7 @@ if ($savemsg) { if (is_subsystem_dirty('natconf')) { print_apply_box(gettext('The NAT configuration has been changed.') . '
' . - gettext('You must apply the changes in order for them to take effect.')); + gettext('The changes must be applied for them to take effect.')); } $tab_array = array(); @@ -668,9 +668,9 @@ endif; ' . - 'If manual outbound NAT is selected, outbound NAT rules will not be automatically generated and only the mappings you specify on this page ' . + 'If manual outbound NAT is selected, outbound NAT rules will not be automatically generated and only the mappings specify on this page ' . 'will be used.' . '
' . - 'If hybrid outbound NAT is selected, mappings you specify on this page will be used, followed by the automatically generated ones.' . '
' . + 'If hybrid outbound NAT is selected, mappings specify on this page will be used, followed by the automatically generated ones.' . '
' . 'If disable outbound NAT is selected, no rules will be used.' . '
' . 'If a target address other than an interface\'s IP address is used, then depending on the way the WAN connection is setup, a ') . '' . gettext("Virtual IP") . '' . gettext(" may also be required."), @@ -706,7 +706,7 @@ events.push(function() { // provide a warning message if the user tries to change page before saving $(window).bind('beforeunload', function(){ if (!saving && dirty) { - return (""); + return (""); } else { return undefined; } diff --git a/src/usr/local/www/firewall_nat_out_edit.php b/src/usr/local/www/firewall_nat_out_edit.php index db2b684..a17fabb 100644 --- a/src/usr/local/www/firewall_nat_out_edit.php +++ b/src/usr/local/www/firewall_nat_out_edit.php @@ -204,15 +204,15 @@ if ($_POST) { } if ($protocol_uses_ports && $_POST['sourceport'] <> "" && !(is_portoralias($_POST['sourceport']) || is_portrange($_POST['sourceport']))) { - $input_errors[] = gettext("You must supply either a valid port or port alias for the source port entry."); + $input_errors[] = gettext("A valid port or port alias must be supplied for the source port entry."); } if ($protocol_uses_ports && $_POST['dstport'] <> "" && !(is_portoralias($_POST['dstport']) || is_portrange($_POST['dstport']))) { - $input_errors[] = gettext("You must supply either a valid port or port alias for the destination port entry."); + $input_errors[] = gettext("A valid port or port alias must be supplied for the destination port entry."); } if ($protocol_uses_ports && $_POST['natport'] <> "" && !(is_portoralias($_POST['natport']) || is_portrange($_POST['natport'])) && !isset($_POST['nonat'])) { - $input_errors[] = gettext("You must supply a valid port for the NAT port entry."); + $input_errors[] = gettext("A valid port must be supplied for the NAT port entry."); } if (($_POST['source_type'] != "any") && ($_POST['source_type'] != "(self)")) { @@ -574,10 +574,10 @@ $section->addInput(new Form_IpAddress( $pconfig['targetip'] ))->addMask('targetip_subnet', $pconfig['targetip_subnet'])->addClass('othersubnet')->setHelp( 'Packets matching this rule will be mapped to the IP address given here.' . '
' . - 'If you want this rule to apply to another IP address rather than the IP address of the interface chosen above, ' . - 'select it here (you will need to define ' . + 'To apply this rule to a different IP address than the IP address of the interface chosen above, ' . + 'select it here (' . '' . gettext("Virtual IP") . ' ' . - 'addresses on the interface first)'); + 'addresses need to be defined on the interface first)'); $section->addInput(new Form_Select( 'poolopts', @@ -638,7 +638,7 @@ $section->addInput(new Form_Input( 'Description', 'text', $pconfig['descr'] -))->setHelp('You may enter a description here for your reference (not parsed).'); +))->setHelp('A description may be entered here for administrative reference (not parsed).'); if (isset($id) && $a_out[$id]) { $section->addInput(new Form_Input( -- cgit v1.1 From 7d5e0bccdcf713cebcf6077dd5c298246d4a0cd0 Mon Sep 17 00:00:00 2001 From: NOYB Date: Wed, 30 Mar 2016 02:16:57 -0700 Subject: A few corrections. --- src/usr/local/www/firewall_nat_1to1.php | 4 ++-- src/usr/local/www/firewall_nat_edit.php | 2 +- src/usr/local/www/firewall_nat_out.php | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/usr/local/www/firewall_nat_1to1.php b/src/usr/local/www/firewall_nat_1to1.php index e8b45e6..22aae72 100644 --- a/src/usr/local/www/firewall_nat_1to1.php +++ b/src/usr/local/www/firewall_nat_1to1.php @@ -285,8 +285,8 @@ display_top_tabs($tab_array);
-' . - gettext("Virtual IP") . '' . 'may also be needed.' . '
' . +' . + gettext("Virtual IP") . '' . '
' . gettext('If a 1:1 NAT entry is added for any of the interface IPs on this system, ' . 'it will make this system inaccessible on that IP address. i.e. if ' . 'the WAN IP address is used, any services on this system (IPsec, OpenVPN server, etc.) ' . diff --git a/src/usr/local/www/firewall_nat_edit.php b/src/usr/local/www/firewall_nat_edit.php index 1d247da..0c0ca77 100644 --- a/src/usr/local/www/firewall_nat_edit.php +++ b/src/usr/local/www/firewall_nat_edit.php @@ -309,7 +309,7 @@ if ($_POST) { /* if user enters an alias and selects "network" then disallow. */ if (($_POST['srctype'] == "network" && is_alias($_POST['src'])) || ($_POST['dsttype'] == "network" && is_alias($_POST['dst']))) { - $input_errors[] = gettext("Alias entries must specifie a single host or alias."); + $input_errors[] = gettext("Alias entries must specify a single host or alias."); } if (!is_specialnet($_POST['srctype'])) { diff --git a/src/usr/local/www/firewall_nat_out.php b/src/usr/local/www/firewall_nat_out.php index ceb868e..442bb12 100644 --- a/src/usr/local/www/firewall_nat_out.php +++ b/src/usr/local/www/firewall_nat_out.php @@ -668,9 +668,9 @@ endif; ' . - 'If manual outbound NAT is selected, outbound NAT rules will not be automatically generated and only the mappings specify on this page ' . + 'If manual outbound NAT is selected, outbound NAT rules will not be automatically generated and only the mappings specified on this page ' . 'will be used.' . '
' . - 'If hybrid outbound NAT is selected, mappings specify on this page will be used, followed by the automatically generated ones.' . '
' . + 'If hybrid outbound NAT is selected, mappings specified on this page will be used, followed by the automatically generated ones.' . '
' . 'If disable outbound NAT is selected, no rules will be used.' . '
' . 'If a target address other than an interface\'s IP address is used, then depending on the way the WAN connection is setup, a ') . '' . gettext("Virtual IP") . '' . gettext(" may also be required."), -- cgit v1.1