| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| | |
|
|\ \ |
|
| |/
| |
| |
| |
| | |
This file seems to have an unmatched "td" ending. Adding the line here matches the "td" at line 320 and this embraces the little table that has the 4 icons in it in a square that comes at the right hand end of each port-forward entry in the main table.
I can't see any difference in the rendering of the page, at least on Firefox, with and without this fix.
The tabbing of this file is woeful. I am fixing that up with a code-style review. But thought I should do a separate pull request for this kind-of-functional fix.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
get_package_internal_name(). Try to use more standard parameter names and simplify logic while here
|
| | |
|
|/ |
|
| |
|
|
|
|
| |
creation. This is needed only when the system is booted up without any carp vip configured
|
| |
|
| |
|
|\ |
|
| |
| |
| |
| |
| | |
If the DHCP IP address is in a pool (not in the main DHCP range for the interface) then the interface that corresponds to the IP address is not found. This results in the link to "add static mapping for this MAC address" not having any value for "if=" and thus clicking on the "+" button does not work.
Reported in bug 4649
Process any pools when checking for which interface contains the IP address.
|
|\ \ |
|
| |/
| |
| |
| |
| | |
If I go to Service->DHCP Server, make some edits that are invalid (e.g. change range start or end to some invalid string) and press Save then the page comes back displaying the input error(s). But it also says:
"The changes have been applied successfully."
Actually, the changes (which were invalid) have not been applied to the config - all is well there - but dhcpd has been stopped and started and dnsmasq or unbound has been kicked... which is all unnecessary processing since the user has not yet provided valid values to save.
|
|\ \ |
|
| | |
| | |
| | |
| | | |
Remove double line from table
|
| | |
| | |
| | |
| | | |
Add missing closing TD tag
|
|\ \ \ |
|
| | | | |
|
|\ \ \ \ |
|
| |/ / / |
|
|\ \ \ \ |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
files that do stuff in mostly in the background.
|
|\ \ \ \ \ |
|
| |/ / / / |
|
| |_|_|/
|/| | |
| | | |
| | | | |
kill, as it can cause problems with failover scenarios.
|
| |_|/
|/| |
| | |
| | |
| | | |
submission. Remove symlinks first. Also properly set user agent while
here, consistent with others. Fix some style and whitespace too. Ticket
|
| |/
|/|
| |
| | |
every time save is pressed.
Actually the GUI is displaying the opposite setting to what is in the config. When the user pressed save that opposite setting was saved, but then again it displays the opposite of the opposite...
|
| |
| |
| |
| | |
IKEv2. Fixes #4626
|
|/
|
|
| |
The back button here was just a piece of text with no nice formatting.
This change codes it as a button in the same way that "Cancel" buttons are done elsewhere. It makes the SMART Diag results page look a bit more consistent with the rest of the pfSense GUI.
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This checks if a static IP address entered for an interface has a subnet
that overlaps with any other configured subnet. e.g.:
LAN is IPv4 10.10.12.1/24
Then try to set OPT1 to 10.10.13.1/23 - it overlaps with LAN because
"/23" covers the "12" and "13" together.
In the input errors message, display to the user the other interfaces
and subnets that overlap/conflict. Then the user has some idea what it
is that conflicts and can easily go looking in the right place for the
problem.
Do the same thing for IPv6 address/CIDR.
Note: I have not enhanced any of the checks for conflicts with static
routes - there could be cases where a user has a static route like
10.0.0.0/8 pointing to some internal router that has the rest of
10.0.0.0/8 behind it, but the user has some direct-attached subnet
inside that - e.g. 10.1.2.0/24 - the routing table should cope with
this, delivering directly to 10.1.2.0/24 and routing for the rest of
10.0.0.0/8. So we cannot invalidate all overlaps with static routes.
I think this validation will not invalidate any exotic-but-valid use
cases. I can't think of when the interface subnets on 2 interfaces can
overlap and still be a valid/useful configuration.
This should stop people setting up dumb mixes of LAN/OPT1/OPT2... with
random addresses and CIDR prefix that overlap each other.
|
| |
| |
| |
| |
| |
| |
| | |
If both `post-check` and `pre-check` are specified and set to `0`, both
are entirely ignored:
http://blogs.msdn.com/b/ieinternals/archive/2009/07/20/using-post_2d00_check-and-pre_2d00_check-cache-directives.aspx
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Sorted by RFC 2616:
Section 14.9.1 `no-cache`
Section 14.9.2 `no-store`
Section 14.9.4 `must-revalidate`
Combined into one line with IE's `pre-check` and `post-check`. However,
when both set to `0`, both are entirely ignored:
http://blogs.msdn.com/b/ieinternals/archive/2009/07/20/using-post_2d00_check-and-pre_2d00_check-cache-directives.aspx
|
|\ \ |
|
| | | |
|
|/ /
| |
| |
| |
| | |
I noticed this when cleaning up VIPs and OpenVPN server when testing for this forum post https://forum.pfsense.org/index.php?topic=92174.0
The system let me delete my test VIP before I deleted the OpenVPN server using, probably not a good thing.
This is a better version of #1604 - the similar loops for server and client are combined, and the error message shows the description (or IP address:port) of the offending OpenVPN instance so the user has a clue about which OpenVPN instance uses the VIP.
|
|/
|
|
|
| |
Tell users that this is possible in DNS Resolver and how to achieve it. The code in unbound.inc already supports it and works.
I had asked for this in Redmine feature request #4350 and when I went to look at coding to implement it I found code that already did it.
So IMHO it is worth telling users.
|
|
|
|
| |
shuffling configuration around.
|
|\ |
|
| |
| |
| |
| |
| |
| | |
Note that advertise is spelt with an "s" in other places in the GUI, so
making it consistent in services_ntpd - but maybe Americans do spell it
"advertize" these days?
|
| |
| |
| |
| | |
this helps pick a free port for services using sockets bound to localhost, and helps determine if the service has at least started and bound the port without needing to go through all 'connected' sockets as well
|
|/
|
|
| |
a config setting to disable, rather than enable, this functionality since it's enabled by default so the tag isn't necessary in the default config. Remove now unnecessary config upgrade code.
|