summaryrefslogtreecommitdiffstats
path: root/usr
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #1729 from phil-davis/widget-iformRenato Botelho2015-06-257-13/+13
|\
| * Standardize widget iform and submit namesPhil Davis2015-06-237-13/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The log and picture widgets were both using "iforma" and "submita". Actually it did not break anything because it was only the form name repeated, not id. And nothing was using these names. Traffic Graphs widget was using just "iform". That is a bit dangerous for the future. I got tricked when cut-pasting some code to make some settings options for the Gateways widget. I kept "iform" and then wondered for a while why my Traffic Graphs widget show-hide settings would not save. There was traffic graph JS that referred to just "iform" and that started modifying the "iform" in my new Gateways widget code. Rather than having names "iforma", "iformb"... "submita", "submitb"... it seems much less risk of accidental duplication if these are named like: name_of_widget_iform name_of_widget_submit I don't think there is any user-visible bug in 2.2.* - so this standardization could just go into 2.3
* | Merge pull request #1719 from N0YB/XHTML_Compliance_Diagnostics_TablesRenato Botelho2015-06-251-2/+3
|\ \ | |/ |/|
| * Add semicolonN0YB2015-06-151-2/+3
| | | | | | | | Fix delete Java Script to match valid HTML ID
| * XHTML ComplianceN0YB2015-06-141-1/+1
| | | | | | | | | | | | | | | | | | html id's not permitted to begin with a number. html id's not permitted to contain '/' add prefix (entry_) and replace slash with hyphen. table entry id format becomes: entry_<ip address>-<cidr> replacing the format: <ip address>/<cidr> does not change the displayed format.
* | Ticket #4746 Correctly set global variables to be used by hostnames cod epathsErmal LUÇI2015-06-191-2/+4
| |
* | Add a GUI field to increase the pf frag entries limit. Fixes ticket #4775jim-p2015-06-181-0/+17
| |
* | Say what is happening when reinstalling package GUI XMLPhil Davis2015-06-161-1/+3
| | | | | | | | | | At the confirmation dialog after pressing the "Reinstall XML" button, the text does not distinguish between having pressed "Reinstall the whole package" and "Reinstall the GUI/XML". It would be nice if the text of this confirmation allowed the user to be confident about which button they had just pushed, before confirming the action. Note: This stuff has no gettext() wrappers - but that can be fixed later, not get mixed up in this.
* | Why is break missing for reinstallxmlPhil Davis2015-06-161-0/+1
| | | | | | | | | | I thought that "reinstallxml" should do less than "reinstallpkg" but actually it was getting stuff here, then falling through "reinstalpkg" which did delete_package_xml and then install_pkg, which got the files a 2nd time and... Maybe that was supposed to happen? Anyway, I thought I would point this out and someone can either commit this pull request if the "break" should be there, or explain to me why "reinstallxml" is supposed to fall through executing all this code.
* | Encoding in services_unbound_advanced.phpjim-p2015-06-161-2/+2
| |
* | Encoding in system_advanced_sysctl.phpjim-p2015-06-161-7/+7
| |
* | Encoding in interfaces.phpjim-p2015-06-161-4/+4
| |
* | Encoding in services_unbound.phpjim-p2015-06-161-1/+1
| |
* | Encoding in pkg_mgr_settings.phpjim-p2015-06-161-1/+1
| |
* | Encoding in system_advanced_admin.phpjim-p2015-06-161-1/+1
| |
* | Encoding in interfaces_ppps_edit.phpjim-p2015-06-161-2/+2
| |
* | Encoding in diag_packet_capture.phpjim-p2015-06-161-3/+3
| |
* | Encoding in interfaces_qinq_edit.phpjim-p2015-06-161-1/+1
| |
* | Encoding in services_dnsmasq.phpjim-p2015-06-161-1/+1
| |
* | Encoding in vpn_ipsec_settings.phpjim-p2015-06-161-1/+1
| |
* | More encodingjim-p2015-06-161-2/+2
| |
* | Fix some low-hanging potential security issues.jim-p2015-06-163-8/+8
| |
* | Be more careful with encoding on pages that use single quotes around HTML ↵jim-p2015-06-162-5/+5
| | | | | | | | attributes
* | Additional encoding for system_advanced_misc.phpjim-p2015-06-161-7/+7
| |
* | Protect single quotes as well to prevent JS injection, due to the way this ↵jim-p2015-06-161-10/+10
| | | | | | | | page uses single quotes for attributes.
* | Encode parameters in system_advanced_firewall.php before displaying back to ↵jim-p2015-06-161-5/+5
| | | | | | | | the user.
* | Merge pull request #1722 from chapmajs/fix_hughesnet_pdErmal LUÇI2015-06-151-1/+1
|\ \
| * | Fixing PD size selection for HughesNetJonathan2015-06-151-1/+1
| | |
* | | Remove the GUI for the pc-sysinstaller as well and add it to obsoletee filesErmal LUÇI2015-06-152-1278/+0
| | |
* | | Remove pc-sysinstall since it was never finished and probably will be not ↵Ermal LUÇI2015-06-1582-10305/+0
|/ / | | | | | | the choice. If needed can be resurrected
* | Merge pull request #1721 from phil-davis/styleRenato Botelho2015-06-15152-1279/+1307
|\ \
| * | Code spacingPhil Davis2015-06-15152-1279/+1307
| | | | | | | | | | | | | | | | | | | | | and other random stuff I noticed. I think this finishes messing with code style. The codebase should match the developer style guide closely enough that 99.9% of changes will not feel the need to also massage the formatting.
* | | status_queues missing semi-colonPhil Davis2015-06-151-1/+1
| |/ |/| | | This really looks like it should have a semi-colon. Somehow the PHP interpreter is not being fussy about it in this context, I guess being followed by the "endif;" keyword the interpreter guesses the previous statement must be done.
* | Ticket #4655 well manually merge pull/1715. Thanks: PhilErmal LUÇI2015-06-151-3/+9
| |
* | add input validation for proxy URL, port, user.Chris Buechler2015-06-141-0/+12
|/ | | | | Conflicts: usr/local/www/system_advanced_misc.php
* Ok another round of this which unbreaks input error validation messagesErmal LUÇI2015-06-131-3/+6
|
* Make this right finally :). Thanks-ti: Phil-davisErmal LUÇI2015-06-121-3/+2
|
* Activate the redirection that for some reason got disabledErmal LUÇI2015-06-121-2/+2
|
* Ticket #4655 Do not behave against the logic of checkbox and description.Ermal LUÇI2015-06-111-2/+2
|
* fix checking for overlaps of NAT destination portbruno2015-06-111-2/+2
|
* Make the host uuid opt-outErmal LUÇI2015-06-111-0/+18
|
* Re-generate broken .mo files, it fixes #4705Renato Botelho2015-06-072-0/+0
|
* Clean up, organize, and expand the info presented by status.php. Save the ↵jim-p2015-06-051-79/+97
| | | | | | | output to individual text files and compress them into a .tgz for later download. Conflicts: usr/local/www/status.php
* Also sanitize OpenVPN static/tls keys in status.phpjim-p2015-06-051-0/+2
|
* Merge pull request #1706 from phil-davis/setupwizardlanRenato Botelho2015-06-041-11/+44
|\
| * Setup Wizard can result in invalid LAN DHCP pool calculationPhil Davis2015-06-021-11/+44
| | | | | | | | | | | | | | | | | | | | | | | | 1) consider where the LAN IP is in the subnet range and then put the DHCP pool in the biggest remaining segment, either above or below. 2) Check the size of the available segment. If it is reasonably big then leave some space at either end of the segment, like the old code was doing. Otherwise give all the space to the pool. 3) Do not allow subnet mask 32 - I can't think of a use case for LAN to have a /32 subnet mask, it kind of breaks the whole concept of LAN. 4) Provide more detailed separate messages if the user tries to use the network address or broadcast address as the LAN IP.
* | Improve setup wizard host name checkPhil Davis2015-06-021-2/+2
| | | | | | | | | | | | Redmine #4712 It seems good enough to make the regex strings here be "reasonable". The full checks are done after pressing Next and the correct routines are called that do an exhaustive check. There seems not much point in trying to re-engineer all that here also. Odd things like "-hostname" and "hostname-" would be allowed through here but are caught by the full validation check. "." and "|" were being allowed in this regex - no idea why!
* | Merge pull request #1705 from phil-davis/wizard-textRenato Botelho2015-06-025-11/+11
|\ \
| * | Minor wizard text fixupsPhil Davis2015-06-025-11/+11
| |/
* | Merge pull request #1704 from phil-davis/bug4713Renato Botelho2015-06-021-1/+6
|\ \
OpenPOWER on IntegriCloud