summaryrefslogtreecommitdiffstats
path: root/usr
Commit message (Collapse)AuthorAgeFilesLines
* Expand range or subnet for host aliasPhil Davis2014-10-241-18/+95
| | | | | When entering a host alias, if the user put an IP range (like 192.168.0.10-192.168.0.20) or a subnet (like 192.168.1.200/29) then expand it into a list of individual IP addresses. Check that it will not make too many rows to exceed the existing 5000 row limit on the GUI. Note: expanding ranges and subnets like this is only for IPv4 for now. Entering an IPv6 range or subnet in a hosts alias will display a message telling the user that is not supported - it could be done in future but currently the routines that convert this stuff are only for IPv4. I have done as much validation as I can think of, and where there is a problem the original user-entered data is preserved for re-display, as well as the input errors being displayed. So IMO it should be self-documenting.
* Clarify bracketingPhil Davis2014-09-271-2/+2
| | | to minimize risk of a problem when adding code here in the future.
* Allow extended alias inputs #3890Phil Davis2014-09-271-35/+58
| | | | | | | | | | | Currently if you enter a space-separated list of subnets in the IP address box when entering an alias, the code reports that the data is invalid. But it does actually expand the list of subnets into multiple rows, and enters the various subnet CIDRs into the CIDR column for the user. The user can press Save a second time and the data is now valid so the code saves it happily. This is rather odd, as reported in redmine #3890. Also, if you input an IP range (e.g. 192.168.20.0-192.168.20.30) plus description and in the 2nd row put some other subnet and description, the range is correctly expanded, but the description only appears against the 1st subnet of the range. The description from the 2nd row ends up as the description against the 2nd subnet of the range, and the rest of the descriptions are blank. i.e. the descriptions do not get copied and pushed down as the IP ranges are expanded. This change fixes all that stuff by first parsing the posted data and expanding any IP ranges and/or space-separated lists, building arrays that have all their entries lined up: $input_addresses[] $input_address_subnet[] $final_address_details[] which are then validated. This is for master (2.2) branch. Actually it was not too difficult to integrate.
* firewall_aliases_edit UI text changesPhil Davis2014-09-261-3/+9
| | | | | | If type URL Table then the heading "Description" on the 3rd column gets suppressed (I am not really sure why that is, since the description data entry box still appears - I guess someone intended that the data entry box itself also be suppressed, since URL Table takes just a single line entry, the overall description of the alias should be enough - no need for a per-line description.) In any case, if the user then selects some other Alias Type, the "Description" heading on the 3rd column is not re-enabled. This change fixes that. I also implemented what is suggested in Redmine #3893 - making the 1st column heading say "IP or FQDN", "Network or FQDN". IMHO that looks fine on the UI and cannot do any harm. (and yes, the longer explanatory text already tells the user that an FQDN is allowed in these cases.)
* Remove useless check for alias description matching an interface descriptionPhil Davis2014-09-261-6/+0
| | | | | | | | | | | While looking at other checks in the code I noticed this check. It was not effective anyway, because the first line inside "if ($_POST)" below does unset($input_errors); which undoes this check anyway. In any case the check is not relevant. For example I might have interface WAN with description (which is really the alternate/display name for an interface) as MYISP. I cannot also have an Alias with name MYISP - that is checked for already later in the code. But I can have an Alias with description MYISP - in the case of an Alias the description really is just helpful text for the user, it is the name that really counts for use in the pf configuration. So the code is not needed.
* Be more strict on removing groups checking group id and group name, it ↵Renato Botelho2014-09-251-95/+119
| | | | avoids issues like happened to users on ticket #3856. While I'm here, replace GET by POST
* Be more strict on user removal checking array id and also username to avoid ↵Renato Botelho2014-09-251-1/+3
| | | | removing wrong users when browser back button is used. It should fix #3856
* Fix close button in the info boxbruno2014-09-241-2/+2
|
* Merge pull request #1287 from jean-m-cyr/masterRenato Botelho2014-09-241-1/+1
|\
| * NTP Service GPS page always reverts to 'Custom' GPS typeJean Cyr2014-09-231-1/+1
| | | | | | | | Remember and correctly display GPS type setting
* | Provide a toggle for apinger debug messages to be logged to syslog. To help ↵Ermal2014-09-241-0/+23
|/ | | | with roubleshooting issues
* Add a note clarifying the usage of OpenVPN's Auth Digest setting.jim-p2014-09-232-0/+2
|
* NTP server configuration does not highlight selected interfacesJean Cyr2014-09-231-0/+4
| | | | Missing explode of selected interface list prevent logic from working.
* Add a more obvious note about the use of WAN interface on group rules.jim-p2014-09-221-0/+4
|
* Apply previous progressbar customizations for jquery-ui 1.11.1Renato Botelho2014-09-221-2/+3
|
* Update jquery-ui components to 1.11.1, it fixes #3879"Renato Botelho2014-09-228-1364/+1245
|
* Simplify logicRenato Botelho2014-09-201-10/+7
|
* Add missing <form> and require filter.inc for filter_configure()Renato Botelho2014-09-201-0/+3
|
* Do the proper action if Apply button is pressed even on the preshared keys pageErmal2014-09-191-0/+11
|
* Recent versions of miniupnpd does not accept IPv4 address anymore, use ↵Renato Botelho2014-09-192-10/+2
| | | | interface name always. It fixes #3874
* Allow hostname to start with '@.' for namecheap. It fixes #3568Renato Botelho2014-09-191-2/+12
|
* Check if there are leases to show, it fixes warning when $mobile['pool'] is ↵Renato Botelho2014-09-191-30/+40
| | | | empty or not array
* fix syntaxjim-p2014-09-181-1/+1
|
* Do now call write_config() when click on Apply Changes because it was ↵Renato Botelho2014-09-181-30/+32
| | | | already done and it causes dhcpd to restart one more time on secondary nodes. It fixes #3797
* Update jquery to 1.11.1Renato Botelho2014-09-185-8983/+10
| | | | | | | * Update jquery to latest version * Use production version instead of development * Rename file to have version on it and avoid browser cache issues * Add jquery-migrate to keep backward compatible with old version
* Restore id for cancel button to fix js errorRenato Botelho2014-09-171-1/+1
|
* While I'm touching this file, replace GET by POSTRenato Botelho2014-09-171-22/+27
|
* Deduplicate <form>, fixes #3864Renato Botelho2014-09-171-3/+1
|
* Correct speeling as reported by: Phil Davis via githubErmal2014-09-161-1/+1
|
* Merge pull request #1282 from ExolonDX/branch_master_06Renato Botelho2014-09-161-5/+5
|\
| * Tidy up "status_rrd_graph.php" XHTMLColin Fleming2014-09-141-5/+5
| | | | | | | | | | "id" attributes cannot start with a numeric character, so change "8hour" to "eighthour" and "4year" to "fouryear".
* | Merge pull request #1281 from ExolonDX/branch_master_05Renato Botelho2014-09-161-4/+4
|\ \
| * | Tidy up "diag_dns.php" XHTMLColin Fleming2014-09-141-4/+4
| |/ | | | | | | | | | | | | Tidy up the "=" sign properly! Remove "=" sign from INPUT tag Change alignment to the "middle" of the TD tag Add missing closing FONT tag
* | Merge pull request #1280 from ExolonDX/branch_master_04Renato Botelho2014-09-161-1/+1
|\ \
| * | Tidy up "gateways.widget.php" XHTMLColin Fleming2014-09-141-1/+1
| |/ | | | | | | Remove invalid "summary" attribute from TD tag
* | Merge pull request #1279 from ExolonDX/branch_master_03Renato Botelho2014-09-161-3/+2
|\ \
| * | Tidy up "interfaces.widget.php" XHTMLColin Fleming2014-09-141-3/+2
| |/ | | | | | | | | | | Remove duplicate closing TR tag DIV tag cannot be enclosed in a B (bold) tag Change class and style
* | Merge pull request #1278 from ExolonDX/branch_master_02Renato Botelho2014-09-162-0/+2
|\ \
| * | Tidy up "pkg_mgr_install.php" XHTMLColin Fleming2014-09-142-0/+2
| |/ | | | | | | | | | | While using the widescreen theme, when you update the firmware or add a new package the TEXTAREAs are side-by-side which doesn't look neat. Add BR tag between TEXTAREA
* | Tidy up "fbegin.inc" XHTMLColin Fleming2014-09-141-1/+1
|/ | | | "id" must be a unique attribute.
* Remove almost all calls to history.back() and make Cancel button back to ↵Renato Botelho2014-09-1238-39/+141
| | | | HTTP_REFERER, there are a couple of places I didn't touch on this commit because it requires more work
* Inverse the sense of the toggles to avoid configuration upgradesErmal2014-09-121-6/+4
|
* Provide Advanced Options for controlling rekey and reauth, might be usable ↵Ermal2014-09-121-0/+26
| | | | with iOS devices
* Provide a first implementation of EAP-TLS authentication with IKEv2. It is a ↵Ermal2014-09-121-72/+93
| | | | start and might not work on all cases
* Replace GET by POST on system_usermanager.php and make necessary adjustments ↵Renato Botelho2014-09-114-131/+164
| | | | on necessary pages. It fixes #3856
* Back to referer instead of hard coded system_usermanager.php since this page ↵Renato Botelho2014-09-111-1/+6
| | | | is called from other places
* Add a cancel button for user and group edit pageRenato Botelho2014-09-112-0/+2
|
* Get rid of the /Ermal2014-09-111-2/+2
|
* Actually do not refer with Name but just poolErmal2014-09-111-1/+1
|
* Do not let the user mess with SAs from this page. The daemon and primary ↵Ermal2014-09-111-19/+0
| | | | status page handles tat
OpenPOWER on IntegriCloud