| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Only attempt to delete the oldusername if it actually was non-empty - at the moment errors are logged in the system log when adding a new user, because the code was trying to delete the user name "".
2) Call local_user_set() first to create (change, whatever) the user record. This makes the user record exist for a new user. Then call local_user_set_groups() to sort out what groups the user should be in or not in. The existing code would fail to add a new user to the specified group/s because local_user_set_groups() was called too early, before the user actually existed.
Typical system log errors from the old code:
Mar 18 17:10:31 php-fpm[9542]: /system_usermanager.php: Tried to remove user but got user pw instead. Bailing.
Mar 18 17:10:31 php-fpm[9542]: /system_usermanager.php: The command '/usr/sbin/pw groupmod admins -g 1999 -M '0,2003,2006,2008' 2>&1' returned exit code '67', the output was 'pw: user `2008' does not exist'
From looking at the code history, I think this has been this way for a long time, not a new bug at all.
Discussed in forum: https://forum.pfsense.org/index.php?topic=90700.msg501766#msg501766
|
|
|
|
|
| |
At the moment you can make a VLAN with tag 0. The input validation does not catch it because when $_POST['tag'] = "0" that evaluates to false by PHP.
Always make the checks on 'tag' value whenever the 'tag' key is set at all. If the (required) 'tag' key is not set, then that is already checked for by do_input_validation().
|
|
|
|
| |
This just looks wrong. But I guess the code path never comes through here because function readline() already exists in the environment of this script.
|
|
|
|
| |
errors in some configurations. Disable it again since it's been disabled for years, and comment out the user-facing config portion for now since it doesn't do anything. Ticket #4516
|
| |
|
|
|
|
| |
browser pick the first in the list (the first the card reported as available), which ended up being 802.11b. Ticket #4516
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
compatible card exists.
|
|
|
|
| |
choosing a specific channel with hostap mode for now.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
correct real interface and use subnet to check IP protocol
|
|
|
|
| |
nodes. Fixes #4446
|
|
|
|
| |
This reverts commit 0e7954b8a333d7ca92f56c86c74e2d9d7457b546.
|
| |
|
|
|
|
| |
with hifn cards
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Similar to
https://github.com/pfsense/pfsense/commit/dedc40f7ded5f88aee4720aa8a3a57667b975254
The password field shows the little lock icon, but the text input area
starts over the top of the icon and as I type in the field the password
"dots" go over the lock icon in each of these data entry places.
Changing the field name/id to not be "password" but to be "passwordfld",
"passwordfld1" "passwordfld2" and the like fixes it. Something does not
like the field being called just "password".
In interfaces.php I also changed the field "username" to be
"ppp_username". This standardized it to work in a similar way to
pppoe_username pptp_username fields. It looks easier to understand for
me.
|
|
|
|
|
|
|
|
|
| |
These are places in the GUI where the cursor sits not in the far left
side of the input box and there is odd-looking white space to the left
of the cursor. Normally there would be a little input graphic in the
white space to the left of the cursor (a pencil, a computer screen, a
lock symbol...)
This change makes the pencil be displayed in all those places.
|
| |
|
| |
|
|
|
|
|
|
|
| |
tab, in case there are scenarios where it's desirable. Ticket #4341
Conflicts:
etc/inc/vpn.inc
|
|
|
|
| |
provided settings
|
|
|
|
| |
provided settings
|
| |
|
|
|
|
|
|
| |
OK, this input validation appears to be outdated.
If there is some edge case that this catches, perhaps it needs to be a more specific test.
|
| |
|
|
|
|
|
|
|
| |
In most places in the GUI a little pencil symbol appears before text input fields. For example it already appears for the Host, Domain and Description fields in this very form when you "Enter additional names for this host."
But in the main 4 fields of this form, the pencil does not display.
This fixes it to be the same as elsewhere.
I guess this is the "standard" supposed to be used. If so, then I will find the other places where class="formfld unknown" has the "unknown" missing.
|
|
|
|
|
|
|
|
| |
In 2.2 when I go to Diagnostics->Authentication the password field shows the little lock icon, but the text input area starts over the top of the icon and as I type in the field the password "dots" go over the lock icon.
This does not happen in 2.1.5 - the password entry cursor sits after the lock icon. This problem is also not evident on most other password entry fields in 2.2
I stared at it for a while, then saw that in other places the password field is not literally called "password", so I thought what the heck, I will change the field name - it fixed the display issue!!! What???
Anyway, this fixes the display issue on my system. If someone knows really why having the field name/id="password" is a problem then they could fix the underlying reason - but this works around whatever is the issue.
If you think this is an OK fix then I will also find the couple of other places swhere this happens and make the same "fix".
|
| |
|
| |
|
|
|
|
| |
so it doesn't match just having comconsole_speed in loader.conf. Ticket #4464
|
| |
|
|
|
|
| |
since field is expected to be space separated and not comma. Ticket #4418
|
| |
|
| |
|
|
|
|
| |
"Harden DNSSEC Data" from being enabled if DNSSEC support isn't enabled.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
inactive and only causing trouble.
|
| |
|