| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
and other random stuff I noticed.
I think this finishes messing with code style. The codebase should match
the developer style guide closely enough that 99.9% of changes will not
feel the need to also massage the formatting.
|
| |
|
| |
|
|
|
|
|
| |
If the DHCP IP address is in a pool (not in the main DHCP range for the interface) then the interface that corresponds to the IP address is not found. This results in the link to "add static mapping for this MAC address" not having any value for "if=" and thus clicking on the "+" button does not work.
Reported in bug 4649
Process any pools when checking for which interface contains the IP address.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note: We can let the code pass "never" (or any other unexpected stuff)
to adjust_gmt()
adjust_gmt() should anyway handle the case when strtotime() cannot
understand the input string and thus returns false. In that case we
return the input string as-is so it will be displayed as the time. That
way the user will see it and can report easily whatever other unexpected
char data was in the leases file.
It also prevents "false" (zero) being converted to the date-time string
and thus becoming the Unix epoch 1 Jan 1970 on the display.
Latest forum report of this kind of thing:
https://forum.pfsense.org/index.php?topic=90083.0
|
|
|
|
|
| |
The edit button for static entries always has an index id=0 and thus pressing the edit button goes to (mostly) edit the wrong entry.
It was easier and made the code cleaner to get rid of the looping through the staticmap array every time trying to matach IP, MAC address... That data ('if' and 'staticmap_array_index') is easily gathered further up, the first time the staticmap array for each DHCP interface is traversed. I think this should also be more efficient when there are many static mapping entries.
Forum: https://forum.pfsense.org/index.php?topic=89072.msg493241#msg493241
|
|
|
|
|
| |
and module names and other bits of formatting and typos in header
comment sections.
|
| |
|
| |
|
|
|
|
| |
As suggested in forum https://forum.pfsense.org/index.php?topic=82883.msg0#new
Instead of a non-functioning red plus icon, show an edit icon for static mapped entries, and take the user to services_dhcp_edit page if it is clicked. IMHO this makes it much easier to correct things that are noticed when viewing the Status, DHCP Leases display.
|
| |
|
| |
|
|
|
|
|
|
|
| |
Add SUMMARY to TABLES
Updates spaces in $fspans and $fspane
Close INPUT and IMG tags and ALT to IMG
Deprecate Ampersand in Anchor tags
|
|
|
| |
replaced <br>, <br/> and </br> with <br />
|
|
|
|
| |
so we no need to calc offset
|
|
|
|
| |
re-parse complete ARP table for each lease, as it can be slow with large ARP tables.
|
| |
|
|
|
|
| |
Value in the "method" attribute should be lower case
|
|
|
|
|
| |
This broke when the code was changed to suck the whole leases file into an array with:
$leases_contents = file($leasesfile);
Each array entry has the text of a line in the file AND the newline at the end of the line. So when matching array entries, the match has to expect the "\n" on the end.
|
| |
|
|
|
|
| |
leases.
|
| |
|
|
|
|
| |
been selected by any interface of DHCP.
|
|
|
|
| |
lease is using local time if not defaults to UTC time.
|
| |
|
| |
|
|
|
|
| |
obtrusive than completely replacing the MAC.
|
|
|
|
| |
Diagnostics->ARP table
|
| |
|
|
|
|
| |
http://forum.pfsense.org/index.php/topic,36657.0.html
|
|
|
|
| |
address in list of DHCP leases. Ticket #861
|
| |
|
| |
|
| |
|
| |
|
|
|