| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
| |
At the confirmation dialog after pressing the "Reinstall XML" button, the text does not distinguish between having pressed "Reinstall the whole package" and "Reinstall the GUI/XML". It would be nice if the text of this confirmation allowed the user to be confident about which button they had just pushed, before confirming the action.
Note: This stuff has no gettext() wrappers - but that can be fixed later, not get mixed up in this.
|
|
|
|
|
| |
I thought that "reinstallxml" should do less than "reinstallpkg" but actually it was getting stuff here, then falling through "reinstalpkg" which did delete_package_xml and then install_pkg, which got the files a 2nd time and...
Maybe that was supposed to happen?
Anyway, I thought I would point this out and someone can either commit this pull request if the "break" should be there, or explain to me why "reinstallxml" is supposed to fall through executing all this code.
|
|
|
|
|
|
|
| |
and other random stuff I noticed.
I think this finishes messing with code style. The codebase should match
the developer style guide closely enough that 99.9% of changes will not
feel the need to also massage the formatting.
|
|
|
|
|
|
|
|
|
| |
The syntax of these all seems good. Because the 2.3-DEVELOPMENT master
does not currently have get_pkg_info implemented, the available packages
tab always says "Unable to retrieve package info...".
But I don't think I broke any code.
This is integrated with the little changes for startdisplayingat var in
pkg.php
|
|
|
|
|
| |
and module names and other bits of formatting and typos in header
comment sections.
|
| |
|
| |
|
|
|
|
| |
from people
|
| |
|
| |
|
|
|
|
|
|
| |
While using the widescreen theme, when you update the firmware or add a
new package the TEXTAREAs are side-by-side which doesn't look neat.
Add BR tag between TEXTAREA
|
|
|
|
| |
separate functions, and then have the "xml" package button perform these so that it is not only a redundant copy of the "pkg" reinstall button. This can help ensure a package files are in a known-good state before other actions are performed, in case the deinstall would fail or behave erratically due to other files being missing.
|
| |
|
| |
|
|\
| |
| |
| | |
ayvis-master-br
|
| |
| |
| | |
replaced <br>, <br/> and </br> with <br />
|
|/ |
|
| |
|
|
|
|
| |
the operation with POST to get protection from CRSF.
|
| |
|
|
|
|
| |
from submitted input.
|
| |
|
|
|
|
|
|
|
|
| |
Add start and TR tags
Tidy up the TABLE tag, move height and colspacing in to STYLE paramenter
Update TD tag with correct background syntax
Move end BODY and end HTML tags to the end of the file, this helps
reduce the error count.
|
| |
|
|
|
|
| |
Discovered-By: Yann CAM
|
|
|
|
|
|
| |
When entering pkg_mgr_install the filesystem was being mounted rw and a backup made of the config, even if the case was "showlog" or "installedinfo". This resulted in:
a) an extra "backup" of the config being made after an install - it could be seen in Diagnostics, Backup Restore, Config History
b) Unnecessary conf_mount_rw and conf_mount_ro calls. These slow down the process on nanobsd-like systems.
This change fixes both these issues.
|
|
|
|
|
|
| |
remove the bionaries and really reinstall them"
This reverts commit 12b0fa564dc9b9ffe1773855e6ab528f4a5c7a5e.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
install/deinstall information being output
|
| |
|
| |
|
|
|
|
| |
system a chance to refresh the menus and the final installation text
|
|
|
|
| |
log file in the beginning rather than on each individual function.
|
|
|
|
|
|
|
|
|
| |
* Do not call eval if we cannot include an .inc file since that will make the whole script fail.
* Keep the log from the start to the end without overwriting. This makes debugging and problem reporting easy and explains what is done during installation.
* Check retrun value of download_with_progress_bar to make it possible catching errors during download.
* Lots of improvements in between
Related to Ticket #950
|
|
|
|
| |
leave stale information behind. Also do not try to startup services twice. Rename uninstall_package_from_name to uninstall_package because the operation on packages is only done through package names.
|
|
|
|
| |
already done modifications. While here do some code cleanup and formating to make it more readble.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Correct checks for avioding as much as possible errors.
Simplify logic in some cases.
Remove package include files when uninstalling packages.
NOTE: Some work is needed to have more error reporting. Espescially when failing to retrieve files or add them locally.
|
| |
|
| |
|