summaryrefslogtreecommitdiffstats
path: root/usr/local/www/interfaces.php
Commit message (Collapse)AuthorAgeFilesLines
* Cancel button after input errorPhil Davis2015-07-131-1/+6
| | | | | | | | | | | If there is an input error then the edit page is redrawn showing the input errors. The HTTP_REFERER becomes the current page, rather than the true original referer. Then if you click Cancel the current page is just redrawn. This change makes the code remember the original referer, so if the user enters some invalid data, presses Save, reads the input error messages then presses Cancel they are taken back out to the original page - the same as if Cancel was used before Save.
* Encoding in interfaces.phpjim-p2015-06-161-4/+4
|
* Fixing PD size selection for HughesNetJonathan2015-06-151-1/+1
|
* Code spacingPhil Davis2015-06-151-59/+61
| | | | | | | and other random stuff I noticed. I think this finishes messing with code style. The codebase should match the developer style guide closely enough that 99.9% of changes will not feel the need to also massage the formatting.
* Correct descriptions on Key Rotation and Master Key Regeneration for wireless.jim-p2015-05-211-2/+2
|
* Remove the "insert my MAC" feature from interfaces.php. It hasn't worked in ↵Chris Buechler2015-05-141-9/+0
| | | | a while (credit sbeaver for noticing), and the only thing it tends to accomplish is breaking people's connectivity from the system where they end up duplicating the MAC of their local system.
* Code style interfaces.phpPhil Davis2015-05-131-449/+681
|
* Check for overlapping subnets when saving interface addressesPhil Davis2015-04-101-4/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This checks if a static IP address entered for an interface has a subnet that overlaps with any other configured subnet. e.g.: LAN is IPv4 10.10.12.1/24 Then try to set OPT1 to 10.10.13.1/23 - it overlaps with LAN because "/23" covers the "12" and "13" together. In the input errors message, display to the user the other interfaces and subnets that overlap/conflict. Then the user has some idea what it is that conflicts and can easily go looking in the right place for the problem. Do the same thing for IPv6 address/CIDR. Note: I have not enhanced any of the checks for conflicts with static routes - there could be cases where a user has a static route like 10.0.0.0/8 pointing to some internal router that has the rest of 10.0.0.0/8 behind it, but the user has some direct-attached subnet inside that - e.g. 10.1.2.0/24 - the routing table should cope with this, delivering directly to 10.1.2.0/24 and routing for the rest of 10.0.0.0/8. So we cannot invalidate all overlaps with static routes. I think this validation will not invalidate any exotic-but-valid use cases. I can't think of when the interface subnets on 2 interfaces can overlap and still be a valid/useful configuration. This should stop people setting up dumb mixes of LAN/OPT1/OPT2... with random addresses and CIDR prefix that overlap each other.
* Use is_numericint() instead of empty() to check if value has been entered ↵k-paulius2015-03-221-4/+4
| | | | because empty() does not allow 0, which is a valid value.
* Make sure 'DHCPv6 Prefix Delegation size' is provided if 'Send IPv6 prefix ↵k-paulius2015-03-221-0/+3
| | | | hint' flag is checked to avoid generating invalid dhcp6c configuration file.
* Add option for wireless standard "auto", to omit "mode" entirely from ↵Chris Buechler2015-03-181-0/+5
| | | | ifconfig. This shouldn't be necessary, but specifying mode has proven to trigger driver problems that don't exist if it's left unspecified (such as FreeBSD PR 198680). Chosing "auto" fixes ath(4) BSS mode issues otherwise preventing it from connecting.
* txpower was disabled for good reason it would appear, it triggers syntax ↵Chris Buechler2015-03-131-1/+3
| | | | errors in some configurations. Disable it again since it's been disabled for years, and comment out the user-facing config portion for now since it doesn't do anything. Ticket #4516
* Apply WME input validation to all modes, not just hostap. Ticket #4516Chris Buechler2015-03-131-5/+5
|
* Default to 11ng if an option hasn't been configured. Previously we let the ↵Chris Buechler2015-03-131-1/+7
| | | | browser pick the first in the list (the first the card reported as available), which ended up being 802.11b. Ticket #4516
* Default to WPA2, AES for new wireless interface configs. Ticket #4516Chris Buechler2015-03-131-2/+2
|
* touch up interfaces.php textChris Buechler2015-03-131-2/+2
|
* Require WPA PSK where WPA-PSK is enabled. Clean up some other text. Ticket #4516Chris Buechler2015-03-121-2/+7
|
* clean up input errors textChris Buechler2015-03-121-2/+2
|
* Fix up text, remove "only for Atheros" since the option is only shown if a ↵Chris Buechler2015-03-121-1/+1
| | | | compatible card exists.
* "Auto" channel with hostap doesn't work correctly at the moment, force ↵Chris Buechler2015-03-121-0/+4
| | | | choosing a specific channel with hostap mode for now.
* add more wireless validation. Ticket #4516Chris Buechler2015-03-121-1/+4
|
* Add more validation for wireless config settings. Ticket #4516Chris Buechler2015-03-121-0/+22
|
* Add more input validation for wireless parameters. Ticket #4516Chris Buechler2015-03-121-0/+36
|
* Touch up wifi textChris Buechler2015-03-121-3/+3
|
* Fix password box cursor positionPhil Davis2015-03-101-12/+12
| | | | | | | | | | | | | | | Similar to https://github.com/pfsense/pfsense/commit/dedc40f7ded5f88aee4720aa8a3a57667b975254 The password field shows the little lock icon, but the text input area starts over the top of the icon and as I type in the field the password "dots" go over the lock icon in each of these data entry places. Changing the field name/id to not be "password" but to be "passwordfld", "passwordfld1" "passwordfld2" and the like fixes it. Something does not like the field being called just "password". In interfaces.php I also changed the field "username" to be "ppp_username". This standardized it to work in a similar way to pppoe_username pptp_username fields. It looks easier to understand for me.
* Allow reassignment from PPP types to DHCP. From testing, it appears to work ↵jim-p2015-03-091-4/+0
| | | | | | OK, this input validation appears to be outdated. If there is some edge case that this catches, perhaps it needs to be a more specific test.
* Add missing 'break' statement that broke switching from a PPP type to 'none'.jim-p2015-03-091-0/+2
|
* Fix track6 prefix id range in error message, reported on Pull Request #1517Renato Botelho2015-02-261-1/+2
|
* Fix broken links to dhcp6c.conf man page.k-paulius2015-02-221-6/+6
| | | | manpath FreeBSD+Ports no longer exits and needs to be replaced with FreeBSD+10.1-RELEASE+and+Ports
* fix textChris Buechler2015-02-021-2/+2
|
* Also include /127 for IPv6, it works fine. Ticket #3657Chris Buechler2015-01-071-5/+3
|
* Allow for configuring /31 masks on interfaces.php. The rest of the code was ↵Chris Buechler2015-01-071-10/+6
| | | | updated accordingly some time ago, and an employee with Cox Communications has confirmed this allows things to work on their circuits deployed with /31s. Ticket #4190
* fix up textChris Buechler2015-01-071-2/+2
|
* Fix track6 prefix id range check, reported by jimpRenato Botelho2015-01-021-1/+1
|
* Fix lineup of copyright linesPhil Davis2015-01-011-1/+1
| | | | | and module names and other bits of formatting and typos in header comment sections.
* Welcome 2015Renato Botelho2014-12-311-1/+1
|
* Disable dhcp server when interface is disabled. Ticket #4119Renato Botelho2014-12-171-1/+5
|
* Fix #3790:Renato Botelho2014-12-111-15/+38
| | | | | - Do not let 2 interfaces to setup the same track6 prefix id - Show correct prefix id range for each interface
* Try to not make useless entries in the config file for very rare used ↵Ermal LUÇI2014-12-021-34/+62
| | | | configuration values. Makes config file readble and with less size
* validate MTU and MSS as integers, and don't allow MSS larger than pf will ↵Chris Buechler2014-11-281-4/+7
| | | | accept to avoid broken rulesets.
* convert_real_interface_to_friendly_interface_name() goes and checks the ↵Ermal LUÇI2014-11-261-1/+1
| | | | parent and this gives wrong information 99.9 percent of the time on scenarios like when this is called for unassigned vlans etc, while its real purpose is just to check if the interface is assigned and return the intermeddiate/config name of the interface. Leave the get_parent_option there in the function but it needs to be asked specifically for.
* Ticket #2786 there is an issue with ↵Ermal LUÇI2014-11-251-1/+1
| | | | convert_real_interface_to_friendly_interface which might return not expected data as in the situation checked for vlan case her ein the validation. Avoid for this case here the issue to allow properly setting mtu on vlans with not assigned parent.
* Don't unset these items for PPP configurations as they're not configured ↵Chris Buechler2014-11-221-2/+2
| | | | here and doing so loses settings configured in interfaces_ppps_edit.php. Ticket #3727
* Fixes #3727 Do not unset configuration values from ppp config if not needed.Ermal LUÇI2014-11-201-12/+22
|
* 6RD Rapid Deployment is akin to ATM Machine, PIN Number, ... read: it's ↵Chris Buechler2014-11-141-1/+1
| | | | redundant. let's just call it 6RD Configuration.
* Don't allow interface descriptions that are strictly numbers as thatChris Buechler2014-11-121-0/+3
| | | | generates an invalid ruleset. Ticket #4005
* fix variable typoChris Buechler2014-11-121-1/+1
|
* fix textChris Buechler2014-11-121-1/+1
|
* modify copyright statement to reflect realityJim Thompson2014-11-101-0/+1
|
* Fixes #3727 Do not unset ondemand for ppp type interfaces since it is ↵Ermal2014-10-151-1/+2
| | | | controlled here only for pppoe/l2tp
OpenPOWER on IntegriCloud