| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
| |
If there is an input error then the edit page is redrawn showing the
input errors. The HTTP_REFERER becomes the current page, rather than the
true original referer. Then if you click Cancel the current page is just
redrawn.
This change makes the code remember the original referer, so if the user
enters some invalid data, presses Save, reads the input error messages
then presses Cancel they are taken back out to the original page - the
same as if Cancel was used before Save.
|
| |
|
| |
|
|
|
|
|
|
|
| |
and other random stuff I noticed.
I think this finishes messing with code style. The codebase should match
the developer style guide closely enough that 99.9% of changes will not
feel the need to also massage the formatting.
|
| |
|
|
|
|
| |
a while (credit sbeaver for noticing), and the only thing it tends to accomplish is breaking people's connectivity from the system where they end up duplicating the MAC of their local system.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This checks if a static IP address entered for an interface has a subnet
that overlaps with any other configured subnet. e.g.:
LAN is IPv4 10.10.12.1/24
Then try to set OPT1 to 10.10.13.1/23 - it overlaps with LAN because
"/23" covers the "12" and "13" together.
In the input errors message, display to the user the other interfaces
and subnets that overlap/conflict. Then the user has some idea what it
is that conflicts and can easily go looking in the right place for the
problem.
Do the same thing for IPv6 address/CIDR.
Note: I have not enhanced any of the checks for conflicts with static
routes - there could be cases where a user has a static route like
10.0.0.0/8 pointing to some internal router that has the rest of
10.0.0.0/8 behind it, but the user has some direct-attached subnet
inside that - e.g. 10.1.2.0/24 - the routing table should cope with
this, delivering directly to 10.1.2.0/24 and routing for the rest of
10.0.0.0/8. So we cannot invalidate all overlaps with static routes.
I think this validation will not invalidate any exotic-but-valid use
cases. I can't think of when the interface subnets on 2 interfaces can
overlap and still be a valid/useful configuration.
This should stop people setting up dumb mixes of LAN/OPT1/OPT2... with
random addresses and CIDR prefix that overlap each other.
|
|
|
|
| |
because empty() does not allow 0, which is a valid value.
|
|
|
|
| |
hint' flag is checked to avoid generating invalid dhcp6c configuration file.
|
|
|
|
| |
ifconfig. This shouldn't be necessary, but specifying mode has proven to trigger driver problems that don't exist if it's left unspecified (such as FreeBSD PR 198680). Chosing "auto" fixes ath(4) BSS mode issues otherwise preventing it from connecting.
|
|
|
|
| |
errors in some configurations. Disable it again since it's been disabled for years, and comment out the user-facing config portion for now since it doesn't do anything. Ticket #4516
|
| |
|
|
|
|
| |
browser pick the first in the list (the first the card reported as available), which ended up being 802.11b. Ticket #4516
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
compatible card exists.
|
|
|
|
| |
choosing a specific channel with hostap mode for now.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Similar to
https://github.com/pfsense/pfsense/commit/dedc40f7ded5f88aee4720aa8a3a57667b975254
The password field shows the little lock icon, but the text input area
starts over the top of the icon and as I type in the field the password
"dots" go over the lock icon in each of these data entry places.
Changing the field name/id to not be "password" but to be "passwordfld",
"passwordfld1" "passwordfld2" and the like fixes it. Something does not
like the field being called just "password".
In interfaces.php I also changed the field "username" to be
"ppp_username". This standardized it to work in a similar way to
pppoe_username pptp_username fields. It looks easier to understand for
me.
|
|
|
|
|
|
| |
OK, this input validation appears to be outdated.
If there is some edge case that this catches, perhaps it needs to be a more specific test.
|
| |
|
| |
|
|
|
|
| |
manpath FreeBSD+Ports no longer exits and needs to be replaced with FreeBSD+10.1-RELEASE+and+Ports
|
| |
|
| |
|
|
|
|
| |
updated accordingly some time ago, and an employee with Cox Communications has confirmed this allows things to work on their circuits deployed with /31s. Ticket #4190
|
| |
|
| |
|
|
|
|
|
| |
and module names and other bits of formatting and typos in header
comment sections.
|
| |
|
| |
|
|
|
|
|
| |
- Do not let 2 interfaces to setup the same track6 prefix id
- Show correct prefix id range for each interface
|
|
|
|
| |
configuration values. Makes config file readble and with less size
|
|
|
|
| |
accept to avoid broken rulesets.
|
|
|
|
| |
parent and this gives wrong information 99.9 percent of the time on scenarios like when this is called for unassigned vlans etc, while its real purpose is just to check if the interface is assigned and return the intermeddiate/config name of the interface. Leave the get_parent_option there in the function but it needs to be asked specifically for.
|
|
|
|
| |
convert_real_interface_to_friendly_interface which might return not expected data as in the situation checked for vlan case her ein the validation. Avoid for this case here the issue to allow properly setting mtu on vlans with not assigned parent.
|
|
|
|
| |
here and doing so loses settings configured in interfaces_ppps_edit.php. Ticket #3727
|
| |
|
|
|
|
| |
redundant. let's just call it 6RD Configuration.
|
|
|
|
| |
generates an invalid ruleset. Ticket #4005
|
| |
|
| |
|
| |
|