| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
and other random stuff I noticed.
I think this finishes messing with code style. The codebase should match
the developer style guide closely enough that 99.9% of changes will not
feel the need to also massage the formatting.
|
| |
|
|
|
|
|
|
|
|
| |
The tabbing of this code is not so good, so it is difficult to see what is going on. I will format that in a later pull request.
These things look unbalanced but actually were not at run time. These changes make it easier to check the code in an editor that can show the balanced "table" "/table", "selected" "/selected".
1) Take the "table" start declaration out of the output form var that has been built up. Put it in-line in the code so it can be seen to match the "/table" now at line 575. $output var is no longer needed.
2) Remove 3 "/select" that were each inside an "if" statement. Put a single "/select" at the end. This makes it easy to see the matching "select" and "/select" and also ensures there will always be a "/select" written.
I thought these things were worth doing separate to code-style, as they are "real" changes. The L7 form still works in my testing.
|
|
|
|
|
|
| |
messages"
This reverts commit 91b9a02fb131746c67fdf9f34282f123a13f1b13.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix various files that can emit messages like:
PHP Strict Standards: Non-static method SimplePie_Misc::array_unique()
should not be called statically, assuming $this from incompatible
context in /etc/inc/simplepie/simplepie.inc on line 5508
php-fpm[16262]: /rc.newipsecdns: PHP ERROR: Type: 8192, File:
/etc/inc/shaper.inc, Line: 4365, Message: Assigning the return value of
new by reference is deprecated
Some of these style messages have been reported on the forum, e.g.
https://forum.pfsense.org/index.php?topic=86448.0
I had RSS widget on, and simplepie sent the system beserk telling about
all this stuff.
|
|
|
|
|
| |
and module names and other bits of formatting and typos in header
comment sections.
|
| |
|
| |
|
|
|
|
| |
files to UTF-8
|
|
|
|
| |
#2565
|
|
|
|
|
|
|
|
|
|
| |
Add missing closing SPAN tag
Remove P tag and class from shaper message
Swap TABLE and DIV tags
Add CDATA sections to SCRIPT tags and escape closing SECTION and OPTION
tags
Add missing TR tag
Add missing end DIV tag
|
|
|
|
|
|
|
|
|
|
|
| |
Close INPUT, BR, P and IMG tags
Add "alt" to IMG tags
Add CDATA section to scripts
Move "tree.css" and "tree.js" to the HEAD statement and close the HEAD
statement manually
Spelling mistake
Update PHP shorthand tag
Update HTML boolean operators
|
|
|
|
| |
unless the user is allowed to do that.
|
| |
|
| |
|
|
|
|
| |
unwanted behavior with the enter key. Use links instead, where possible.
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
usr/local/www/diag_smart.php
usr/local/www/firewall_rules_edit.php
usr/local/www/interfaces.php
usr/local/www/load_balancer_pool_edit.php
usr/local/www/pkg_mgr_settings.php
|
| | |
|
|/ |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
existing configuration(did changes to existing one) just tell ipfw-classifyd to reload the config.
|
| |
|
|
|
|
| |
include 2009 on files that I have asserted (C) on
|
|
|
|
|
|
| |
- Present three new functions is/mark/clear_subsystem_dirty('name_of_subsystem'). This makes easier to create such things without needing to introduce new globals.
- Convert all pages to the new infrustructure
- This improves a lot the control on this notification
|
|
|
|
|
|
|
|
|
|
|
| |
locking using semaphores.
This function can sleep till the resource is free and can help find not well behaving code.
* Remove most of the config_lock/config_unlock logics on the whole scripts/pages it is an abuse of this.
If any sybsytem wants to lock can do so with its own lock.
* Lock the config when doing a filter reload to avoid parallell recursion on this function, since it is not reentrant.
This compenstates for the removal of lock aquiring from the scripts/pages.
* config_lock/config_unlock are now compate shims that do nothing. They are preserved since packages 'abuse' them too.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|