summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #2320 from stilez/patch-3Renato Botelho2016-02-041-14/+33
|\
| * REBASE of #1786 and #1788, tightening three IP functionsstilez2015-12-231-14/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resubmit of two PRs that couldn't be merged due to basecode conflicts is_linklocal() - tightened and made correctly IPv4/v6 agnostic per RFCs is_literalipaddrv6() - simplified is_hostnamewithport() - simplified IS_LINKLOCAL() is_linklocal has a few issues, including validating as linklocal, addresses that aren't linklocal according to RFC 4291, validating as a linklocal address input that could contain arbitrary text/no validation of reasonableness on any %(scope/interface) present, and appearing from its function name to be suitable for all linklocal addresses but actually not IPv4/v6 agnostic. 1) IPv4/6 agnostic: while IPv4 linklocal testing isn't much needed, not it should probably be recognised because some code handling linklocal may reasonably expect is_linklocal() to be IPv4/IPv6 agnostic. 2) For IPv6, it tests at least, that the purported scope/interface is [0-9a-z]+ otherwise user input or other text such as "fe80::%\n;ARBIRARYTEXT;" would be validated as a linklocal address and inserted into pf and perhaps other places without further detection, leading to possible vulnerabilities. Also tests scope/interface for a reasonable length of <= 64 chars "just in case". But it doesn't test more than this (and probably should test for valid scope/interface if present). 3) Follows RFC 4291 exactly: IPv6 linklocal isn't just "fe80::", it requires the rest of the first 64 bits to be zero too. The RFC defines it as '1111111010' + 54 zeros (Ref: https://tools.ietf.org/html/rfc4291#section-2.5.6 ) 4) Returns 4 or 6 to give a more exact response to the calling function as to whether the match was an IPv4 linklocal or IPv6 linklocal address (both evaluate to True for Boolean test purposes such as "if (is_linklocal(...))") Note: Net_IPv6::_Ip2Bin() can return shorter binary strings for IPv4 or "junk" input. So this code tests that it returned a 128 bit length, which ensure it was meaningful IPv6. IS_HOSTNAMEWITHPORT() simplified - we don't need to pop() or assign a new variable just to test 2nd member of the array IS_LITERALIPADDRV6() simplified - we don't need an expensive preg_match() to test if it's a valid IPv6 wrapped in "[" ... "]"
* | Isolate the check for @label in the end of hostname only for noip and noip-freeRenato Botelho2016-02-041-5/+8
| |
* | Merge pull request #2574 from tiagobar/masterRenato Botelho2016-02-042-1/+8
|\ \
| * | Dynamic DNS URL for NO-IP needs to be updated.Tiago Barrionuevo2016-01-302-1/+8
| | |
* | | Merge pull request #2579 from NOYB/HTML_Compliance_-_Status_/_DHCPv6_leasesRenato Botelho2016-02-041-2/+2
|\ \ \
| * | | HTML Compliance - Status / DHCPv6 leasesNOYB2016-02-021-2/+2
| | | | | | | | | | | | | | | | | | | | Stray end tag tr. Move stray tr end tags inside foreach loops.
* | | | Also switch admin password in the default config.xml to bcrypt. Ticket #4120jim-p2016-02-041-1/+1
| | | |
* | | | Catch up to latest config versionjim-p2016-02-041-1/+1
| | | |
* | | | Merger PR 2583 but retained non-sortable actions columnStephen Beaver2016-02-041-1/+1
| | | |
* | | | Status / DHCP leases - Root Cause Sort IssueNOYB2016-02-041-7/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sort routine apparently does not honor colspan attribute. Here are three possible solutions: 1) Add a description column instead of spanning the start and end columns. This is the method presented in this commit. 2) Include an empty second column with the description instead of spanning. This would not be very display/sort friendly though because it would be sharing the start column with the description. 3) Display two empty cells when lease type is static, instead of the description. This is the way status DHCPv6 leases currently works.
* | | | Fix #5830Renato Botelho2016-02-042-2/+24
| | | | | | | | | | | | | | | | | | | | Add a new advanced option on gateways to allow user define data payload. Default is 0
* | | | Don't sort online, lease type or action icon columnsStephen Beaver2016-02-031-3/+3
| | | |
* | | | Add RFC 2136 support to the DynDNS widgetjim-p2016-02-031-7/+34
| | | |
* | | | Add back "Save & Force Update" for RFC 2136jim-p2016-02-031-5/+10
| | | |
* | | | Implement Multi-WAN for RFC2136.jim-p2016-02-033-13/+41
| | | | | | | | | | | | | | | | A failover gateway group may be selected similar to the other DynDNS styles.
* | | | Fix hiding of shadow selectorStephen Beaver2016-02-032-2/+2
| | | |
* | | | Improvements to priv filteringStephen Beaver2016-02-031-8/+57
| | | |
* | | | Improvements to the priviledge filter functionalityStephen Beaver2016-02-035-21/+70
| | | |
* | | | Merge pull request #2582 from ↵Renato Botelho2016-02-031-3/+2
|\ \ \ \ | | | | | | | | | | | | | | | NOYB/System_/_Advanced_/_Firewall_and_NAT_-_Remove_PPTP_from_Verbiage
| * | | | System / Advanced / Firewall and NAT - Remove PPTP from VerbiageNOYB2016-02-031-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | Remove PPTP from Verbiage. https://forum.pfsense.org/index.php?topic=106257.0 Also don't see any reason for the span tag here.
* | | | | Merge pull request #2581 from PiBa-NL/23_silence_syncerrorRenato Botelho2016-02-031-1/+1
|\ \ \ \ \
| * | | | | xmlrpc_client.inc, silence the php 'crash' error, sync errors are reported ↵PiBa-NL2016-02-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | through file-notices already.
* | | | | | Gbps isn't interpreted correctly by ipfw for limiters, remove the option. ↵Chris Buechler2016-02-031-1/+1
| |/ / / / |/| | | | | | | | | | | | | | Ticket #4325
* | | | | Duplicate monitors rather than overwrite. Ticket #4441Chris Buechler2016-02-031-0/+4
| | | | |
* | | | | pfsync syncpeer requires IPv4. Ticket #4648Chris Buechler2016-02-021-0/+6
| | | | |
* | | | | Added priv filter capabilityStephen Beaver2016-02-021-1/+65
| | | | |
* | | | | Fixed #5049Stephen Beaver2016-02-021-1/+66
| | | | |
* | | | | Regenerate .potRenato Botelho2016-02-021-1907/+2193
| | | | |
* | | | | Merge pull request #2580 from phil-davis/gtsys2Renato Botelho2016-02-0213-75/+77
|\ \ \ \ \
| * | | | | Internationalization of various system*.phpPhil Davis2016-02-0313-75/+77
| | | | | |
* | | | | | Fix up DynDNS widget to follow recent changes in DynDNS for Namecheapjim-p2016-02-021-3/+14
| | | | | |
* | | | | | Cosmetic saveStephen Beaver2016-02-022-2/+4
|/ / / / /
* | | | | Per #4195Stephen Beaver2016-02-021-1/+1
| | | | | | | | | | | | | | | | | | | | Alias table is now sortable
* | | | | Status / System Logs - Forms Buttons Icons UpdateNOYB2016-02-021-6/+7
| | | | | | | | | | | | | | | | | | | | | | | | | Add icon to save button. Consolidate addClass statements.
* | | | | Fix easy rule problem when using a non-English language, take 2.jim-p2016-02-021-1/+2
| | | | |
* | | | | Fix #5831 using a simpler approach, just setting REPO_AUTOUPDATE=false when ↵Renato Botelho2016-02-021-0/+4
| | | | | | | | | | | | | | | | | | | | it's booting
* | | | | Revert "Fix #5831"Renato Botelho2016-02-021-4/+4
| |/ / / |/| | | | | | | | | | | This reverts commit 93a8ddf7a4c5d43cbeb623c923eb76659e6f49e0.
* | | | Use the NAS IP configured for PPPoE server instances. Ticket #185Chris Buechler2016-02-021-0/+3
| | | |
* | | | Remove old pppoerestart cron job if it exists. Ticket #1905Chris Buechler2016-02-021-0/+10
| | | |
* | | | Set fastcgi_read_timeout to 180 seconds rather than the default 60 for the ↵Chris Buechler2016-02-011-0/+1
| | | | | | | | | | | | | | | | occasional long-running page.
* | | | Add missing description fieldStephen Beaver2016-02-011-2/+9
| | | |
* | | | Save pkg call return code to use on return. The way it is now is always ↵Renato Botelho2016-02-011-1/+2
| | | | | | | | | | | | | | | | returning 0. It should fix #5837
* | | | Change Namecheap dyndns to use split hostname and domain name fields. ↵jim-p2016-02-016-38/+111
| | | | | | | | | | | | | | | | | | | | | | | | Upgrade existing entries automatically. Implements #4366 Code should be generic enough that if other DynDNS providers would work better with a separate domain field, they can pick up the feature without too much trouble.
* | | | TypoStephen Beaver2016-02-011-1/+1
| | | |
* | | | Make row delete button icon only (removes gettext("Delete"): )Stephen Beaver2016-02-011-1/+1
| | | |
* | | | Fixed #5834Stephen Beaver2016-02-011-15/+14
| | | |
* | | | Remove all additional packages from the system before reset to factory ↵Renato Botelho2016-02-013-0/+6
| | | | | | | | | | | | | | | | default. Fixes #5829
* | | | Make additional packages install/delete operations to respect -n (dry-run)Renato Botelho2016-02-011-3/+3
| | | |
* | | | Reorder pkg_reinstall_all(), no functional changesRenato Botelho2016-02-011-11/+11
| | | |
OpenPOWER on IntegriCloud