| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
CARP IPs. Ticket #4858
|
| |
|
| |
|
| |
|
|
|
|
| |
broken the get_configured_carp_interface_list. Ticket #5844
|
|
|
|
| |
user. Ticket #5844
|
| |
|
| |
|
|
|
|
| |
negation for ESP that seems to have been accidentally omitted.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the introduction of pkg_with_pb(), direct calls to this function
were added using the following format:
if ! pkg_with_pb ... | tee -a $logfile; then
What happened in this case is if was always getting a successfull
return code from tee call, and pkg_with_pb return was always being
ignored leading pfSense-upgrade to keep running when a fatal error
happened.
Since we need to print pkg output and also send it to log, _exec() call
is the best option here.
Added necessary flags to make sure necessary actions (unlock additional
packages or cleaning up kernel package annotation) are executed on
_exit call in fatal cases and replaced all direct calls by _exec()
|
|
|
|
|
| |
Start tag body seen but an element of the same type was already open.
Stray start tag script.
|
|\ |
|
| | |
|
|/
|
|
| |
correct. Ticket #5842
|
| |
|
|
|
|
| |
interface, we don't want to handle disable separately from everything else, as that discards all the changes other than disabling the interface. Everything else with handling bringing down of interfaces is still handled correctly. semi-related to Ticket #2453
|
|
|
|
| |
Show on dashboard widget when a gateway is unmonitored. Ticket #2226
|
|
|
|
| |
removed already.
|
| |
|
|
|
|
| |
creating too long of a route-to line. Related to pull request 1614
|
| |
|
| |
|
|\ |
|
| | |
|
| | |
|
|\ \
| |/
|/| |
|
| |
| |
| | |
Used explode to array rather than to a list, and tested array size, so as not to assume it has exactly 2 parts separated by "/".
|
| | |
|
| | |
|
| | |
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Resubmit of two PRs that couldn't be merged due to basecode conflicts
is_linklocal() - tightened and made correctly IPv4/v6 agnostic per RFCs
is_literalipaddrv6() - simplified
is_hostnamewithport() - simplified
IS_LINKLOCAL()
is_linklocal has a few issues, including validating as linklocal, addresses that aren't linklocal according to RFC 4291, validating as a linklocal address input that could contain arbitrary text/no validation of reasonableness on any %(scope/interface) present, and appearing from its function name to be suitable for all linklocal addresses but actually not IPv4/v6 agnostic.
1) IPv4/6 agnostic: while IPv4 linklocal testing isn't much needed, not it should probably be recognised because some code handling linklocal may reasonably expect is_linklocal() to be IPv4/IPv6 agnostic.
2) For IPv6, it tests at least, that the purported scope/interface is [0-9a-z]+ otherwise user input or other text such as "fe80::%\n;ARBIRARYTEXT;" would be validated as a linklocal address and inserted into pf and perhaps other places without further detection, leading to possible vulnerabilities. Also tests scope/interface for a reasonable length of <= 64 chars "just in case". But it doesn't test more than this (and probably should test for valid scope/interface if present).
3) Follows RFC 4291 exactly: IPv6 linklocal isn't just "fe80::", it requires the rest of the first 64 bits to be zero too. The RFC defines it as '1111111010' + 54 zeros (Ref: https://tools.ietf.org/html/rfc4291#section-2.5.6 )
4) Returns 4 or 6 to give a more exact response to the calling function as to whether the match was an IPv4 linklocal or IPv6 linklocal address (both evaluate to True for Boolean test purposes such as "if (is_linklocal(...))")
Note: Net_IPv6::_Ip2Bin() can return shorter binary strings for IPv4 or "junk" input. So this code tests that it returned a 128 bit length, which ensure it was meaningful IPv6.
IS_HOSTNAMEWITHPORT()
simplified - we don't need to pop() or assign a new variable just to test 2nd member of the array
IS_LITERALIPADDRV6()
simplified - we don't need an expensive preg_match() to test if it's a valid IPv6 wrapped in "[" ... "]"
|
| | | |
|
|\ \ \ |
|
| | | | |
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Stray end tag tr.
Move stray tr end tags inside foreach loops.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Sort routine apparently does not honor colspan attribute.
Here are three possible solutions:
1) Add a description column instead of spanning the start and end columns. This is the method presented in this commit.
2) Include an empty second column with the description instead of spanning. This would not be very display/sort friendly though because it would be sharing the start column with the description.
3) Display two empty cells when lease type is static, instead of the description. This is the way status DHCPv6 leases currently works.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Add a new advanced option on gateways to allow user define data
payload. Default is 0
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
A failover gateway group may be selected similar to the other DynDNS styles.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
NOYB/System_/_Advanced_/_Firewall_and_NAT_-_Remove_PPTP_from_Verbiage
|