| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| | |
|
| |
| |
| | |
as suggested by @rbgarga
|
| |
| |
| |
| |
| |
| | |
1) The logic of the various tests that determined which messages were displayed was all a bit odd, and there were ways that things could happen and no message was displayed. Now it displays the "warning" information message the first time, and 1 of the 4 possible result messages depending on the result status and if showtest was on.
2) Internationalize - put the gettext() into calls with full sentences and sprintf() wrappers as necessary.
Now I can get each of the 4 possible result messages, and always get a result message.
|
|\ \ |
|
| | | |
|
|\ \ \ |
|
| |/ /
| | |
| | |
| | | |
Note: in the end, edit.php has only whitespace format changes.
|
|\ \ \ |
|
| | | | |
|
|\ \ \ \ |
|
| |/ / /
| | | |
| | | |
| | | | |
Set logarr as array() per default, default invert to empty string, improve variable representation within strings
|
|\ \ \ \ |
|
| | | | | |
|
| | | | | |
|
| |/ / / |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
pfBlockerNG is going to use lighttpd
This reverts commit c74719cde73c8ce19465e1887f8c519c4818147c.
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
pfBlockerNG is going to use lighttpd
This reverts commit 4bebb56a23658eac8791df7c1a44927e66c6d51c.
|
| | |
| | |
| | | |
Forum: https://forum.pfsense.org/index.php?topic=105448.0
|
| | | |
|
| | |
| | |
| | |
| | | |
inconsistent handling of checkboxes in packages.
|
|\ \ \ |
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | | |
If you manually navigate directly to easyrule.php you get a bit of rubbish text displayed before the actual message about "This is the Easy Rule status page...". That is due to having too many closing PHP tags. Also, fbegin.inc does not need to be included anyway.
I also changed the message to be in a print_info_box() warning and sorted the internationalization a bit more.
There could be a bit more formatting done here after this - the page has a help icon that looks a bit lonely without the other usual panel-heading panel-title stuff.
|
|/ /
| |
| |
| |
| |
| |
| | |
1) Internationalize
2) If there was a problem, then display it with print_info_box() up the top of the page.
3) Redisplay the user-selected IP protocol and source IP after a test. Previously those user selections always got reset to IPv4, any.
4) Remove some useless code that unset($do_traceroute) when it had happily been set to false a little earlier.
5) Remove some useless code that set $host when it had already been set a little earlier.
|
|\ \
| | |
| | |
| | | |
NOYB/Status_/_System_Logs_-_Raw_Mode_Search_Inversion
|
| |/
| |
| |
| | |
Add search inversion to dump_clog and dump_clog_no_table functions for raw mode logs filter.
|
|\ \ |
|
| |/ |
|
|/
|
|
|
| |
renamed get_type to getType
fix capitalisation in getTagName
|
|
|
|
| |
set but empty. Fixes #5775
|
| |
|
| |
|
|
|
|
| |
packages.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
EXCEPT that the link in the help text does not point to the correct place (yet)
|
|\ |
|
| | |
|
| | |
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
A couple of typical fixes here:
1) Actually wrap the "Are you sure...?" question in gettext()
2) Use a single gettext() call combined with sprintf() and %s etc to construct a sentence in a single go.
3) Use %s rather than just appending a variable at the end of a sentence of text. That way there is no assumption that the variable text must go at the end in every language.
Once I have got the feel of the variations I come across, I will make myself a branch and change a whole bunch of files. But for now I have submitted a few things individually so it is easy for people to comment and give any helpful advice on how to do it better, before I go editing lots of files.
IMHO it will be good to cleanup and optimize the internationalized code, then life should be easier for future translators.
|
|\ \ \ |
|
| |/ /
| | |
| | |
| | |
| | | |
Sentences that are constructed in pieces like this are a potential problem for translation, if the target language needs to use a different grammatical word order. e.g. in Nepali we would say datetime-dekhi datetime-samma (datetime-from datetime-to).
Organize it into a single gettext() that has the whole sentence in one go with numbering of the parameters so they can also be potentially re-ordered as needed in a translation.
I am having a look at a few places where the gettext() translation is missing, and noticed this kind of thing also. When I see this sort of sentence construction using sentence fragments built up with multiple gettext() calls I will fix them up like this and make PRs.
|
|/ / |
|
| |
| |
| |
| | |
so the page operated as written rather that as desired.
|