| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
1) Wrap all the various arrays of text that are displayed to the user in gettext()
2) Give the possibility to translate the singular of words like "host", "network" that get substituted into message strings.
3) Where there are multiple %s in an sprintf() use %$1s %s2s to be really sure, even though it seems to be a case where the order of substitution will never be swapped.
|
| | | | | | |
|
| |/ / / /
|/| | | | |
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The subnet overlap functions came up as a concern while fixing redmine 5702.
Specifically -
The "canonical" function check_subnets_overlap() doesn't handle IPv6 (util.inc has standardised on v4/v6/agnostic versions, but this doesn't fit). Fixed by adding transparent detection of v4/v6 and a specific IPv4-only version
The IPv6 version is wrong (if sub1 *contains* sub2 then neither of sub1's endpoints will be detected as "inrange" of sub2 and result will be incorrect: this logic error has been fixed recently in other code too)
Bad data isn't detected - this still isn't detected for compatibility and is tagged "FIXME" instead to look at in future. Reason - not to break anything, at present always returns "overlap = true/false", not "true/false/invalid input".
because CIDR overlap implies containment, the IPv4 version uses a very efficient logic, namely calculates largest size subnet and checks this is same for both. Adopting this for both, and simplifying, makes these functions far "neater"
The old v4 version allowed for non-numeric $bits which doesn't make sense and I've omitted. Cannot think of a single situation where we would provide empty or bad data when we actually mean a /32 single IP.
Solution in this commit - a canonical "overlap" test (IPv4/IPv6 agnostic), IPv4/v6 "overlap" versions that actually do the work, in each case using the same logic as the old v4 (identify largest bit size and test if subnets created are valid and identical), and tag lack of "bad data" detection as fixme for now, returning FALSE instead to avoid breaking anything until fixed. Should be transparent from outside.
|
| | | | | |
|
| | | | | |
|
| |/ / /
|/| | |
| | | |
| | | | |
when user is editing an alias type that uses the subnet CIDR field as the URL table update frequency.
Forum: https://forum.pfsense.org/index.php?topic=105457.0
|
| | | |
| | | |
| | | |
| | | | |
Address field is used for a wide variety of input types. Including URLs which require a much greater character set acceptance.
|
|\ \ \ \ |
|
| | | | | |
|
| | | | |
| | | | |
| | | | | |
as suggested by @rbgarga
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
1) The logic of the various tests that determined which messages were displayed was all a bit odd, and there were ways that things could happen and no message was displayed. Now it displays the "warning" information message the first time, and 1 of the 4 possible result messages depending on the result status and if showtest was on.
2) Internationalize - put the gettext() into calls with full sentences and sprintf() wrappers as necessary.
Now I can get each of the 4 possible result messages, and always get a result message.
|
|\ \ \ \ \ |
|
| | | | | | |
|
|\ \ \ \ \ \ |
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | | |
Note: in the end, edit.php has only whitespace format changes.
|
|\ \ \ \ \ \ |
|
| | | | | | | |
|
|\ \ \ \ \ \ \ |
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
Set logarr as array() per default, default invert to empty string, improve variable representation within strings
|
|\ \ \ \ \ \ \ |
|
| | | | | | | | |
|
| | | | | | | | |
|
| |/ / / / / / |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
pfBlockerNG is going to use lighttpd
This reverts commit c74719cde73c8ce19465e1887f8c519c4818147c.
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
pfBlockerNG is going to use lighttpd
This reverts commit 4bebb56a23658eac8791df7c1a44927e66c6d51c.
|
| | | | | |
| | | | | |
| | | | | | |
Forum: https://forum.pfsense.org/index.php?topic=105448.0
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
inconsistent handling of checkboxes in packages.
|
|\ \ \ \ \ \ |
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
If you manually navigate directly to easyrule.php you get a bit of rubbish text displayed before the actual message about "This is the Easy Rule status page...". That is due to having too many closing PHP tags. Also, fbegin.inc does not need to be included anyway.
I also changed the message to be in a print_info_box() warning and sorted the internationalization a bit more.
There could be a bit more formatting done here after this - the page has a help icon that looks a bit lonely without the other usual panel-heading panel-title stuff.
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
1) Internationalize
2) If there was a problem, then display it with print_info_box() up the top of the page.
3) Redisplay the user-selected IP protocol and source IP after a test. Previously those user selections always got reset to IPv4, any.
4) Remove some useless code that unset($do_traceroute) when it had happily been set to false a little earlier.
5) Remove some useless code that set $host when it had already been set a little earlier.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
NOYB/Status_/_System_Logs_-_Raw_Mode_Search_Inversion
|
| |/ / / /
| | | | |
| | | | |
| | | | | |
Add search inversion to dump_clog and dump_clog_no_table functions for raw mode logs filter.
|
|\ \ \ \ \ |
|
| |/ / / / |
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
renamed get_type to getType
fix capitalisation in getTagName
|
| | | |
| | | |
| | | |
| | | | |
set but empty. Fixes #5775
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
packages.
|
| | | | |
|
| |_|/
|/| | |
|
| | | |
|