| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ |
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Give NAT NPt GUI the same sort of interface as NAT 1:1
1) Checkbox to select multiple mappings and then delete selected
mappings
2) Tick/cross to enable/disable a mapping
3) Ability to "Add a new mapping based on this one"
4) Double-click to edit an entry
5) Ability to reorder mappings and save the new order - probably nobody
cares about that but it is easy to provide it the same as on other
forms, and so users can order the entries as they like.
Note: It used to try to automagically sort the entries based on ipcmp()
of the value of 'external' - that does not work in 2.2.* because
'external' is not a key at all for NPt. So I took that out - seemed more
consistent to provide the user drag-drop entry ordering feature.
Other bits of text in firewall NAT, 1:1 and Out standardized to make all
of them match.
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
Temporarily remove function that broke action icons
|
|\ \ \ |
|
| |/ /
| | |
| | |
| | |
| | | |
1) $iconfn is not the var that contains the 'type' of block or reject.
2) In the bottom if-else of the diff "times-circle" was repeated twice.
3) It seemed odd to me that wen the schedule was out of its time that the icons would always be in "text-danger" color. My suggestion, make them "text-warning" which distinguishes them from the green or red that is shown when the schedule is active.
|
|/ /
| |
| |
| | |
The layer7 condition in the if test for this block was removed when layer7 support was removed in master.
The text of these input error strings also needs to be modified.
|
| | |
|
| |
| |
| |
| | |
and Chromium
|
|/ |
|
| |
|
| |
|
| |
|
|\ |
|
| |
| |
| |
| | |
1) Perform exclusion of non .inc files while reading directory. 2) Be more strict when checking for widget title. 3) We are in the PHP 5.5 age. We can convert certain pieces to anonymous functions and overall better coding.
|
| | |
|
| |
| |
| |
| | |
Save/restore group label on delete row
|
|\ \ |
|
| |/ |
|
|\ \ |
|
| | |
| | |
| | |
| | | |
If you enter invalid stuff in the interface description - e.g. "123" - and press save, then you get a warning about it, but the breadcrumb changes to "Interfaces: 123" - the wrongly entered description (that was not applied).
If you enter a valid string for 'descr' then by this point $wancfg has the new value anyway and so the breadcrumb will change correctly if you make a valid entry in 'descr' and save.
|
| |/
| |
| |
| |
| |
| |
| | |
See https://redmine.pfsense.org/issues/5778 for details of how to reproduce the problem.
Note that similar code to make the "Sorry, an alias with the name XXX already exists" message is also at the top of interfaces.inc - it compares the current interface descr from the config with the currently existing alias names. That check would help warn the user if someone managed to add an alias name that matched the interface name. I guess it was there from some time in the past when the alias edit code did not cross-validate the alias name with the interface descriptions. I have left that check there - it does no harm to have it "just in case".
The new code that I added checks the proposed interface description in $_POST against the existing alias names and will give an input_error if there is a match.
|
|\ \ |
|
| | |
| | |
| | |
| | | |
There was no text appearing when hovering over the Save button, and Save did not actually save the changed rule order.
Make the code the same sort of stuff as in firewall_nat and it works.
|
| |/
| |
| |
| | |
1) The description written when the config was saved said "Outbound" but should be "1 to 1". gettext() it while here.
2) The Delete button had no text displayed when hovering over it - make it like in firewall_nat.
|
|\ \ |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
1) Wrap all the various arrays of text that are displayed to the user in gettext()
2) Give the possibility to translate the singular of words like "host", "network" that get substituted into message strings.
3) Where there are multiple %s in an sprintf() use %$1s %s2s to be really sure, even though it seems to be a case where the order of substitution will never be swapped.
|
| |/
|/| |
|
| | |
|
|/
|
|
| |
when user is editing an alias type that uses the subnet CIDR field as the URL table update frequency.
Forum: https://forum.pfsense.org/index.php?topic=105457.0
|
|
|
|
| |
Address field is used for a wide variety of input types. Including URLs which require a much greater character set acceptance.
|
|\ |
|
| | |
|
| |
| |
| | |
as suggested by @rbgarga
|
| |
| |
| |
| |
| |
| | |
1) The logic of the various tests that determined which messages were displayed was all a bit odd, and there were ways that things could happen and no message was displayed. Now it displays the "warning" information message the first time, and 1 of the 4 possible result messages depending on the result status and if showtest was on.
2) Internationalize - put the gettext() into calls with full sentences and sprintf() wrappers as necessary.
Now I can get each of the 4 possible result messages, and always get a result message.
|
|\ \ |
|
| | | |
|
|\ \ \ |
|
| |/ /
| | |
| | |
| | | |
Note: in the end, edit.php has only whitespace format changes.
|
|\ \ \ |
|
| | | | |
|
|\ \ \ \ |
|
| |/ / /
| | | |
| | | |
| | | | |
Set logarr as array() per default, default invert to empty string, improve variable representation within strings
|
| | | | |
|
| | | | |
|
|/ / / |
|
| | |
| | |
| | | |
Forum: https://forum.pfsense.org/index.php?topic=105448.0
|
| | | |
|