| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
- add missing closing anachor tags
- close input tag correctly
- add missing closing TD tag
- remove invalid ALT
|
|\ \ \ |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Put the real code into print_info_box, adding just a $btntext parameter
to the existing 3 params of print_info_box.
Change the remaining print_info_box_np() calls to use print_info_box()
Note: The previous code also had a "bug" - the "apply" button said
"apply" literally on the UI, when it should have said "Apply changes".
That is fixed so that now the "Apply changes" or other specified button
text is actually displayed to the user. (In the old code it was
literally displaying $name when it should have been $value)
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
|
| | | | |
| | | | |
| | | | | |
I missed this one yesterday - the aim is to get rid of all print_info_box_np soon, if I can.
|
|/ / / /
| | | |
| | | |
| | | | |
Added collapsible action to config backup
|
| |/ /
|/| | |
|
| | |
| | |
| | |
| | | |
gateways selected. Fixes #5424
|
| | | |
|
| | | |
|
|/ / |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show.
3) Delete function print_info_box_np_undo() - nothing calls it.
4) Add new function print_apply_box() to provide an easy wrapper for
print_info_box() with the parameters to be 'warning' level and 'apply'
button.
5) Change print_info_box_np() calls to just print_info_box() or
print_apply_box() as appropriate.
There is 1 direct call to print_info_box_np() from vpn_ipsec_mobile.php
remaining. That tries to make a "create" button. It was not working
before this change. It needs to be sorted out and fixed separately.
After this change there is no dependency on a string containing text
like "apply" to make the apply button appear.
Then we can work on re-engineering the internal code of
print_info_box_np() print_info_box() and print_apply_box() to fit
together however we like. It should be easy to preserving the current
API to print_info_box() and print_apply_box().
|
| |
| |
| |
| | |
hidden for this test, the serial speed selector must still be available.
|
|\ \ |
|
| | | |
|
| | |
| | |
| | |
| | | |
add a user login count option.
|
| | |
| | |
| | |
| | | |
make sure we preserve first part of upgrade after reboot
|
| | |
| | |
| | | |
I might find a few of these while looking at various print_info_block calls, but this one for a start that works well as infoblock blockopen.
|
|\ \ \
| |/ /
|/| | |
|
| | | |
|
| | | |
|
|/ /
| |
| |
| | |
console
|
|\ \ |
|
| | |
| | |
| | | |
This is the quick fix part (1) for https://redmine.pfsense.org/issues/5794
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
Fixes #5795
|
|\ \ \ |
|
| | | | |
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Don't call gettext with an empty title.
There are undoubtedly other places that a check should be done before passing a variable only to a gettext call.
Fixes use case of form group class without a title from passing empty var to gettext.
Gettext returns header info. when an empty string/var is passed.
Perhaps a function should be created for this for consistency.
http://php.net/manual/en/function.gettext.php#108594
For groups without a title gettext returns header info.
To reproduce the issue select a non English language and open any of the following:
Services Load Balancer - edit
Diagnostics - Backup/Restore
Diagnostics - Status SMART
Status - System Logs - log filter and manage log panels
(not a comprehensive list)
|
|\ \ \ |
|
| | | |
| | | |
| | | | |
A few of the entries in this array had dodgy var references. I don't think anything would have caused an actual error.
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fine to spell out 'Destination' here.
1) Field content already has column wide enough.
2) Consistent with firewall log.
3) Already translated.
Return interface abbreviation to it's original uppercase 'IF' to not look so much like the word 'If'.
|
|\ \ \ \ \ |
|
| | |_|/ /
| |/| | |
| | | | |
| | | | | |
When looking at this earlier I never paid attention to the left side of each of these conditions. It is pretty dumb to gettext($_POST['Submit']) and then compare it to gettext("Yes") !!!
This cleans it up so it does just an ordinary comparison - works fine.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
|
| | | | | |
|
|\ \ \ \ \ |
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | | |
I don't really understand why this has to be - the HTML has value="Yes" and value="No" - I thought those would be the strings sent along with "submit".
The translation of Yes and No should have been just for display purposes.
But after this change, I can submit or delete crash reports when the UI isin other languages.
|
|/ / / / |
|
|/ / / |
|