| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
|\ |
|
| | |
|
|\ \ |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
See c24bb3fc80baef04d7b500e18d69c2ada2abdb76 for where this 'if' block was emptied
|
| | |
| | |
| | |
| | | |
Remove closing tag followed by opening tag. Change short_open_tag to full tag and put small instructions on same line.
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | | |
remain evident in the future.
|
| | | | |
|
| |_|/
|/| |
| | |
| | | |
to expand it over and over.
|
| |/
|/|
| |
| | |
rather than blacklist of characters, beef up validation and escaping of related values while here. Fixes #5874 for 2.3
|
| | |
|
| |
| |
| |
| | |
a minimum) and wasn't documented as an available feature so people don't expect to be able to use it.
|
|/ |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out that current CARP implementation is not much different from an IP alias.
This commit converts the IP alias to also use the CARP uniqid scheme, this simplify the code in all other places because now we have only two different cases to deal with:
- A friendly interface name (lan, wan, opt1, etc.);
- A Virtual IP - VIP alias (_vip{$uniqid}) - CARP or IP Alias.
The parent of a CARP is always a friendly interface. The parent of an IP alias can be a friendly interface or a CARP (this is the only case of recursion of a VIP).
This commit removes a few cases where CARP were still considered a interface (the old CARP implementation), fixes all the wrong cases of strpos() being used to detect a VIP address (wont work as it returns '0' which fails when tested as 'TRUE'), review the usage of CARP and IP alias as services bind addresses, fixes general issues of adding and editing VIP addresses.
The following subsystems were affected by this changes:
- IPSEC;
- OpenVPN;
- dnsmasq;
- NTP;
- gateways and gateway groups;
- IPv6 RA;
- GRE interfaces;
- CARP status;
- Referrer authentication.
Fixes (and/or revisit) the following tickets:
- Ticket #3257
- Ticket #3716
- Ticket #4450
- Ticket #4858
- Ticket #5441
- Ticket #5442
- Ticket #5500
- Ticket #5783
- Ticket #5844
|
|\ |
|
| |
| |
| |
| | |
The interface var $if is set to the interface set in the float rule.
|
| | |
|
| | |
|
| |
| |
| |
| | |
Also add config empty test to upgrade script.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
1) Only load the rules of the selected interface instead of loading all the rules of all interfaces and hiding them. Very inefficient and can result in sluggishness. Especially with large number of rules and/or large alias tables.
1.1) Rule separators indexed to their position within their interface so they work with only loading the selected interface rules.
2) Supports consecutive separators.
3) Fixes #5559 - horizontal scrollbar when no rules to display (all hidden). No longer hiding rules.
4) Corrects case where a single rule defined on any interface would prevent the alert messages from being displayed on all interfaces.
|
|\ \
| | |
| | |
| | | |
NOYB/HTML_Compliance_-_VPN_/_IPsec_/_Tunnel_-_Edit_Phase_II
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
Duplicate ID ealgos[].
Duplicate ID halgos[].
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This has also annoyed me, where WAN has a static IP. Every time I go to Services->DHCP I then have to click the LAN tab.
With this change it will look for a "reasonable" tab to go to:
1) The first interface that has DHCP enabled and functional.
2) Otherwise, if LAN is a candidate then choose it (this helps if setting up something when WAN and LAN both have a static IPv4 and there is no DHCP server enabled yet - it will take the user to the LAN tab. That seems sensible, avoiding someone who is not watching accidentally enabling DHCP on WAN)
3) In the unusual case that neither (1) or (2) finds something, then use the original code.
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | | |
See 24fac9b4b803938d403aab6645a3be028f2531d7 for similar change.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
|/ / / /
| | | |
| | | |
| | | | |
Adds an incrementing suffix to service names when there are duplicates
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
NOYB/HTML_Compliance_-_Diagnostics_/_Backup/Restore
|
| | |_|/
| |/| |
| | | |
| | | |
| | | | |
Duplicate ID Submit.
Suppressing unused ID Submit attributes.
|
|\ \ \ \ |
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | | |
1) physmem calculation is already in MiB
2) swapinfo -m actually reports in MiB - good
3) The code that gathers the disk space data already uses "df -h" which reports in IEC units, but the output just has the single char "M", "G" etc. We can always add "iB" here.
As it happens all these numbers are already in powers of 1024 - it just needs the "iB" to be explicitly shown.
|
| |/ /
|/| |
| | |
| | | |
Comparator name was wrong on system_groupmanager_addprivs.php and quotes were missing around the comparator name at system_usermanager_addprivs.php
|
| | |
| | |
| | |
| | | |
The small change I made previously was not all of it - but it did avoid the previous problem by (accidentally) referring to the (undefined) $a_vlan array! I should actually pay more attention to the detail.
This should be even better :)
|