| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
update_config_field() from wizard.php by constructing a variable reference, then set the value using the reference rather than passing user input through eval(). Fixes #7230
|
|
|
|
|
|
| |
parameters can be submitted via POST. Also, remove the JavaScript confirmation box since it is now redundant. Fixes #7228
The confirmation page displays the submitted parameters for an extra user sanity check. Also fixed a bunch of page formatting issues that were not apparent because users rarely if ever saw output from the page.
|
| |
|
| |
|
|
|
|
| |
default.
|
| |
|
|
|
|
| |
#7053
|
| |
|
|
|
|
| |
placeholder with the default while I'm here. Fixes #7034
|
|
|
|
|
|
| |
For numbers greater than 1000 format_number() returns strings formatted like N.NNN K/M/G/T, that get cut to only the integer part if '%d' is used.
(cherry picked from commit ef0e956e48ec1b97a307a546cbc24d00872cde1f)
|
| |
|
|
|
|
| |
code doesn't offer to submit a crash report. A notice is still generated since PHP <7 doesn't yet have error_clear_last(). Fixes #6702
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Expand the types of Form_IpAddress so that the caller can specify
exactly what combination of IPv4, IPv6 address and alias is allowed for
the field.
Set the appropriate input pattern and hover help text.
Only toLowercase() the entered value if it has a ":" in it - i.e. it
looks like it is intended to be an IPv6 address (rather than an IPv4 or
an alias name).
|
|
|
|
|
|
|
| |
As it is no longer relevant, because the code now automatically converts
to lowercase.
(cherry picked from commit 6a54698517430760ddcbc84dd0476046d3926b31)
|
|
|
|
|
|
|
|
|
|
| |
1) As the user leaves the field, or presses Save, onChange will fire and
convert the input string to lowercase. This saves the user havng to even
think about it.
2) Provide some extra text that describes the expected format, to avoid
them getting just "Please match the requested format"
(cherry picked from commit d461ff40e364fc0ecc003b9f673cbad7c6a08f2f)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use case:
1) Edit a gateway that has no advanced settings (i.e. the Advanced section does not need to open on page load) - that works fine.
2) Modify the Gateway IP Address to something invalid like 1:2::z
3) Press Save
The error is shown - "A valid gateway IP address must be specified" - good.
The Advanced section is shown - not good.
The problem is that after POSTing the page, and the resulting validation, finding an input error, and re-displaying the page, each of the $pconfig keys is set, even though set to the empty string "". So the isset() tests are true, and it gets the wrong idea.
We only care about these parameters if they are not "". In this case !empty() gives the correct result, because although a value of 0 will be considered empty, 0 is not allowed by the front-end of the UI anyway (as it happens, these parameters are not allowed to be 0), so we never get that case. And by the way, I generally hate empty() because of having to think of all its quirks.
(cherry picked from commit ebfcfeb59ab4093d6e0d60e95c880d3339e4789d)
|
|
|
|
| |
(cherry picked from commit 2355c154b7598f937ba2121429659f5676ce4d96)
|
|
|
|
|
| |
The front-end validation prevents zero from being entered. "Leave empty" is the way to specify no limit.
(cherry picked from commit b7f2ebb5448f7992cceec899504bdd0a29058fb9)
|
|
|
|
| |
(cherry picked from commit 870b9bc11b993ce8122b448083d29a04bcb30151)
|
|
|
|
|
|
| |
Fix spelling mistake in "system_gateways.php"
(cherry picked from commit 47180823dc0560801085a227abf512e265363b16)
|
| |
|
| |
|
|
|
|
| |
(cherry picked from commit 850c3d8b9352e7467beca8502c24ca8d4fbbbd29)
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Fixed #6759
(cherry picked from commit 1c1f08f92e8841f7282280caeed7613edd810453)
|
| |
|
|
|
|
|
|
| |
narrower terminals as well.
Some views were omitting important info at the narrower width
|
|
|
|
| |
properly respect the timeouts. Ticket #6803
|
|
|
|
| |
(cherry picked from commit 4b0815f38a8a0f98519ca0c2bff7c81b6464e579)
|
|
|
|
| |
(cherry picked from commit 00098bc80b6f85eb74f2f3bc2b4eb7430614110d)
|
|
|
|
| |
this CRL.
|
| |
|
| |
|
| |
|
|
|
|
| |
(cherry picked from commit d38d215d1d9429d3a1a15708f92b14cf3a15b247)
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
as they are already properly considered 'lists of characters' even when not escaped.
(cherry picked from commit 8ea3fd0569ac2b1681de5ba3fbc2a2cc20981ad6)
|
|
|
|
|
|
| |
destination, for both the address and port.
(cherry picked from commit d98e54b215a7798aa0cd9d8432340d6e6df762f5)
|
|
|
|
| |
(cherry picked from commit 0a6ab475d80b580b09fefaf3ca346b08ec6a23c9)
|
| |
|
| |
|
|
|
|
| |
resolving hops. Add note about max ttl/hop limit in source comment. Fixes #6715
|
| |
|
| |
|