| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
(cherry picked from commit 153c3aa61fe65c51d584a57c032a4805048e3062)
|
|
|
|
| |
(cherry picked from commit 98b87cfafe8a890787ca5d22a1089678b9b250ac)
|
| |
|
|
|
|
|
|
| |
No functional change - just making style consistent
(cherry picked from commit 9d3e8723171c727cf43338bd8e95ab2bb7e6a66c)
|
|\ |
|
| |
| |
| |
| | |
Original pull request to master was #2944
|
|/
|
|
|
|
| |
Original commit to master was
https://github.com/pfsense/pfsense/commit/86d431a89d920f64dda5e7e1821f720daf6e067b
|
| |
|
|
|
|
| |
(cherry picked from commit 1c10ce9750f3702f433a91754f79e637e1c3369b)
|
| |
|
|
|
|
|
|
|
|
|
| |
The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required.
It seems to me that there is no harm at all in always using
require_once().
|
|
|
|
|
|
| |
If _POST['members'] or _POST['groups'] is not set / none selected at GUI, it would give a warning on crash reporter (dev versions)
(cherry picked from commit 9f4722022f0e8114741e8cf1a421520fded8be1f)
|
|
|
|
|
|
|
|
|
|
|
| |
Currently if you delete your own user name, then the config ends up with a blank user tag in it. Rather than fix that up, it seems dangerous to be able to delete yourself anyway, because if you are the last user with admin privs for which you know the password (i.e. if you have not recorded the password for "admin" somewhere), then you can lock yourself out. That would require console access to fix, which for some people is a pain.
It seems reasonable to me to make the person login as some other user with admin privs to delete "themselves".
Bit of boots and braces done here:
1) Don't show the trash bin icon for "yourself", and also disable the delete_check checkbox. So you can't opt to delete yourself from the ordinary front-end GUI.
2) Enhance the back-end validation to prevent deleting yourself, just in case someone mucks about in the front-end code.
3) Put error messages to tell people when something is not deleted, and why.
4) In the success message for multi-deletion, tell which user names have actually been deleted.
(cherry picked from commit d6b79c398d16ade9ccd3d21c9574c7a263fc6383)
|
|
|
|
| |
(cherry picked from commit 53c38ff16c1eb8743e69d506f69167c88cf34910)
|
| |
|
|
|
|
|
|
| |
consistently accross different browsers :(
(cherry picked from commit d78dbc34299652c637c77684b7848191c510f9f0)
|
|
|
|
| |
(cherry picked from commit e4c7d45fc7a294817325354e13f4d5bc4987739e)
|
| |
|
|
|
|
| |
Remove "you" personalizations.
|
|
|
|
|
|
| |
As per what was done for https://github.com/pfsense/pfsense/pull/2765 -
do it to the rest of them.
Seems to work OK.
|
|
|
|
|
| |
This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.
|
|
|
|
|
|
| |
The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.
|
|
|
|
|
|
| |
etc). Ticket #5965
Still need to review Advanced buttons and Repeatable block buttons.
|
|
|
|
|
|
| |
Warning: A table row was 4 columns wide and exceeded the column count established by the first row (3).
Error: Stray end tag td.
|
| |
|
| |
|
|
|
|
| |
no longer applicable.
|
|
|
|
| |
The call itself to print_info_box already echoes the content. There is no need of additionally using the short-open-echo tag on those calls to echo return value. The previous implementation shouldn't yell any visible issues as return is 'NULL' (undefined) which casts to an empty string when printing. But, just for the sake of conformity, this changes are advisable in my opinion.
|
|\ |
|
| | |
|
|/
|
|
| |
'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
1) Put the heading "Actions" at the top of all the "Actions" columns -
it was on some and not others.
2) Some more consistent capitalization of panel titles etc.
3) Most interfaces section edit pages had a section titled like "GIF
Configuration", "GRE Configuration". Make them all consistent, e.g.
"QinQ Configuration" rather than "Interface QinQ Edit"...
|
| |
|
| |
|
|
|
|
|
|
| |
instrad of <div id="infoblock"
Just makes more sense to use a class for this
|
| |
|
|
|
|
|
|
|
| |
A table row was 6 columns wide and exceeded the column count established by the first row (5).
End tag div seen, but there were open elements.
Unclosed element form.
Close php tag.
|
|
|
|
| |
Remove unused variable $closehead
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Line 448 "Remove this certificate association? (Certificate will not be deleted)" there was the text "Delete" being displayed and not looking good, in addition to the trash bin icon. Just the trash bin icon seems to be all that is needed.
2) Old line 757 there was a weird-looking "else;" - that seemed to be effectively an empty "else" clause hanging off the end of the "if" block above it. In that case it does nothing and I have removed it.
3) Remove the extra indent of a whole lot of code below old line 757 that actually was not in any "else" clause. This lines it up the way it actually works.
4) Old line 758
$section = new Form_Section('User Certificates');
That made a new $section and chunks of code below it added stuff to the section and then it was thrown away - there was nothing that actually added the section tp the form. That code is similar to what was already above that uses build_cert_table() to make a new Form_StaticText().
So I deleted the code from old line 758 that was functionally useless.
I think it all still works :)
Please review this carefully and make sure I have done good things. The code seemed a bit of a mess to me - maybe it was, or maybe I have no idea!
|
| |
|
|
|
|
| |
was the reason they were added, it was never finished and it's not being used
|
|
|
|
|
|
| |
I think this is the way it should be to make it like everywhere else.
Even when in the "Groups" pages, it is still reached by "System" "User
Manager".
|
| |
|
|\ |
|
| | |
|
|/
|
|
|
| |
Remove the XHTML standard Boolean operators (makes reading HTML much
simpler).
|