| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
|
| |
This has also annoyed me, where WAN has a static IP. Every time I go to Services->DHCP I then have to click the LAN tab.
With this change it will look for a "reasonable" tab to go to:
1) The first interface that has DHCP enabled and functional.
2) Otherwise, if LAN is a candidate then choose it (this helps if setting up something when WAN and LAN both have a static IPv4 and there is no DHCP server enabled yet - it will take the user to the LAN tab. That seems sensible, avoiding someone who is not watching accidentally enabling DHCP on WAN)
3) In the unusual case that neither (1) or (2) finds something, then use the original code.
|
|
|
|
|
| |
1) "Actions" column heading.
2) Make action buttons fa-pencil fa-trash
3) Put a title for each button, so that the "Are you sure you wish to..." popup works nicely.
|
|
|
|
|
|
|
|
|
|
| |
1) For the translators, it should be better to do it consistently. Then
they only need to have 1 translation of "You must apply the changes in
order for them to take effect" and can translate each of the other
custom sentences individually.
2) The full-stop should always go at the end of the sentence, inside the
gettext(). There are some languages where the full-stop is not the same
as European. e.g. In Nepal we use the vertical bar for end of sentence.
|
| |
|
|\ |
|
| | |
|
| | |
|
| |
| |
| |
| | |
Added collapsible action to config backup
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show.
3) Delete function print_info_box_np_undo() - nothing calls it.
4) Add new function print_apply_box() to provide an easy wrapper for
print_info_box() with the parameters to be 'warning' level and 'apply'
button.
5) Change print_info_box_np() calls to just print_info_box() or
print_apply_box() as appropriate.
There is 1 direct call to print_info_box_np() from vpn_ipsec_mobile.php
remaining. That tries to make a "create" button. It was not working
before this change. It needs to be sorted out and fixed separately.
After this change there is no dependency on a string containing text
like "apply" to make the apply button appear.
Then we can work on re-engineering the internal code of
print_info_box_np() print_info_box() and print_apply_box() to fit
together however we like. It should be easy to preserving the current
API to print_info_box() and print_apply_box().
|
| |
| |
| |
| | |
https://forum.pfsense.org/index.php?topic=105654
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
to preserve data. It fixes #5623
|
| |
| |
| |
| |
| | |
Bad character after <. Probable cause: Unescaped <. Try escaping it as <.
Ensure one machine's advskew < 20 (and the other is > 20).
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
The logic here is redundant. It tests IP1<START || IP2<START || IP1>END || IP2>END. *Then* it tests if IP1<IP2 unsigned.
If the latter test succeeds (ie test that first) then IP1>=START *must imply* IP2>=START and IP2<=END *must imply* IP1<=END. In other words we only need to test:
START <= IP1 <= IP2 <= END, ie 3 logic tests (IP1<=IP2 && IP1>=START && IP2<=END) not 5 logic tests.
|
| | |
|
| | |
|
| |
| |
| |
| | |
Remove unused variable $closehead
|
| |
| |
| |
| |
| |
| |
| | |
and use it in services_dhcp rather than trying to do the similar
calculation in-line.
Should fix redmine #5654 and probably a bunch of other things that use
gen_subnet_max
|
| |
| |
| |
| | |
- Close TABLE correctly
|
| | |
|
| |
| |
| |
| | |
was the reason they were added, it was never finished and it's not being used
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
are all pages and the "WebCfg" prefix implies they are pages.
|
| |
| |
| |
| |
| | |
Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.
|
| | |
|
| | |
|
|\ \ |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
- Remove personal copyright from people who assigned it to employer (ESF)
- Remove $Id$
- Remove extra spaces
|
|/ / |
|
| | |
|
|\ \ |
|
| | |
| | |
| | |
| | | |
and I used capitals for DHCP Server.
At the moment there is a mix of capitalisation of this sort of stuff - e.g. there is "DNS forwarder" in various places and "DNS Resolver" and... IMHO these can all be made consistent to have capitals on all the "big" words.
|
|/ / |
|
| | |
|
|/ |
|
|
|
|
| |
'X' button suppressed in info text box
|
| |
|
| |
|
| |
|
|
|
|
| |
All duplicated JS removed to included file
|
| |
|