| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
| |
Clean up some services menu punctuation.
(cherry picked from commit e78ecb9681106889f94b5c7f7b1dbf7b46f54766)
|
|
|
|
| |
It reads as though the interfaces IP address is to be entered. Removing "use" makes it a little clearer.
|
|
|
|
| |
(cherry picked from commit b68e48f20c6ae99786e67372f802d16aacf22de3)
|
|
|
|
|
|
| |
As per what was done for https://github.com/pfsense/pfsense/pull/2765 -
do it to the rest of them.
Seems to work OK.
|
|
|
|
| |
Error: The align attribute on the td element is obsolete. Use CSS instead.
|
|
|
|
|
|
|
|
| |
Before this change, $section is added to $form before btnadvopts is put into $section. The previous code looked to me like btnadvopts would end up in a $section object that got overwritten by the new Form_Section at line 1165.
This change makes sure that the button is added to the section, and then the section is added to the form.
But actually the old code is working OK. (And the new code also works just the same)
So am I missing something?
|
|
|
|
| |
This is the first UI page to be changed so that the Advanced buttons work as specified in Redmine #5994
If this seems like a reasonable way to do it, then I will make similar code for the other UI pages with Advanced buttons.
|
|
|
|
|
| |
This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.
|
|
|
|
|
|
| |
The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
etc). Ticket #5965
Still need to review Advanced buttons and Repeatable block buttons.
|
| |
|
| |
|
| |
|
|\ |
|
| | |
|
| | |
|
| |
| |
| |
| | |
ip2long32() etc
|
| |
| |
| |
| | |
in the DHCP server settings for IPv4. The daemon fails to start when configured in this way, it apparently only allows "allow" or "deny" in failover mode. Fixes #5898
|
|\ \ |
|
| | | |
|
| | |
| | |
| | |
| | | |
'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.
|
| | | |
|
| | |
| | |
| | |
| | | |
'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.
|
|/ / |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
This has also annoyed me, where WAN has a static IP. Every time I go to Services->DHCP I then have to click the LAN tab.
With this change it will look for a "reasonable" tab to go to:
1) The first interface that has DHCP enabled and functional.
2) Otherwise, if LAN is a candidate then choose it (this helps if setting up something when WAN and LAN both have a static IPv4 and there is no DHCP server enabled yet - it will take the user to the LAN tab. That seems sensible, avoiding someone who is not watching accidentally enabling DHCP on WAN)
3) In the unusual case that neither (1) or (2) finds something, then use the original code.
|
| |
| |
| |
| |
| | |
1) "Actions" column heading.
2) Make action buttons fa-pencil fa-trash
3) Put a title for each button, so that the "Are you sure you wish to..." popup works nicely.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
1) For the translators, it should be better to do it consistently. Then
they only need to have 1 translation of "You must apply the changes in
order for them to take effect" and can translate each of the other
custom sentences individually.
2) The full-stop should always go at the end of the sentence, inside the
gettext(). There are some languages where the full-stop is not the same
as European. e.g. In Nepal we use the vertical bar for end of sentence.
|
| | |
|
|\ \ |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
Added collapsible action to config backup
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show.
3) Delete function print_info_box_np_undo() - nothing calls it.
4) Add new function print_apply_box() to provide an easy wrapper for
print_info_box() with the parameters to be 'warning' level and 'apply'
button.
5) Change print_info_box_np() calls to just print_info_box() or
print_apply_box() as appropriate.
There is 1 direct call to print_info_box_np() from vpn_ipsec_mobile.php
remaining. That tries to make a "create" button. It was not working
before this change. It needs to be sorted out and fixed separately.
After this change there is no dependency on a string containing text
like "apply" to make the apply button appear.
Then we can work on re-engineering the internal code of
print_info_box_np() print_info_box() and print_apply_box() to fit
together however we like. It should be easy to preserving the current
API to print_info_box() and print_apply_box().
|
| | |
| | |
| | |
| | | |
https://forum.pfsense.org/index.php?topic=105654
|
| | | |
|
| | | |
|
| | | |
|
| |/
|/|
| |
| | |
to preserve data. It fixes #5623
|
| |
| |
| |
| |
| | |
Bad character after <. Probable cause: Unescaped <. Try escaping it as <.
Ensure one machine's advskew < 20 (and the other is > 20).
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
The logic here is redundant. It tests IP1<START || IP2<START || IP1>END || IP2>END. *Then* it tests if IP1<IP2 unsigned.
If the latter test succeeds (ie test that first) then IP1>=START *must imply* IP2>=START and IP2<=END *must imply* IP1<=END. In other words we only need to test:
START <= IP1 <= IP2 <= END, ie 3 logic tests (IP1<=IP2 && IP1>=START && IP2<=END) not 5 logic tests.
|
| | |
|