| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
| |
I got a bit carried away in the fix for #6460 https://github.com/pfsense/pfsense/commit/21c18c3df11547aba172c10f95872dbd8682f7d9
The message here at line 507 should not actually show the Apply Changes button. At this point the user needs to adjust the assigned interfaces and save. Then after saving an Apply Changes button can be used to implement the saved changes.
|
| |
|
|
|
|
|
|
|
| |
The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required.
It seems to me that there is no harm at all in always using
require_once().
|
| |
|
|
| |
(cherry picked from commit 1322ee22354f1a6e184819fb7009a2996b63de97)
|
| | |
|
| | |
|
| |
|
|
| |
Remove "you" personalizations.
|
| | |
|
| | |
|
| |
|
|
| |
'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.
|
| | |
|
| |
|
|
| |
LAGG to LAGGs to match VLANs, QinQs, etc.
|
| |
|
|
|
|
|
|
|
|
| |
1) For the translators, it should be better to do it consistently. Then
they only need to have 1 translation of "You must apply the changes in
order for them to take effect" and can translate each of the other
custom sentences individually.
2) The full-stop should always go at the end of the sentence, inside the
gettext(). There are some languages where the full-stop is not the same
as European. e.g. In Nepal we use the vertical bar for end of sentence.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show.
3) Delete function print_info_box_np_undo() - nothing calls it.
4) Add new function print_apply_box() to provide an easy wrapper for
print_info_box() with the parameters to be 'warning' level and 'apply'
button.
5) Change print_info_box_np() calls to just print_info_box() or
print_apply_box() as appropriate.
There is 1 direct call to print_info_box_np() from vpn_ipsec_mobile.php
remaining. That tries to make a "create" button. It was not working
before this change. It needs to be sorted out and fixed separately.
After this change there is no dependency on a string containing text
like "apply" to make the apply button appear.
Then we can work on re-engineering the internal code of
print_info_box_np() print_info_box() and print_apply_box() to fit
together however we like. It should be easy to preserving the current
API to print_info_box() and print_apply_box().
|
| |
|
|
|
|
|
|
|
|
|
|
| |
In most situations we want the print_info_box() of $savemsg to be
'success'. If there was some problem saving, then it can be 'warning'.
These are a few places I have found so far that need this sort of fixing
up - more to come but sleep calls just now!
I made the change to index.php also to be consistent with the others,
even though it does not actually change anything "for real" because
'warning' is the default anyway. It will make it easy for people in
future to see that is the case, specially if they are adding other
$savemsg things that need to be 'success'.
|
| |
|
|
| |
A table row was 3 columns wide and exceeded the column count established by the first row (2).
|
| |
|
|
| |
was the reason they were added, it was never finished and it's not being used
|
| | |
|
| |
|
|
|
| |
Remove the XHTML standard Boolean operators (makes reading HTML much
simpler).
|
| |
|
|
| |
are all pages and the "WebCfg" prefix implies they are pages.
|
| |
|
|
| |
Nixed "I/F in button labels (by popular demand)
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
config backup
Resubmit of #1769
|
| | |
|
| | |
|
| |
|
