| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
Remove non-existent help-icon class statements from index and head.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Add configuration option to show or hide special panels.
When a panel is hidden a button is displayed on the page title bar to toggle the panel display.
|
|
|
|
| |
1) Perform exclusion of non .inc files while reading directory. 2) Be more strict when checking for widget title. 3) We are in the PHP 5.5 age. We can convert certain pieces to anonymous functions and overall better coding.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Make all the panel-heading uses also have consistent <h2
class="panel-title"> so they all display the same size.
Forum https://forum.pfsense.org/index.php?topic=105275.0
|
|
|
|
| |
Remove unused modal
|
|
|
|
|
|
|
|
|
|
|
|
| |
In most situations we want the print_info_box() of $savemsg to be
'success'. If there was some problem saving, then it can be 'warning'.
These are a few places I have found so far that need this sort of fixing
up - more to come but sleep calls just now!
I made the change to index.php also to be consistent with the others,
even though it does not actually change anything "for real" because
'warning' is the default anyway. It will make it easy for people in
future to see that is the case, specially if they are adding other
$savemsg things that need to be 'success'.
|
| |
|
|
|
|
|
| |
Removed bogus code that forced system information to be first in the list
Added JS to always add system_information to col 1
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
There is some problem with the var $i getting reset somehow somewhere
related to the include of each widget PHP code. I found that this was
doing $i = 1, $i = 2 and then $i = 2 again and I got fatal errors
because each widget code was being included twice.
Crash report begins. Anonymous machine information:
amd64
10.2-STABLE
FreeBSD 10.2-STABLE #245 1b7c029(devel): Mon Dec 14 04:17:47 CST 2015
root@pfs23-amd64-builder:/usr/home/pfsense/pfsense/tmp/obj/usr/home/pfsense/pfsense/tmp/FreeBSD-src/sys/pfSense
Crash report details:
PHP Errors:
[17-Dec-2015 10:10:50 Asia/Kathmandu] PHP Fatal error: Cannot redeclare
getServerDateItems() (previously declared in
/usr/local/www/widgets/widgets/ntp_status.widget.php:64) in
/usr/local/www/widgets/widgets/ntp_status.widget.php on line 64
[17-Dec-2015 10:10:50 Asia/Kathmandu] PHP Stack trace:
[17-Dec-2015 10:10:50 Asia/Kathmandu] PHP 1. {main}()
/usr/local/www/index.php:0
[17-Dec-2015 10:10:53 Asia/Kathmandu] PHP Fatal error: Cannot redeclare
getServerDateItems() (previously declared in
/usr/local/www/widgets/widgets/ntp_status.widget.php:64) in
/usr/local/www/widgets/widgets/ntp_status.widget.php on line 64
[17-Dec-2015 10:10:53 Asia/Kathmandu] PHP Stack trace:
[17-Dec-2015 10:10:53 Asia/Kathmandu] PHP 1. {main}()
/usr/local/www/index.php:0
[17-Dec-2015 10:11:27 Asia/Kathmandu] PHP Fatal error: Cannot redeclare
getServerDateItems() (previously declared in
/usr/local/www/widgets/widgets/ntp_status.widget.php:64) in
/usr/local/www/widgets/widgets/ntp_status.widget.php on line 64
[17-Dec-2015 10:11:27 Asia/Kathmandu] PHP Stack trace:
[17-Dec-2015 10:11:27 Asia/Kathmandu] PHP 1. {main}()
/usr/local/www/index.php:0
|
|\ \
| | |
| | |
| | | |
NOYB/HTML_Compliance_-_Dashboard_-_Widget_Config_Panel
|
| |/
| |
| |
| |
| |
| |
| |
| | |
Bad value #widget-system_information .panel-footer for attribute href on element a: Illegal character in fragment: not a URL code point.
Fix the widget config/wrench icon href.
Add matching widgetname id tag to widgets configuration panel div element.
Note: Thermal Sensors widget config panel already had a different id tag. Couldn't find anything that referenced it though. If that is correct then it should be safe to change it to widgetname to be consistent with the other widgets.
|
|/
|
|
|
|
|
|
|
| |
Rename duplicate id's.
Fix available widgets collapsible section href with id.
Where obsolete replace name attribute with id.
The .panel-footer requires mod to the widgets with config options. So will submit separate commit so it can be handled independently.
Bad value #widget-system_information .panel-footer for attribute href on element a: Illegal character in fragment: not a URL code point.
|
|
|
| |
Couple of little bits here.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
because it broke all of the widget configuration actions.
|
|
|
|
| |
was the reason they were added, it was never finished and it's not being used
|
| |
|
|
|
|
|
|
|
|
| |
HTML compliance (aside from the active widgets).
Rename duplicate id's.
Fix available widgets collapsible section href with id.
Where obsolete replace name attribute with id.
|
|
|
|
|
|
|
|
|
|
| |
Each widget has an include file that already has the required widget
title in a var like $dyn_dns_status_title $carp_status_title etc.
Use that var to set the displayed title of the widget, rather than the
stuff that was capitalizing the file name and then having a list of
special cases...
This meant the loop that includes the widget include files had to be
moved higher up in the code.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
collapsable in the same way that dashboard widgets are.
Currently used on diag_logs_filter.php ONLY
|
| |
|
|
|
|
| |
are all pages and the "WebCfg" prefix implies they are pages.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
I am not sure how else to do this. If someone in future writes a widget about "Smart Carp" (an intelligent species of fish) then it will get turned into "SMART CARP". The other strings are not English words, or parts of English words, so not likely to be matched wrongly in future.
Note 1: The redmine issue also mentions changing "Dyn DNS Status" to "Dynamic DNS Status". For that reason I put a special entry to change any "dyn dns" to "Dynamic DNS". I also put the "dns" to "DNS" in case there are ever any other occurrences of "dns" in other widget names that would need to be changed to "DNS".
Note 2: "gmirror" to "gmirror" is not a mistake. str_ireplace() is case-insensitive. So this will replaces stuff like "Gmirror" with "gmirror".
Note 3: None of this stuff has gettext() translation support. But it did not in 2.2.* either. That is something else for future thought - how to take text that is generated from file names found at run-time and give translators a chance to translate it.
|
|
|
|
| |
These were wrong. But actually I don't think any widgets use this mechanism of $config['widgets']['mywidget-config'] - they seem to do their own thing making names for the keys they use in $config['widgets'] to store their settings. So I didn't find anything actually broken because of this.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|