| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The last test here looks not good having just a single equals sign - if the interpreter evaluates this then $class will always get set to 'info'.
In practice it should work OK, because the evaluation of boolean conditions left to right should stop when any of the other tests to the left evaluates false. So $class will only be set to 'info' if it is not already 'default' 'danger' or 'warning'.
Actually the code could be:
a) Obfuscated version with empty if block content:
if ($class != 'default' && $class != 'danger' && $class != 'warning' && $class = 'info') {
// Noop - the if test above has already set $class to 'info' as required.
}
or
b) Clearer version without bothering with any test for $class != 'info' :
if ($class != 'default' && $class != 'danger' && $class != 'warning') {
$class = 'info';
}
|
|\
| |
| |
| |
| | |
* 'patch-9' of https://github.com/k-paulius/pfsense:
Stop generating page-header instead of hiding it. With breadcrumbs introduces it no longer serves any useful purpose.
|
| |
| |
| |
| | |
introduces it no longer serves any useful purpose.
|
|/ |
|
| |
|
| |
|
| |
|
|
|
|
| |
will know what happeded
|
|
|
|
|
|
|
|
|
|
|
|
| |
Put the real code into print_info_box, adding just a $btntext parameter
to the existing 3 params of print_info_box.
Change the remaining print_info_box_np() calls to use print_info_box()
Note: The previous code also had a "bug" - the "apply" button said
"apply" literally on the UI, when it should have said "Apply changes".
That is fixed so that now the "Apply changes" or other specified button
text is actually displayed to the user. (In the old code it was
literally displaying $name when it should have been $value)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show.
3) Delete function print_info_box_np_undo() - nothing calls it.
4) Add new function print_apply_box() to provide an easy wrapper for
print_info_box() with the parameters to be 'warning' level and 'apply'
button.
5) Change print_info_box_np() calls to just print_info_box() or
print_apply_box() as appropriate.
There is 1 direct call to print_info_box_np() from vpn_ipsec_mobile.php
remaining. That tries to make a "create" button. It was not working
before this change. It needs to be sorted out and fixed separately.
After this change there is no dependency on a string containing text
like "apply" to make the apply button appear.
Then we can work on re-engineering the internal code of
print_info_box_np() print_info_box() and print_apply_box() to fit
together however we like. It should be easy to preserving the current
API to print_info_box() and print_apply_box().
|
| |
|
|
|
|
| |
console
|
|
|
| |
This is the quick fix part (1) for https://redmine.pfsense.org/issues/5794
|
| |
|
|
|
|
| |
Set logarr as array() per default, default invert to empty string, improve variable representation within strings
|
|
|
|
| |
Add search inversion to dump_clog and dump_clog_no_table functions for raw mode logs filter.
|
| |
|
|
|
| |
$d_sysrebootreqd_path seems to be a leftover from some ancient group of global $d_* vars that are no longer used.
|
|
|
|
| |
Move getGETPOSTsettingvalue function to be more centrally located in guiconfig.inc.
|
|
|
|
|
| |
As per "http://getbootstrap.com/css/#type-alignment", use CLASS
statement instead in inline STYLE statement (much tidier)
|
|
|
|
|
|
| |
and didn't end up working out.
It buffered writes too long, users could never see the most current log data.
|
|
|
|
| |
was the reason they were added, it was never finished and it's not being used
|
| |
|
|
|
|
| |
warnings 'Failed to set locale'
|
| |
|
|
|
|
|
|
|
| |
Build up th manage log section with options to override the "General Logging Options" settings on an individual log basis.
Remove over exuberant gettext's.
Set/adjust filter form field widths to be better fitting for the field types.
Open/Close filter form based on filtering state.
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
https://github.com/NOYB/pfsense
* 'Status-System_Logs-Firewall-Filter' of https://github.com/NOYB/pfsense:
Revert "gettext it up"
gettext it up
Src & Dst port fields as number breaks regex.
Fix filter button.
Status-System Logs-Firewall-Filter
|
| |
| |
| |
| |
| |
| |
| | |
Spruce it up.
Use the cool filter button.
Use the cool clear button.
Add no logs to display notice.
|
|/ |
|
|
|
|
|
| |
Remove the XHTML standard Boolean operators (makes reading HTML much
simpler).
|
|
|
|
|
| |
Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
timezone on pkg_mgr_installed.php
|
| |
|
| |
|
| |
|
|
|
|
| |
Refactor row toggle javascript
|
| |
|
| |
|
| |
|
|
|
|
| |
COnverted pop-up format to table and added description
|