| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
| |
The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required.
It seems to me that there is no harm at all in always using
require_once().
|
| |
|
|
|
|
|
| |
The info box displayed on Firewall->Shaper, By Interface come down the bottom with and info icon and can be shown/hidden by the user.
The similar info box on Firewall->Shaper, Limiters sits in the main body with no info icon and cannot be shown/hidden, but can be dismissed.
Make the info box on Firewall->Shaper, Limiters dispaly and owrk the same as on "By Interface".
(cherry picked from commit a79dfdaa431d4f647fbcbaf63a5c55f081b2edc2)
|
| |
|
|
| |
(cherry picked from commit c3ebf3470402080bbddb709325611e7120eb3c0f)
|
| |
|
|
|
|
| |
NOYB/Firewall_/_Traffic_Shaper_-_Remove_Personalizations
(cherry picked from commit 7f824121528288fdcc493f36da25c61982f4e320)
|
| | |
|
| |
|
|
|
| |
This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.
|
| |
|
|
|
|
| |
The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.
|
| | |
|
| |
|
|
|
|
| |
etc). Ticket #5965
Still need to review Advanced buttons and Repeatable block buttons.
|
| |
|
|
| |
'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.
|
| |
|
|
| |
more consistent.
|
| |
|
|
|
|
|
|
|
|
| |
1) For the translators, it should be better to do it consistently. Then
they only need to have 1 translation of "You must apply the changes in
order for them to take effect" and can translate each of the other
custom sentences individually.
2) The full-stop should always go at the end of the sentence, inside the
gettext(). There are some languages where the full-stop is not the same
as European. e.g. In Nepal we use the vertical bar for end of sentence.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show.
3) Delete function print_info_box_np_undo() - nothing calls it.
4) Add new function print_apply_box() to provide an easy wrapper for
print_info_box() with the parameters to be 'warning' level and 'apply'
button.
5) Change print_info_box_np() calls to just print_info_box() or
print_apply_box() as appropriate.
There is 1 direct call to print_info_box_np() from vpn_ipsec_mobile.php
remaining. That tries to make a "create" button. It was not working
before this change. It needs to be sorted out and fixed separately.
After this change there is no dependency on a string containing text
like "apply" to make the apply button appear.
Then we can work on re-engineering the internal code of
print_info_box_np() print_info_box() and print_apply_box() to fit
together however we like. It should be easy to preserving the current
API to print_info_box() and print_apply_box().
|
| | |
|
| |
|
|
| |
Define the 'success' 'info' etc style of calls to print_info_box()
|
| | |
|
| |
|
|
|
|
|
| |
1) When you click to add a new limiter or new queue, then the "Add new queue" button is displayed down the bottom. That is dumb - you are already adding and actually you need to enter the data and save first before adding something else.
2) When you are adding something (like in (1)) the Delete button is displayed. That is also dumb - there is nothing to delete until you have pressed save to add it!
3) When clicking on a Limiter at the top of the tree, the Delete button says "Delete this queue", but it is the top level limiter that is being edited and could be deleted, The $_GET/$_POST that happens sends "pipe" and "queue" both with the name of the top-level limiter. So in the end $queue always exists. So we only want the text "Delete this queue" if $queue exists and the queue name is NOT the same as the pipe name.
Note: These issues are also in 2.2.6 - see https://github.com/pfsense/pfsense/pull/2362 for the changes to fix in RELENG_2_2.
|
| |
|
|
|
|
| |
As far as I can see this URL should be self-referring - to firewall_shaper_vinterface.php
But I am having trouble finding how to test it, because whenever $pipe is set, so is $queue so I never get down the "else".
Anyway, this seems an obvious fix, and there might be other stuff related to when creating a limiter as distinct from a queue inside that limiter.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Remove unused variable $closehead
|
| | |
|
| |
|
|
| |
was the reason they were added, it was never finished and it's not being used
|
| | |
|
| |
|
|
|
|
| |
Tidy up coding style
Add PROPERTY statement to LINK tag
Remove self closing statement from ANCHOR tag
|
| | |
|
| |
|
|
| |
are all pages and the "WebCfg" prefix implies they are pages.
|
| |
|
|
|
| |
Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.
|
| | |
|
| |
|
|
|
|
| |
- Remove personal copyright from people who assigned it to employer (ESF)
- Remove $Id$
- Remove extra spaces
|
| | |
|
| | |
|
| | |
|
| |\ |
|
| | | |
|
| |/ |
|
| | |
|
| |
|
