| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
generate invalid ruleset. Ticket #6265
|
|
|
|
|
|
|
| |
1) Remove a couple of unused calls to is_specialnet()
2) Change srctype_selected() to use a similar scheme to dsttype_selected() to decide if the existing value matches one of the dropdown list items.
3) Items like "WAN net" and "LAN net" in the src type dropdown were showing as just "WAN" and "LAN" in the dst type dropdown. Fixup the build_dsttype_list() code so it does the same as build_srctype_list() when making the text for those interface networks.
(cherry picked from commit 74ac8b7aeb1cf08dbbcb3baff9c7b97abbe98858)
|
|
|
|
|
| |
is_specialnet() was only using a smaller list of "special nets", so when you have a VIP as the selected special destination it was not matching it up on edit, and thus "forgetting" the special VIP selection.
build_dsttype_list() already makes a good list of special destination types. That list includes all the "special" VIPs.
|
|
|
|
|
|
| |
Some punctuation clean up.
(cherry picked from commit 4a75d129df0c6eee2540d885c951e9ae72a0ed5e)
|
| |
|
|
|
|
| |
(cherry picked from commit 4012d55c028ca1c4d449e7b80ba738d4dd5b2976)
|
|
|
|
|
|
| |
As per what was done for https://github.com/pfsense/pfsense/pull/2765 -
do it to the rest of them.
Seems to work OK.
|
| |
|
|
|
|
| |
Initilize element before refreshing
|
|
|
|
|
| |
1) Standardize the way the Advanced button works to display and hide the source address/port fields.
2) Remove dstenable boolean - it was always set to 1 (true) and so all the tests that used it were meaningless.
3) Use true and false for portsenabled var rather than 1 and 0 - easier to read/understand.
|
|
|
|
|
| |
This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.
|
|
|
|
|
|
| |
The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.
|
| |
|
| |
|
|
|
|
| |
On NAT Port Forward Edit, if any of the source port settings are different to the defaults then display the source fields, rather than just the Advanced button.
Otherwise when editing a NAT port forward with source address/port settings, it is not obvious to the user that there are existing source settings "hiding" under the Advanced button.
|
| |
|
|
|
|
| |
Consolidate the moving of separators for add/copy/dup/delete into a generic function.
|
| |
|
|
|
|
| |
inserted above a separator bar location
|
| |
|
|
|
|
|
|
| |
applied to other pages
Separators added to firewall_nat.php
|
| |
|
|
|
|
|
|
|
|
|
| |
Fix port aliases (Seems you can't autosuggest an element of type "number")
Also
apply to src too.
remove is_numeric check
remove min/max (not valid on text fields; does not work)
add pattern in place of min/max
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Attribute min/max not allowed on element input at this point.
<input class="form-control" name="srcbeginport_cust" id="srcbeginport_cust" type="text" value="any" min="1" max="65536">
<input class="form-control" name="srcendport_cust" id="srcendport_cust" type="text" value="any" min="1" max="65536">
Attribute min/max not allowed on element input at this point.
<input class="form-control" name="dstbeginport_cust" id="dstbeginport_cust" type="text" value="any" min="1" max="65536">
<input class="form-control" name="dstendport_cust" id="dstendport_cust" type="text" value="any" min="1" max="65536">
Attribute min/max not allowed on element input at this point.
<input class="form-control" name="localbeginport_cust" id="localbeginport_cust" type="text" min="1" max="65536">
|
| |
|
| |
|
|
|
|
| |
Remove unused variable $closehead
|
|
|
|
| |
was the reason they were added, it was never finished and it's not being used
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
are all pages and the "WebCfg" prefix implies they are pages.
|
|
|
|
|
| |
Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.
|
|\ |
|
| |
| |
| |
| | |
If null is passed for the text to go after the checkbox, then the checkbox does not line up nicely on the page with the other items above and below it. If some text (or even the empty string) is passed then the lineup is all good.
In this case it seems reasonable to put some text here, like is done higher up for "Disable" and "No RDR" checkboxes.
|
|/ |
|
|
|
|
| |
And make the "not" checkboxes have the same layout as in firewall_rules_edit. That seems a better place to put the checkbox and consistency between similar GUI screens seems a good thing.
|
| |
|
|
|
|
| |
Mostly when dealing with enc0 interface.
|
|
|
|
|
|
| |
- Remove personal copyright from people who assigned it to employer (ESF)
- Remove $Id$
- Remove extra spaces
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
javascript/pfSenseHelpers.js created and populated with common hide/show/disable/enable functions
file included via foot.inc
Those functions removed from firewall_nat_edit.php to test
|
|
|
|
| |
Incorrect element name used
|
| |
|
|
|
|
|
|
|
| |
- Remove PPTP server and all related code
- Bump config version 12.2
- Write upgrade config code to remove pptpd section and also cleanup
firewall and NAT rules using PPTP interface or src/des
|