| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| | |
|
|/
|
|
|
|
|
| |
1) Strictly keep track of the accumulating $retval from calls to various
functions that apply changes.
2) Use new function print_apply_result_box() to print a suitable message
in a suitable severity based on $retval
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required.
It seems to me that there is no harm at all in always using
require_once().
|
| |
|
|\
| |
| |
| | |
NOYB/Firewall_NAT_-_Remove_Pencil_Icon_From_Aliases
|
| | |
|
| |
| |
| |
| | |
Don't see the icon adding any value. Consumes space and clutters page. Make consistent with the firewall rules page.
|
|/
|
|
| |
Replace underscore with space in display text of certain fields to allow them to line wrap. ex: long alias names
|
|
|
|
| |
Remove "you" personalizations.
|
|
|
|
| |
(no rdr). Ticket #5965
|
|
|
|
| |
Consolidate the moving of separators for add/copy/dup/delete into a generic function.
|
|
|
|
| |
Use a list of separator rows to call the display separator function only for rows which there are separator(s). More efficient than looping through the list of separators on every row.
|
| |
|
|
|
|
| |
Also add config empty test to upgrade script.
|
|
|
|
| |
1) Undo typos in sasl.inc. 2) Remove unused code from CSS. 3) Correct typos in some comments. 4) Convert short_open_tag to full tags. 5) Make 'else' block look like the others.
|
|
|
|
|
|
| |
applied to other pages
Separators added to firewall_nat.php
|
|
|
|
|
| |
These pages use the draggable/sortable rows stuff, so could use the same
warning message if the user tries to change page before saving
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show.
3) Delete function print_info_box_np_undo() - nothing calls it.
4) Add new function print_apply_box() to provide an easy wrapper for
print_info_box() with the parameters to be 'warning' level and 'apply'
button.
5) Change print_info_box_np() calls to just print_info_box() or
print_apply_box() as appropriate.
There is 1 direct call to print_info_box_np() from vpn_ipsec_mobile.php
remaining. That tries to make a "create" button. It was not working
before this change. It needs to be sorted out and fixed separately.
After this change there is no dependency on a string containing text
like "apply" to make the apply button appear.
Then we can work on re-engineering the internal code of
print_info_box_np() print_info_box() and print_apply_box() to fit
together however we like. It should be easy to preserving the current
API to print_info_box() and print_apply_box().
|
|
|
|
| |
Provide the rule enable/disable toggle like in NAT 1:1 and NAT NPt
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Give NAT NPt GUI the same sort of interface as NAT 1:1
1) Checkbox to select multiple mappings and then delete selected
mappings
2) Tick/cross to enable/disable a mapping
3) Ability to "Add a new mapping based on this one"
4) Double-click to edit an entry
5) Ability to reorder mappings and save the new order - probably nobody
cares about that but it is easy to provide it the same as on other
forms, and so users can order the entries as they like.
Note: It used to try to automagically sort the entries based on ipcmp()
of the value of 'external' - that does not work in 2.2.* because
'external' is not a key at all for NPt. So I took that out - seemed more
consistent to provide the user drag-drop entry ordering feature.
Other bits of text in firewall NAT, 1:1 and Out standardized to make all
of them match.
|
| |
|
|
|
|
|
|
| |
Make all the panel-heading uses also have consistent <h2
class="panel-title"> so they all display the same size.
Forum https://forum.pfsense.org/index.php?topic=105275.0
|
| |
|
| |
|
| |
|
|
|
|
| |
Remove unused variable $closehead
|
|
|
|
| |
was the reason they were added, it was never finished and it's not being used
|
| |
|
|
|
|
| |
COnfirmation is automatically added to fa-trash icon, so explicit on-click is no longer required
|
|\ |
|
| | |
|
|/
|
|
|
| |
Remove the XHTML standard Boolean operators (makes reading HTML much
simpler).
|
| |
|
|
|
|
| |
are all pages and the "WebCfg" prefix implies they are pages.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
- Remove personal copyright from people who assigned it to employer (ESF)
- Remove $Id$
- Remove extra spaces
|
| |
|
| |
|
| |
|