| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| | |
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
1) Lookup a name with Diag DNS
2) Press "Add Alias"
The alias is added, but the button still says "Add Alias".
Actually the alias exists by now. The button should say "Update Alias".
Fix: once we have emitted the alias create/update success message, we can set $alias_exists true so that the rest of the code is based on the (possibly new) state.
|
|\ \ |
|
| |/ |
|
|/ |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After testing diag_dns behaviour some regressions have been noticed.
1) Looking up ipv6.google.com (it only has AAAA records) doesn't work
- gethostbyname() only supports v4, ipv6.google.com only has v6
- this bug was recently and inadvertently introduced
2) Results table will always show even when domain is not resolved
- since refactoring ages ago, $resolved is an array, bad idea to replace with a string, this will cause issues
- this piece of code was 'dead' until the recent commit has 'enabled' it again, removing it as not needed
3) Parameters for display_host_results (see: fe74228f2a8a9abc45a580a01559518043ca8d0b for its introduction) weren't correctly updated
- mostly a dead function, doubt this is used for anything, keeping it just in case.
This commit fixes all aforementioned issues.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Do not call resolve_host_addresses() when hostname cannot be resolved
by gethostbyname(). The old check was considering gethostbyname would
return NULL in this case but it returns a string with the hostname
passed on parameter
- Since resolve_host_addresses() always return an array, look for the
first A record to set $ipaddr, which will be used later to link with
IP WHOIS and IP Info
Based on Pull Request #3100 submitted by @NewEraCracker
|
| |
|
| |
|
|
|
|
| |
No functional change - just making style consistent
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
lookup rather than update alias. semi-related to Ticket #6561
|
|\ |
|
| | |
|
|/
|
|
|
|
|
|
|
| |
The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required.
It seems to me that there is no harm at all in always using
require_once().
|
|\ |
|
| |
| |
| |
| |
| |
| | |
If I resolve a CNAME with diag_dns, it gives back the translated FQDNs - e.g. www.inf.org translates to inf.org. Then press "Add Alias".
Problem: The existing code puts a "/32" CIDR after that in the alias "www_inf_org" in the config - "inf.org./32" - and if you then edit the "www_inf_org" alias it shows as "inf.org./32" in the Network or FQDN Address field. Normally when putting an FQDN into an alias, no CIDR is inserted.
This change fixes it.
|
|/
|
|
| |
See Redmine #6077
This seems the easy and reasonable thing to do. Make the button text reflect what is going to happen "Add alias" or "Update alias". Then the backend code can just either create a new alias or overwrite an existing one.
|
|
|
|
| |
Ticket #6075
|
| |
|
|
|
|
|
| |
This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.
|
|
|
|
|
|
| |
The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.
|
|
|
|
|
|
| |
etc). Ticket #5965
Still need to review Advanced buttons and Repeatable block buttons.
|
|
|
|
| |
'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.
|
| |
|
|
|
|
| |
'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Short version is far more used than long php echo. This brings all code to same standard where possible.
|
| |
|
|
|
|
|
|
| |
Short open tag is discouraged since it is only available if enabled
See https://secure.php.net/manual/en/language.basic-syntax.phptags.php
|
|
|
|
| |
was the reason they were added, it was never finished and it's not being used
|
| |
|
| |
|
|
|
|
| |
are all pages and the "WebCfg" prefix implies they are pages.
|
| |
|
|
|
|
|
| |
Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.
|
|
|
|
| |
interface=wan could be offline/disabled in multi-wan systems.
also, currently no code in diag_ping.php to convert 'wan' => source-ip
|
|\ |
|