| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
(cherry picked from commit a66177645191359e5ce854d733e9be40ada3535b)
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Add alias and host types to Form_IpAddress with the appropriate hover
text.
2) Remove the patterns - the UI of those is not so effective anyway, so
leave the validation of input to the back end.
3) Update uses of Form_IpAddress to use the appropriate Alias or Host
type as needed.
4) Remove explicit setPattern() from those uses of Form_IpAddress.
(cherry picked from commit 45541aae63596ea28aa18c84b65946bce6adbffd)
|
|
|
|
|
|
|
| |
When requiring the entry of an IPv6 address, the regex pattern should still allow a dot, so that an IPv6 address can be entered in the format that has an IPv4-address-like part at the end:
aa:bb:cc:dd:ee:ff:1.2.3.4
which is a valid way to choose to specify an IPv6 address.
(cherry picked from commit b8678b6385a9ba245e92a06b19cfa397873eef77)
|
|
|
|
|
|
| |
This reverts commit d461ff40e364fc0ecc003b9f673cbad7c6a08f2f.
(cherry picked from commit 75bc87fe10f30f49a09218820f7bb59e859cb6bb)
|
|
|
|
|
|
| |
This reverts commit 9444a281f051e11d5456cc37b2a3f56fc8a7bc33.
(cherry picked from commit 9128641db5c9b6839163948f3f71ad139c7a4625)
|
|
|
|
|
|
|
|
|
|
| |
Expand the types of Form_IpAddress so that the caller can specify
exactly what combination of IPv4, IPv6 address and alias is allowed for
the field.
Set the appropriate input pattern and hover help text.
Only toLowercase() the entered value if it has a ":" in it - i.e. it
looks like it is intended to be an IPv6 address (rather than an IPv4 or
an alias name).
|
|
|
|
|
|
|
| |
As it is no longer relevant, because the code now automatically converts
to lowercase.
(cherry picked from commit 6a54698517430760ddcbc84dd0476046d3926b31)
|
|
|
|
|
|
|
|
|
|
| |
1) As the user leaves the field, or presses Save, onChange will fire and
convert the input string to lowercase. This saves the user havng to even
think about it.
2) Provide some extra text that describes the expected format, to avoid
them getting just "Please match the requested format"
(cherry picked from commit d461ff40e364fc0ecc003b9f673cbad7c6a08f2f)
|
| |
|
|
|
|
|
|
| |
No functional change - just making style consistent
(cherry picked from commit 9d3e8723171c727cf43338bd8e95ab2bb7e6a66c)
|
|
|
|
| |
(cherry picked from commit 0ed3b15981b4451efb11839d6ee7b9acf1ed1d84)
|
|
|
|
|
|
|
|
|
|
| |
1) If a checkbox does not have a description (even if it is empty), layout will be broken as checkbox won't be aligned correctly
2) UPnP checkbox looks better with description instead of help
This commit fixes the two issues
(cherry picked from commit 1a8e5f2f67fdc18080eeac47dc4ed0bdfacc66b9)
|
|
|
|
| |
(cherry picked from commit 9ce54773be5e02235e3be7d2b970f61fbb27ba86)
|
| |
|
| |
|
| |
|
|
|
|
|
| |
It seems to me that a through f should not be part of the pattern for the "V4" case.
(cherry picked from commit 1f49dd8a3a49b724ded5840c1db6c168ed466aae)
|
|
|
|
|
|
| |
Apparently gettext() does not behave correctly when passed an empty string, this commit ensures gettext() is called only with non-empty strings
(cherry picked from commit 6ae99aba5cab12440d88dd9ddaa6535c3b9b5d82)
|
|
|
|
|
|
| |
this case it is specified as "V6".
(cherry picked from commit 3e4adb7139b4cddbb06a2aba7e0727d1762b35ee)
|
|
|
|
|
|
|
|
| |
This limit is set at 4096 on PHP 5.6: http://lxr.php.net/xref/PHP_5_6/ext/gettext/gettext.c#139
Bug report on forum: https://forum.pfsense.org/index.php?topic=110088.0
(cherry picked from commit 95f46512d9410b38b23d7778cec0bf8610e448cf)
|
|
|
|
| |
(cherry picked from commit 54fc9503ff550d04d1253c41c1fd49da1b64c07e)
|
| |
|
|
|
|
|
| |
Note: This will cause a problem for some code that does comparisons expecting this text to be exactly the string 'Save'. If the user has selected a different language then the button text will be translated and thus will be some different text.
That is discussed in forum https://forum.pfsense.org/index.php?topic=108116.0
I will followup with another pull request to fix the things I can find like that.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't call gettext with an empty title.
There are undoubtedly other places that a check should be done before passing a variable only to a gettext call.
Fixes use case of form group class without a title from passing empty var to gettext.
Gettext returns header info. when an empty string/var is passed.
Perhaps a function should be created for this for consistency.
http://php.net/manual/en/function.gettext.php#108594
For groups without a title gettext returns header info.
To reproduce the issue select a non English language and open any of the following:
Services Load Balancer - edit
Diagnostics - Backup/Restore
Diagnostics - Status SMART
Status - System Logs - log filter and manage log panels
(not a comprehensive list)
|
|
|
|
| |
and Chromium
|
|
|
|
| |
inconsistent handling of checkboxes in packages.
|
|
|
|
|
| |
renamed get_type to getType
fix capitalisation in getTagName
|
|
|
|
| |
packages.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
The name attribute is obsolete. Consider putting an id attribute on the nearest container instead.
The <a> name attribute is not supported in HTML5. Use the id attribute instead.
|
|
|
|
| |
but it might as well work just in case.
|
| |
|
| |
|
|
|
|
| |
Added new functionality to PHP classes, and used it ONLY in system_advanced_notifications.php -> smtp password
|
| |
|
|\ |
|
| |
| |
| |
| |
| | |
This is a combined version of:
https://github.com/pfsense/pfsense/pull/2310
https://github.com/pfsense/pfsense/pull/2315
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| | |
Attribute placeholder not allowed on element select at this point.
Attribute placeholder is only allowed when the input type is email, number, password, search, tel, text, or url.
|
| |
| |
| |
| | |
Use setCols() to override
|
| |
| |
| |
| | |
attribute to take effect. Required bu pkg_edit.php and by wizards
|
| | |
|
| | |
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Touch Screen Usability Annoyance
https://forum.pfsense.org/index.php?topic=104135.0
Clicking the labels in the left column selects/activates the first item. This is the perfectly natural place for scrolling with thumb.
No big problem really for input fields, but check boxes and buttons are inadvertently selected/toggled resulting in unintended configuration changes.
Would be real nice if the labels in the left column were not "active".
This commit provides an option in System - General Setup page to enable/disable this "feature".
There is probably a better way, but this appears to be functional. For now at least it seems to work for me anyway. Just have to eliminate (null) the for attribute on the group labels so it doesn't have a target.
|
| |
| |
| |
| | |
The for attribute of the label element must refer to a non-hidden form control.
|