| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out that current CARP implementation is not much different from an IP alias.
This commit converts the IP alias to also use the CARP uniqid scheme, this simplify the code in all other places because now we have only two different cases to deal with:
- A friendly interface name (lan, wan, opt1, etc.);
- A Virtual IP - VIP alias (_vip{$uniqid}) - CARP or IP Alias.
The parent of a CARP is always a friendly interface. The parent of an IP alias can be a friendly interface or a CARP (this is the only case of recursion of a VIP).
This commit removes a few cases where CARP were still considered a interface (the old CARP implementation), fixes all the wrong cases of strpos() being used to detect a VIP address (wont work as it returns '0' which fails when tested as 'TRUE'), review the usage of CARP and IP alias as services bind addresses, fixes general issues of adding and editing VIP addresses.
The following subsystems were affected by this changes:
- IPSEC;
- OpenVPN;
- dnsmasq;
- NTP;
- gateways and gateway groups;
- IPv6 RA;
- GRE interfaces;
- CARP status;
- Referrer authentication.
Fixes (and/or revisit) the following tickets:
- Ticket #3257
- Ticket #3716
- Ticket #4450
- Ticket #4858
- Ticket #5441
- Ticket #5442
- Ticket #5500
- Ticket #5783
- Ticket #5844
|
|
|
|
| |
download fails. Return would always evaluate to true previously though other parts of the code expect a false value when a download fails. related to Ticket #5848
|
| |
|
|
|
|
|
|
| |
- Remove parameters from set_language()
- Add a global variable for default language
- add env var for LANG, otherwise it won't work
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bad value 200000↩ for attribute placeholder on element input: Line feed not allowed.
<input class="form-control" name="maximumtableentries" id="maximumtableentries" type="text" placeholder="200000↩">
Element ul not allowed as child of element span in this context.
Contexts in which element ul may be used:
Where flow content is expected.
Content model for element span:
Phrasing content.
Close div tag
Close php tag
|
| |
|
|
|
|
| |
was the reason they were added, it was never finished and it's not being used
|
| |
|
|
|
|
|
|
|
|
|
| |
When installing packages, an extra line break is added by the "\r" ... echo "\r{$status}";
The $status string typically contain a trailing "\n" as required. This allows to print a message in two steps.
Writing configuration... done.
1) print "Writing configuration..."
2) print "done" after the command completes.
|
| |
|
| |
|
|
|
| |
Sorry, missed a semi-colon!
|
| |
|
|
|
|
| |
verify the CARP vhid and not only the interface (when you have more than one CARP IP on the same interface). Ticket #4858
|
|
|
|
| |
Check against the correct variable. Ticket #4858
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove xmlrpcbaseurl from globals
- Remove xmlrpcpath from globals
- Remove embeddedbootupslice from globals
- Remove call_pfsense_method()
- Remove check_firmware_version()
- Remove get_active_xml_rpc_base_url()
- Remove zeromq.inc
- Remove pkg_mgr_settings.php
- Remove pkg_mgr_settings.php privilege definitions
- Bump config version to 12.3
- Write upgrade code to cleanup $config['altpkgrepo']
- Remove check_firmware_version method from xmlrpc.php
- Fix pfSense_firmware_version_doc text
|
| |
|
|
|
|
| |
Cleaner version of https://github.com/pfsense/pfsense/pull/1846
|
|
|
|
|
|
|
| |
- Remove PPTP server and all related code
- Bump config version 12.2
- Write upgrade config code to remove pptpd section and also cleanup
firewall and NAT rules using PPTP interface or src/des
|
|\ |
|
| |
| |
| |
| |
| |
| | |
This applies the little changes in etc/inc master to the bootstrap
branch so that etc/inc in bootstrap will now just have the real
differences that are due to real bootstrap changes.
|
|\ \
| |/
|/| |
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This rtrim of ".0" is stripping any "0" from the end of the passed-in
version strings. That makes "2.3.10" become "2.3.1" which then removes
any chance of the following nice comparison logic working.
Just removing the "0" seems fine. It keeps the supplied version data
untouched, just getting rid of any trailing dots.
Apart from fixing the bug here, this change has the side-effect that a
version change from "2.3" to "2.3.0" will now be seen as an upgrade.
What is the requirement for that?
Do you want to have extra logic that checks for "bare" zeroes on the end
and make "2.3", "2.3.0", "2.3.0.0"... all be considered the same
version?
This is a resubmit of PR #1810 after integrating with the current
master.
|
|\ \ \
| |/ / |
|
| |/ |
|
|/ |
|
|
|