| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\ |
|
| |
| |
| | |
While looking at notices.inc I noticed (pardon the pun) that notify_all_remote did exactly the same as these 2 lines of code. notify_all_remote() might as well be used here, to save having the same code repeated.
|
|/
|
|
| |
When looking into how the notices features work these days, I found that these functions are no longer used anywhere.
Maybe they should be deleted?
|
| |
|
| |
|
| |
|
|
|
|
| |
when testing SMTP settings
|
|
|
|
|
|
| |
- Added timeout parameter for SMTP configuration
- Removed STARTTLS option, it's enabled automatically by pear-Mail when
server supports it
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
locally or by remote systems where they're shipped. Ticket #6154
|
| |
|
|
|
|
| |
I noticed this while looking at other stuff in notices.inc
If this log_error() call ever happened, it would not have done anything useful.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show.
3) Delete function print_info_box_np_undo() - nothing calls it.
4) Add new function print_apply_box() to provide an easy wrapper for
print_info_box() with the parameters to be 'warning' level and 'apply'
button.
5) Change print_info_box_np() calls to just print_info_box() or
print_apply_box() as appropriate.
There is 1 direct call to print_info_box_np() from vpn_ipsec_mobile.php
remaining. That tries to make a "create" button. It was not working
before this change. It needs to be sorted out and fixed separately.
After this change there is no dependency on a string containing text
like "apply" to make the apply button appear.
Then we can work on re-engineering the internal code of
print_info_box_np() print_info_box() and print_apply_box() to fit
together however we like. It should be easy to preserving the current
API to print_info_box() and print_apply_box().
|
| |
|
|
|
|
|
|
|
| |
- SMTP class from
http://www.phpclasses.org/package/14-PHP-Sends-e-mail-messages-via-SMTP-protocol.html
- Adapt code to current version, only change was tls parameter became
start_tls
|
| |
|
|
|
|
| |
was the reason they were added, it was never finished and it's not being used
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The notices are currently keyed by the Unix time stamp second. If
file_notice() is called more than once in the same second, then the
previous notice is overwritten. Only the last notice in any second
actually ends up in /tmp/notices and thus on the webGUI flashing
display.
The $queuekey value seems to be used to work out the actual time of the
event for display, so it is a bit tricky to change that to a
finer-grained key - callers of these functions are expecting an array
key that is the Unix time in seconds, so all calls to this stuff would
have to be examined and adjusted...
The workaround here is to increment the key if the existing key is
already in use. This allows all notices in the same second to be saved,
but the time of each one will be an incrementing seconds counter, even
though the events all happened in the same second. Maybe that is a
reasonable/practical workaround for now? Given that there should not be
too many notices filed at the same second.
This is a resubmit of PR #1782 integrated with the current master.
|
|
|