| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Problem as per forum https://forum.pfsense.org/index.php?topic=83651.0
The problem comes whenever services_dhcpd_configure is called - the global $config gets reset from the actual current config, and any pending changes in the current process are lost.
It was introduced by commit 86ce2df
in which services_dhcpdv4_configure() does:
require_once('pkg-utils.inc')
and pkg-utils.inc does various stuff like:
if(file_exists("/cf/conf/use_xmlreader"))
require_once("xmlreader.inc");
else
require_once("xmlparse.inc");
which seems to cause a reset of the $config variable, thus losing the pending changes the user has entered at the console.
The top-level code in rc.initial.setlanip really does not need to (and should not) implement any changes along the way - it should collect all the answers from the user, then write_config and then make all the necessary calls to routines to implement the changes on the running system. This fixes it - defer any calls to services_dhcpd_configure() until after all questions are answered and write_config has happened.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
While trying to see why this is not working for me (forum https://forum.pfsense.org/index.php?topic=83651.0 ) I have fixed some little things:
1) Get the new-lines right so the output of the restarting looks neat
2) Fix a comparison that had just a single equal sign - it did not break anything real because the subsequent code was just text output to the console. Now that text output does take notice of the correctly-evaluated condition, and $interface is not overwritten.
The issue in the forum post, about the interface IP address config not actually changing, is still the case, at least for me.
IMO these little tidy ups might as well be committed. They make this code better!
|
| |
|
| |
|
|
|
|
| |
Fixes #3361
|
|
|
|
| |
Fixes #3361
|
| |
|
|
|
|
| |
problems of overriding default gateway by dynamic interfaces. Try to stick to the first found for now!
|
|
|
|
| |
only IP changes that end up here (by design).
|
| |
|
|
|
|
|
|
| |
hidden config option to wipe all states on IP change, as there seemed to
be circumstances where the 'pfctl -k $oldip' didn't suffice for others
(much of history in redmine ticket, some on forum and elsewhere). ticket
|
| |
|
| |
|
|
|
|
| |
ticket #3933
|
| |
|
|
|
|
|
|
|
| |
value. That's a separate issue that needs fixing upstream, but in the mean
time, we can work around it by removing all CARP VIPs in the same way we
do when "Temporarily Disable CARP" is chosen before adding them all back.
Ticket #3910
|
|
|
|
| |
more testing. ticket #1629
|
| |
|
|\ |
|
| |
| |
| | |
so that it can be used for expanding ranges in host alias input.
|
| |
| |
| |
| | |
logical condition to create a new cert if crt or key is not present
|
| |
| |
| |
| | |
page and handbook (only the latter is actually used). Change this to just not use domain, and set the search to the system's domain where not using the function that generates the search list for dynamic WANs.
|
| |
| |
| |
| | |
https://forum.pfsense.org/index.php?topic=79737.msg452808#msg452808
|
|\ \ |
|
| | |
| | |
| | |
| | | |
Fixes redmine #3950 - ip_range_to_subnet_array can easily swap the input parameters if the caller has passed/entered them the wrong way around. That is both friendly to the caller and ensures that a hostile caller can't blow up the routine.
This patch is for master (2.2)
|
|/ /
| |
| |
| | |
waste of screen space
|
| |
| |
| |
| | |
implied), so allow that here. Fixes wrong input validation in parts of nsupdate GUI, among other things.
|
|\ \ |
|
| | | |
|
| | |
| | |
| | |
| | | |
download. Fixes #3576
|
| | | |
|
| | |
| | |
| | |
| | | |
file to speedup the process
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \ |
|
| | | |
| | | |
| | | | |
Was broken by https://github.com/pfsense/pfsense/commit/bd0b5d2dc7a279d3473a65a11d67efb5e39392be
|
|/ / / |
|
| | |
| | |
| | |
| | | |
bootup since it does not only relate to carp interfaces.
|
| | |
| | |
| | |
| | | |
configured settings for bogons. It still does not consider the user/pass configured
|
| | |
| | |
| | |
| | | |
are to be controlled by mask and not created manually!
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
and change the GUI cert generation code to use it. Also, move the GUI cert generation code to its own function so we can add a GUI option to regenerate it later.
Also use some more sane defaults for the contents of the default self-signed certificate's fields so it will be more unique and less likely to trigger problems in browser certificate storage handling.
|
| | |
| | |
| | |
| | | |
redmine ticket, not high priority, can be fixed later
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
any router for forwarding", and "any network device receiving such a
packet MUST NOT forward it". FreeBSD won't route it (route-to can override in
some circumstances), so it can't be in use as a real network anywhere with
the possible exception of local-only networks. Unlikely any such situation
exists anywhere.
Fixes ticket #2073
|
| | | |
|
| | | |
|