| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
and other random stuff I noticed.
I think this finishes messing with code style. The codebase should match
the developer style guide closely enough that 99.9% of changes will not
feel the need to also massage the formatting.
|
| |
|
|
|
|
|
|
|
|
| |
In gwlb.inc at line 676 and 779 I added an extra set of brackets. In the
"if" clause as a whole there were a mix of && and || used that were
relying on the PHP standard that && has precedence over ||
In actual fact the original code should have been working fine, the
extra brackets make sure that the intention is clear.
|
| |
|
|
|
|
|
| |
If IGMP packets are logged (either pass or block) then parse_filter_line did not set their src and dst IP.
Later in the subroutine, it zapped the filter line because it did not have a src and dst.
This fixes it. Now the IGMP lines in /var/log/filter.log appear on the Firewall Log GUI.
|
|
|
| |
and IP version. So that the receiving code can easily have each pat of the IP addresses and ports, and display them as it wishes.
|
|
|
| |
on master
|
|
|
|
|
|
|
| |
- Fix match_filter_field() and also simplify logic
- Fix $filterfieldsarray initialization
- Avoid to have double spaces on filterfieldsarray['act']
- Fix filter on Firewall Logs
|
|
|
|
|
| |
If the user inputs an invalid regex in any of the filter fields, then a page full of "warning" messages appear in the GUI, about whatever is invalid.
If for some reason the user wants to match a forward slash somewhere, then they have to realize to escape it, doing "\/" instead of just "/". Be nice to this special case, because the user does not necessarily know that "/" is being used as the delimiter in the preg_match call. Turn "/" into "\/" (when the "\" is not already put in by the user).
For other regex issues, suppress the warning output, using "@". When the user inputs some invalid garbage in a filter field, an empty filtered firewall log table will be displayed, rather than screens full of PHP warning output.
|
| |
|
|
|
|
| |
in their own row/column when configured for that behavior.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
exec() calls by php functions like symlink, copy, unlink, mkdir
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
using the rules parsing of pf which gives the same effect.
|
| |
|
|
|
|
| |
other places (Easy Rule, etc)
|
| |
|
|
|
|
|
|
| |
In the Firewall Log Widget view time field is of more use than source port and protocol.
Add time field and remove source port and protocol fields.
Fields: Action, Time, Interface, Source IP, Destination IP & Port
|
|
|
|
| |
OUT, rather than the usual 'in'. No indicator is shown for IN.
|
|
|
|
| |
Previous filter form retained for raw logs view.
|
| |
|
|
|
| |
Firewall Logs Widget FilteringOptions to filter on interfaces, 'pass', 'block', & 'reject'
|
| |
|
|
|
|
|
|
|
|
| |
Firewall log alternating colored rows
Firewall log sortable
Fixed several sorting issues in widgets and other pages
Sorting now possible on multiple rows in the header tables
Sorting now possible for text that starts with IPv4:port
|
|
|
|
|
|
|
|
| |
-Not load descriptions
-Show descriptions in a column
-Show descriptions on a second row (after a click on 'show descriptions')
'fixed' a few html validation issues..
|
|
|
|
| |
screen, also layout optimization for "Show raw filter logs".
|
| |
|
|
|
|
|
|
| |
PHP 5.3 this is deprecated and with version 6 gone.
Replacing it surpresses all the warnings
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
etc/inc/easyrule.inc
etc/inc/filter.inc
etc/inc/interfaces.inc
etc/inc/services.inc
etc/inc/xmlrpc_client.inc
usr/local/www/fbegin.inc
usr/local/www/services_dhcp.php
|
| | |
|
| | |
|
| | |
|
|/ |
|
|
|
|
| |
Otherwise it can lead to oddities when crossing a date border. Fixes #478
|
|
|
|
| |
filter log in the GUI.
|
| |
|
|
|
|
| |
user-supplied name rather than wan/opt1/opt2/etc.
|
|
|
|
| |
originally coded this part). Use convert_real_interface_to_friendly_interface_name() instead, since it seems to have special case handling for PPPoE and such now. Tested and working on a static IP setup, still needs tested by a PPPoE user on 2.0. (Logs should show "WAN" in the interface column, not "pppoe0".)
|
|
|
|
| |
called from the CLI (e.g. filterparser.php)
|
|
|
|
|
|
|
|
| |
it, please make sure it works.
Revert "Remove completely bogus code with propper one."
This reverts commit be620dfd9283ee644c57b3c558c7dd603d0f4897.
|
| |
|